From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59158: [PATCH] vc-git: Ensure git doesn't try to colorize stashes Date: Sat, 12 Nov 2022 11:41:54 -0800 Message-ID: References: <868rkgnjib.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26123"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan Smith , 59158@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 20:42:32 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otwOd-0006b4-QQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 20:42:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otwOL-0001ls-Lu; Sat, 12 Nov 2022 14:42:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otwOD-0001gB-TU for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 14:42:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otwOB-00087z-6s for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 14:42:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otwOB-0007Rn-3Q for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 14:42:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 19:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59158 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59158-submit@debbugs.gnu.org id=B59158.166828212128602 (code B ref 59158); Sat, 12 Nov 2022 19:42:03 +0000 Original-Received: (at 59158) by debbugs.gnu.org; 12 Nov 2022 19:42:01 +0000 Original-Received: from localhost ([127.0.0.1]:49063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otwO9-0007RB-Es for submit@debbugs.gnu.org; Sat, 12 Nov 2022 14:42:01 -0500 Original-Received: from mail-oa1-f51.google.com ([209.85.160.51]:43598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otwO8-0007QU-6A for 59158@debbugs.gnu.org; Sat, 12 Nov 2022 14:42:00 -0500 Original-Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-13c2cfd1126so8700240fac.10 for <59158@debbugs.gnu.org>; Sat, 12 Nov 2022 11:42:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=0trtZJAtJ2WvALxnDGak/hlJdpD5QF2iWRMA/PdmJMM=; b=Qn2RR7sg30wBcojtb/ZdL57CNkyIJ/ssOebIP7rdHQyjpslYfwf71oMaGFO6iXNmPK M0B4LEzD10qP8z/VVixf/5aSVQKAtkGWLPVx6lSLgMs683N+UfM8riHH/hZk7A32ttKw xDODODf6S3FsHeZgZlpmAzUK5OaBJDXgoOcKmGMdQcLRjLqg6nxd18lUwBxOP4vo9lUQ W8fzyDc448b271S7g+u0My1GXdnleXtNSrsGfzhidjvJ8tmR989EY4KYB4C96IyLv4oo liOXEiOVC+ffxrCiNq1QLue7Kr5QTXEBa9+huREigQKWLhoVV2TjF13RWzP4IgEB0UnO ZXEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0trtZJAtJ2WvALxnDGak/hlJdpD5QF2iWRMA/PdmJMM=; b=EyG3UOrbdvfAHMESb20IwoH+uIkMafK0SFKmH6xKV1kQyVB9wH+we2RulELDqFzTFW zS1Qi2SBjS1O8k2ItOLDSE/eBhOX+m1oKfFXkx4L1P4i0dLaFCNSbY6LnZ2cnGKogtJW 4HGBIHl8rRabodgZeYWGrLw9vcuUlcCBXgbPcVS33wcwY8TyBlsnTc7y5+515zwJEh+p qcEXlwtKUSBaEOm0bcAvbStC8k5KmlVWPyipM3azFOBzjjHEmEnGaJ67PJn7pu1DHSgl Ect7KY5PcAZxiruHahjmUQ15yU3kjTY8ILhinY4IFouTmdiaqAFN+HVmHRphqvWMSLk/ 0n+w== X-Gm-Message-State: ANoB5pndFDW1/92vaw9I4CGt4tpG0wPuELwCgdrJjSRRJxjL/DqkngTX S7Fu0kevWL/6NhTPHDpY0fjerTgo5Cv4x606D6s= X-Google-Smtp-Source: AA0mqf5eTOhbFoWVFXGU7fm2NSwv8YZbeoEoQjJEM8ingUUkmoyume7IKoXXs5YPfMiGsDw9tH3L/UmNdUXyu6WCSJk= X-Received: by 2002:a05:6870:6c15:b0:13b:8a07:2a1f with SMTP id na21-20020a0568706c1500b0013b8a072a1fmr3909249oab.199.1668282114641; Sat, 12 Nov 2022 11:41:54 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Nov 2022 11:41:54 -0800 In-Reply-To: <868rkgnjib.fsf@mail.linkov.net> X-Hashcash: 1:20:221112:juri@linkov.net::M6TsX5hD7lp8MH4A:4xoe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247688 Archived-At: close 59158 29.1 thanks Juri Linkov writes: >> However, as Emacs can't process those control characters in any case, I >> think we might as well apply the patch you suggest. This will save >> users from shooting themselves in the foot. >> >> Does anyone see any reason not to? > > Since --color=never doesn't look like a new option of git diff, > it should be pretty safe to apply the patch. OK, pushed to master (commit 4ccc385ab1).