From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59224: 29.0.50; Don't use defvar+make-sparse-keymap for example in docs Date: Sun, 10 Sep 2023 16:51:25 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15117"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: 59224-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 11 01:52:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfUE1-0003lI-FL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Sep 2023 01:52:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfUDg-0006Ek-QQ; Sun, 10 Sep 2023 19:52:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfUDe-0006ER-SX for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 19:51:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfUDe-0001HS-Ky for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 19:51:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfUDh-000205-VH for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 19:52:01 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 23:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59224 X-GNU-PR-Package: emacs Mail-Followup-To: 59224@debbugs.gnu.org, stefankangas@gmail.com, stefankangas@gmail.com Original-Received: via spool by 59224-done@debbugs.gnu.org id=D59224.16943899007653 (code D ref 59224); Sun, 10 Sep 2023 23:52:01 +0000 Original-Received: (at 59224-done) by debbugs.gnu.org; 10 Sep 2023 23:51:40 +0000 Original-Received: from localhost ([127.0.0.1]:51531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfUDM-0001zN-5g for submit@debbugs.gnu.org; Sun, 10 Sep 2023 19:51:40 -0400 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:41990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfUDI-0001z7-HX for 59224-done@debbugs.gnu.org; Sun, 10 Sep 2023 19:51:38 -0400 Original-Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-500760b296aso4663224e87.0 for <59224-done@debbugs.gnu.org>; Sun, 10 Sep 2023 16:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694389887; x=1694994687; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=nlAYnEmXEdjS20ro8VgndgzVV0gKXEqMxSiGwArn0PY=; b=ib9lKWykkPr4i78PJIs5xAHcxpfwopdVclBegPEPpX5ql0zBNz7sSdW3QC8b/POZSf lePt8UlPgTO6AABYD6Ta0bKyzgMpEBaaO0MhkPyE2HhidOYYUmuTiS2HV8Ghb+8XJMoi R3i8/Xwpo7/kzSM4t6LpTRgJ2A0b2PpCbeiCceUFCr2sH8ADVLBivTI6jxiqEGCndAqn pqSYUhW2jQh05v/dMOb7NrvBq98CptctgnM0fjOCJ5ZhdWCD299NWTXFocgE52sqfZZj IlJQ9R+BQEExJlgn0S2eYtLENLcCE1RDCQkc1mksTtl3BWHquNafv7KhX+NmBwqrDGDN GvHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694389887; x=1694994687; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nlAYnEmXEdjS20ro8VgndgzVV0gKXEqMxSiGwArn0PY=; b=iliTWhRqIAz+ZqYMX/l5cLWUhUMe0OaHETSwfrRwoKy0QzgSnUYgaGDDsnxxLnnG01 BBe/SZdlk4oqwpBRlMd9KZtpKzznmUjtn3+BU3C4v/aRsyYjN6baml1BMzHEsrAh0c9/ 43RBtDlFtTSv6O4L0gwQE3ngxq5Nr5bu0cF6SU6J92kAqs+hBor4fYv0TPcuPC4Cv7OK zsbmet+fTybepgbtyTis0lFDoLPchbjCxhWtVzMQmRbtRmz3Nm1BfysHYvCZzJC/uggO QB056CrcdB9rM0HX7haLPs32awllK4E+TQ+79eLsrT26Eq0G79kS6O0/PC9H6wPW541i lSrw== X-Gm-Message-State: AOJu0YwbpUWh1mRch4o94yV1sWnDhtKuGFfDN47QNgGt+wtQyEO0Zs6z siqMm4H+m8JC1OSlAjJhevqCAcE96nUP7cX+7yJcuQ+C734= X-Google-Smtp-Source: AGHT+IHzWSD9mVUlq9GkGZUTqd1oDdY6ZIpbI3cFggoRT3SZxWdigUvHRsjYMdMfr6/SVVG8lQJDuhyJ7YkATEOnuBo= X-Received: by 2002:ac2:4db1:0:b0:500:7aba:4d07 with SMTP id h17-20020ac24db1000000b005007aba4d07mr2234434lfe.22.1694389886445; Sun, 10 Sep 2023 16:51:26 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 16:51:25 -0700 In-Reply-To: (Stefan Kangas's message of "Sat, 12 Nov 2022 12:02:31 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270011 Archived-At: Version: 29.2 Stefan Kangas writes: > Severity: wishlist > > In (info "(elisp) Tips for Defining"), we have: > > When defining and initializing a variable that holds a > complicated value (such as a keymap with bindings in it), it=E2=80=99= s best > to put the entire computation of the value into the =E2=80=98defvar= =E2=80=99, like > this: > > (defvar my-mode-map > (let ((map (make-sparse-keymap))) > (keymap-set map "C-c C-a" 'my-command) > ... > map) > DOCSTRING) > > Could we use an example here that is not a keymap (which should be > defined using `defvar-keymap' these days)? > > What would be a good example to use? `make-syntax-table'? I've now changed this example to `make-syntax-table' on emacs-29. If anyone can think of a better example, please speak up and we can reopen the bug for further tweaking.