From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Patch to avoid flicker in Isearch with lazy count Date: Sun, 5 Sep 2021 00:43:45 +0200 Message-ID: References: <87r1m6jsk7.fsf@gmail.com> <87lfce2ruh.fsf@mail.linkov.net> <87tur1bjof.fsf@gmail.com> <871re5e809.fsf@mail.linkov.net> <87tuqzzl7m.fsf@gmail.com> <87mtwqp8d5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3924"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Augusto Stoffel , Emacs developers To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 05 00:44:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMeP1-0000oq-Ad for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Sep 2021 00:44:47 +0200 Original-Received: from localhost ([::1]:37536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMeOz-00019X-Bv for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Sep 2021 18:44:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMeOF-0000SV-VT for emacs-devel@gnu.org; Sat, 04 Sep 2021 18:43:59 -0400 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:37876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMeOE-0002B3-3H for emacs-devel@gnu.org; Sat, 04 Sep 2021 18:43:59 -0400 Original-Received: by mail-pj1-f49.google.com with SMTP id j10-20020a17090a94ca00b00181f17b7ef7so1955962pjw.2 for ; Sat, 04 Sep 2021 15:43:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ert/h9wa99A3rWAYz01cOx7FdcUITvQad0B5cYV/9q4=; b=DACUrApVMvAyOfP+sMsjcLASQFyW/jodbFhqksIOw3WfTZu1ZYRq4Nj6P5T7Be1+h7 8eRSWPRO8O1M7wybTguuZOp8HE7b7c+YOhqKy2/tkb8khHmwrpjg6mcS+ND4Yn+UcXkM u3mlc7unyb9+bsEgO8lBUrGmWl54kbmgDYwNWaTavuuW/GI88reQKdYzN64Q/YZIN7lJ vBC3STzwglcggB9qBgzxbQy79Rr/gS/0dD/fTM+BtQ1wUlMki3KtFs1FMUUevmyZlkqG Dcw1qORw9DuYG+bxz06NYLfmCn9p7rfrc2awEvrOqFirzKNgFKWgTPeTCOO75eBzrxXP fqCA== X-Gm-Message-State: AOAM5313mROhoVY2ONBXPgSOQVGuuPmp/Fbw0/UhmdLoInW/AKp6anno xUXBjT+qvMRNgJGMkmYOo2e5uAB+v/I7bRLUBQE= X-Google-Smtp-Source: ABdhPJzGoVtvYAxmQgmyIq4xEdHsJTCU/4Zis0lkbWKfHvc7vRWMskhYyOXc9BFi1AQ4sF7RdiLVwLxN9kHDTKdxLpc= X-Received: by 2002:a17:90a:7c42:: with SMTP id e2mr6100481pjl.132.1630795436762; Sat, 04 Sep 2021 15:43:56 -0700 (PDT) In-Reply-To: <87mtwqp8d5.fsf@mail.linkov.net> Received-SPF: pass client-ip=209.85.216.49; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273969 Archived-At: Juri Linkov writes: > > I have attached a new patch addressing the issues we discussed. I have > > also changed the name of the new variable a bit, I hope it's a bit more > > self-explanatory now. > > Thanks for the patch, everything looks good. Now pushed to master. [Sorry for coming back to this late, it comes from looking over NEWS in preparation of the upcoming release of Emacs 28.1.] If the variable 'lazy-highlight-no-delay-length' only applies to isearch, shouldn't it rather be named 'isearch-lazy-highlight-no-delay-length'? If it does not only relate to isearch, perhaps this should be clarified in NEWS? The current text is: ** New user option 'lazy-highlight-no-delay-length'. Lazy highlighting of matches in Isearch now starts immediately if the search string is at least this long. 'lazy-highlight-initial-delay' still applies for shorter search strings, which avoids flicker in the search buffer due to too many matches being highlighted. I see that there are several variables starting with 'lazy-highlight', and I know next to nothing about this, so please let me know what you think.