From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error' Date: Wed, 12 Jun 2019 18:47:15 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000020598c058b232b60" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188769"; mail-complaints-to="usenet@blaine.gmane.org" To: 23408@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 12 18:52:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hb6Ti-000mwv-Qs for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 18:52:02 +0200 Original-Received: from localhost ([::1]:33822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb6Th-0006Cr-R8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2019 12:52:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56537) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hb6Pr-0002ry-8n for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hb6Pq-0001xa-BT for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48668) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hb6Pq-0001xH-6K for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hb6Pq-0004mK-3I for bug-gnu-emacs@gnu.org; Wed, 12 Jun 2019 12:48:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23408 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 23408-submit@debbugs.gnu.org id=B23408.156035805718325 (code B ref 23408); Wed, 12 Jun 2019 16:48:02 +0000 Original-Received: (at 23408) by debbugs.gnu.org; 12 Jun 2019 16:47:37 +0000 Original-Received: from localhost ([127.0.0.1]:33979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6PP-0004lS-OL for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:47:37 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:37832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6PN-0004lD-GO for 23408@debbugs.gnu.org; Wed, 12 Jun 2019 12:47:33 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id 22so7263889wmg.2 for <23408@debbugs.gnu.org>; Wed, 12 Jun 2019 09:47:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=JPMzS666xAuyFG8MWLq9CxOmFDQtXSPSIoPjnzaq574=; b=lg02mUrEeL5+aemoc2qIwq4I9EP6K4GU6cVuK979DNpLNVzOzSW1BoD6Jb5r34ELw/ J/8hRd9iljTlPpzobuB+Ro5lT1Gx0Sd7Fjz2t5mhuamB8JsmvaH2Ur71FNV8Leq6qnSA a03YpmONGfcYqF1HEc7LHCsowxTuwQ3NiUsWkSN37b86Kwf0VArY5uKh5dolLI+iowZe 5OmsCOFzEhqRBiTnmb7nhKMsmlX7Q5iR8450J0oBJ36Zq++y/G/ebzMevs0Y9ATLLJ3F ayzcJI8ydjqxvXaCcjseTd1N9ccZzDgPPRKIdBAYKDIn9Fj7aQpTjTFu4LBhfK+HYtZj 7oZQ== X-Gm-Message-State: APjAAAVEssICucMs+1gJZ6EWxSc8BZjKvZ3326T9T1ttfsc2nqHgPrLK 4TKQH+Dr0RGOKsKBC7EPpDXfeJYzkXO/GL35qbhQkFs9 X-Google-Smtp-Source: APXvYqxVc98vVP27+jAk0gpHhoQ+XeRTCMuH8JONtusgXYlG9NkiWIOLwvBo33Pr1mGVUg7jLWsq7DioJFWEAF8i6Cg= X-Received: by 2002:a1c:9696:: with SMTP id y144mr83577wmd.73.1560358047194; Wed, 12 Jun 2019 09:47:27 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160457 Archived-At: --00000000000020598c058b232b60 Content-Type: text/plain; charset="UTF-8" Drew Adams writes: > bookmark.el uses `define-error' without passing a string for argument > MESSAGE. > > Emacs Dev had decided that this is incorrect usage, and thus that > `define-error' does not provide the same functionality as you get by > using property `error-conditions' directly. The attached patch should fix this. Thanks, Stefan Kangas --00000000000020598c058b232b60 Content-Type: application/octet-stream; name="0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch" Content-Disposition: attachment; filename="0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwtgua9w0 RnJvbSBiOTFlZDlhYjUyMmY0ODE4MzA4Yzk4NGNhZDZmMTVmNTA5N2Y2ZWVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDEyIEp1biAyMDE5IDE4OjQyOjQ2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIE1FU1NBR0Ugc3RyaW5nIHRvIGJvb2ttYXJrLWVycm9ycyAoYnVnIzIzNDA4KQoKKiBsaXNw L2Jvb2ttYXJrLmVsIChib29rbWFyay1lcnJvcnMpOiBBZGQgTUVTU0FHRSBwYXJhbWV0ZXIgc3Ry aW5nLgotLS0KIGxpc3AvYm9va21hcmsuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvYm9va21hcmsuZWwg Yi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4IDVhOTg1OWQ4M2QuLmE2OTkxOWNjMDggMTAwNjQ0Ci0t LSBhL2xpc3AvYm9va21hcmsuZWwKKysrIGIvbGlzcC9ib29rbWFyay5lbApAQCAtMTE3Miw3ICsx MTcyLDggQEAgYm9va21hcmstaGFuZGxlLWJvb2ttYXJrCiAgICAgKHNldHEgYm9va21hcmstY3Vy cmVudC1ib29rbWFyayBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpCiAgIG5pbCkKIAotKGRlZmlu ZS1lcnJvciAnYm9va21hcmstZXJyb3JzIG5pbCkKKyhkZWZpbmUtZXJyb3IgJ2Jvb2ttYXJrLWVy cm9ycworICAiQm9va21hcmsgZXJyb3IiKQogKGRlZmluZS1lcnJvciAnYm9va21hcmstZXJyb3It bm8tZmlsZW5hbWUKICAgIkJvb2ttYXJrIGhhcyBubyBhc3NvY2lhdGVkIGZpbGUgKG9yIGRpcmVj dG9yeSkiICdib29rbWFyay1lcnJvcnMpCiAKLS0gCjIuMjEuMAoK --00000000000020598c058b232b60--