* bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
@ 2016-04-30 19:35 Drew Adams
2019-06-12 16:47 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2016-04-30 19:35 UTC (permalink / raw)
To: 23408
See bug #20625.
Summary:
bookmark.el uses `define-error' without passing a string for argument
MESSAGE.
Emacs Dev had decided that this is incorrect usage, and thus that
`define-error' does not provide the same functionality as you get by
using property `error-conditions' directly.
Either change the bookmark.el code to use `error-conditions' directly
(as before) or change it to provide a string MESSAGE arg for the
definition of `bookmark-errors'.
In GNU Emacs 25.0.90.4 (i686-w64-mingw32)
of 2016-03-20
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --host=i686-w64-mingw32 --without-dbus
--without-compress-install CFLAGS=-static'
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
2016-04-30 19:35 bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error' Drew Adams
@ 2019-06-12 16:47 ` Stefan Kangas
2019-06-12 17:12 ` Drew Adams
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2019-06-12 16:47 UTC (permalink / raw)
To: 23408
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
Drew Adams <drew.adams@oracle.com> writes:
> bookmark.el uses `define-error' without passing a string for argument
> MESSAGE.
>
> Emacs Dev had decided that this is incorrect usage, and thus that
> `define-error' does not provide the same functionality as you get by
> using property `error-conditions' directly.
The attached patch should fix this.
Thanks,
Stefan Kangas
[-- Attachment #2: 0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch --]
[-- Type: application/octet-stream, Size: 837 bytes --]
From b91ed9ab522f4818308c984cad6f15f5097f6eef Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 12 Jun 2019 18:42:46 +0200
Subject: [PATCH] Add MESSAGE string to bookmark-errors (bug#23408)
* lisp/bookmark.el (bookmark-errors): Add MESSAGE parameter string.
---
lisp/bookmark.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 5a9859d83d..a69919cc08 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1172,7 +1172,8 @@ bookmark-handle-bookmark
(setq bookmark-current-bookmark bookmark-name-or-record))
nil)
-(define-error 'bookmark-errors nil)
+(define-error 'bookmark-errors
+ "Bookmark error")
(define-error 'bookmark-error-no-filename
"Bookmark has no associated file (or directory)" 'bookmark-errors)
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
2019-06-12 16:47 ` Stefan Kangas
@ 2019-06-12 17:12 ` Drew Adams
2019-06-15 21:45 ` Noam Postavsky
0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2019-06-12 17:12 UTC (permalink / raw)
To: Stefan Kangas, 23408
> The attached patch should fix this.
LGTM. Thx.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
2019-06-12 17:12 ` Drew Adams
@ 2019-06-15 21:45 ` Noam Postavsky
0 siblings, 0 replies; 4+ messages in thread
From: Noam Postavsky @ 2019-06-15 21:45 UTC (permalink / raw)
To: Drew Adams; +Cc: Stefan Kangas, 23408
tags 23408 fixed
close 23408 27.1
quit
Drew Adams <drew.adams@oracle.com> writes:
>> The attached patch should fix this.
>
>
> LGTM. Thx.
Pushed to master.
cdd8cb3a9e 2019-06-15T17:08:58-04:00 "Add MESSAGE string to bookmark-errors (bug#23408)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cdd8cb3a9e18f87da31e52236fd2c4ebfcd676bd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-15 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-30 19:35 bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error' Drew Adams
2019-06-12 16:47 ` Stefan Kangas
2019-06-12 17:12 ` Drew Adams
2019-06-15 21:45 ` Noam Postavsky
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.