bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Drew Adams <drew.adams@oracle.com> writes:
> bookmark.el uses `define-error' without passing a string for argument
> MESSAGE.
>
> Emacs Dev had decided that this is incorrect usage, and thus that
> `define-error' does not provide the same functionality as you get by
> using property `error-conditions' directly.

The attached patch should fix this.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch --]
[-- Type: application/octet-stream, Size: 837 bytes --]

From b91ed9ab522f4818308c984cad6f15f5097f6eef Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 12 Jun 2019 18:42:46 +0200
Subject: [PATCH] Add MESSAGE string to bookmark-errors (bug#23408)

* lisp/bookmark.el (bookmark-errors): Add MESSAGE parameter string.
---
 lisp/bookmark.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 5a9859d83d..a69919cc08 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1172,7 +1172,8 @@ bookmark-handle-bookmark
     (setq bookmark-current-bookmark bookmark-name-or-record))
   nil)
 
-(define-error 'bookmark-errors nil)
+(define-error 'bookmark-errors
+  "Bookmark error")
 (define-error 'bookmark-error-no-filename
   "Bookmark has no associated file (or directory)" 'bookmark-errors)
 
-- 
2.21.0