From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57691: 29.0.50; image-tests failures Date: Mon, 12 Sep 2022 09:23:54 -0400 Message-ID: References: <83y1utcbcl.fsf@gnu.org> <83illwdauv.fsf@gnu.org> <83czc4d7up.fsf@gnu.org> <83h71fbw4n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57691@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 12 15:29:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXjUo-0005cE-9k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 15:29:06 +0200 Original-Received: from localhost ([::1]:55358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXjUn-0003bi-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 09:29:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXjQt-00083k-9a for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 09:25:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXjQs-0007ON-Al for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 09:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXjQs-0006Wy-7U for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 09:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2022 13:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57691 X-GNU-PR-Package: emacs Original-Received: via spool by 57691-submit@debbugs.gnu.org id=B57691.166298904224973 (code B ref 57691); Mon, 12 Sep 2022 13:25:02 +0000 Original-Received: (at 57691) by debbugs.gnu.org; 12 Sep 2022 13:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:44614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXjPt-0006Ue-L5 for submit@debbugs.gnu.org; Mon, 12 Sep 2022 09:24:01 -0400 Original-Received: from mail-oa1-f44.google.com ([209.85.160.44]:43749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXjPs-0006UO-Ex for 57691@debbugs.gnu.org; Mon, 12 Sep 2022 09:24:00 -0400 Original-Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-1279948d93dso23244160fac.10 for <57691@debbugs.gnu.org>; Mon, 12 Sep 2022 06:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=5HExTtH2M+x68Ft6wLVBNhHNLKu6FfIztvwylHpE1Os=; b=IGRFHMIFuCDAgMxAEPjbewemR18lTW+Cva2sMzrT0uWEomPwXe3ID37dm6fD6htoea QQ8B8AvkjC13EUDPu7Id5RZ6MSL8W0tvz1Q8VxhJuKFKeeTMOqB6buqbQdlPxRK26osx 0H5XbkcUeHYaO3s0R247y3I+/mzkdnF+DqOccSePzPGgfXQ8JOvxzC+rdXkg56NV79sK gtu+LAQbyJZc2zoEW7MGGgY/vAwCj3d9ka4T6RCRQOXKlzoEsr9ub06WCm0ScLx4BQYL Z8iPJZqZR0BTnWUaIXYpF/zCtC0nxGG5j2F+UXQqLdqDTJxpyciprjSIgzXAggGCSvk1 rwlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=5HExTtH2M+x68Ft6wLVBNhHNLKu6FfIztvwylHpE1Os=; b=YFv3tnU62RaE1TeZVvxC8dYzr9I0QAM2FANUBq4ulmNXTrNI2fYBjSMSeYKn9CXK3V Ge0JqLRz1aO6hud/7dEXJ5Rpxp51CYtYJ6nXm/Yngww8HWVMGZjH7wj/mbmuC3Ryj2rj orGm0ojLp/VvT0ldlVGBUeMJyZfmsRrzAkT1plZU5kcKReh9Cu8kYj2E+aEiHF4bIwYZ tcGpnPeYz/qiMtbJLKk/91gw1VQyjuOfVL9tii0XL5kbjQ+pxIJUkpAg6dKkABT3eEnJ 00Wypyb8B5ZsiEbfbWKB2WdUhk6UQad8hAf9XdITwd08YqYEGLNDRBly6O+da03rOYoI Hlzw== X-Gm-Message-State: ACgBeo2Bj3eUhxt30wc7GgWO+/BGYR+GO58StpuRG2c8FiYza6eGkzea 7fpT1JB1VgB3b+ckghlbq5rzNPDOgGw+9Zyu/oE= X-Google-Smtp-Source: AA6agR4vEtMhi8/AQ+zVcnVAbdZKSPD+CvkWW9gFHZAW9znluuJJhoRfL6CXodtnRvxm45rFU1fBv43ddCoRHYkDKF4= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr9034350oib.199.1662989034699; Mon, 12 Sep 2022 06:23:54 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 12 Sep 2022 09:23:54 -0400 In-Reply-To: <83h71fbw4n.fsf@gnu.org> X-Hashcash: 1:20:220912:57691@debbugs.gnu.org::3U/AJds8WLZnnyWf:27ty X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242275 Archived-At: Eli Zaretskii writes: >> It used to just check that no metadata was returned for these images. >> Then Lars changed the GIF and WebP loading code to always add a `delay', >> so I adapted the tests to that. > > Is it important to verify that the 'delay' stuff is in metadata? If > not, how about just removing that part of the test? It's not crucial to check that part, I'm just not sure what to do instead. Ideally, we would test for something more substantial, of course, and I hope to get to that eventually. Maybe it's okay to leave it as a wishlist item for now (i.e. the "TODO" comment in manual/image-tests.el). > I'd rather we skipped the test if w32-use-native-image-API is non-nil. This should now be done on master. Could you please test?