From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57691@debbugs.gnu.org
Subject: bug#57691: 29.0.50; image-tests failures
Date: Mon, 12 Sep 2022 09:23:54 -0400 [thread overview]
Message-ID: <CADwFkmnBCXDMzpuYwDA7_PGe8fNuD3pVr3DyLgj9co-+EwvhKQ@mail.gmail.com> (raw)
In-Reply-To: <83h71fbw4n.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> It used to just check that no metadata was returned for these images.
>> Then Lars changed the GIF and WebP loading code to always add a `delay',
>> so I adapted the tests to that.
>
> Is it important to verify that the 'delay' stuff is in metadata? If
> not, how about just removing that part of the test?
It's not crucial to check that part, I'm just not sure what to do
instead.
Ideally, we would test for something more substantial, of course, and I
hope to get to that eventually. Maybe it's okay to leave it as a
wishlist item for now (i.e. the "TODO" comment in
manual/image-tests.el).
> I'd rather we skipped the test if w32-use-native-image-API is non-nil.
This should now be done on master. Could you please test?
next prev parent reply other threads:[~2022-09-12 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 6:26 bug#57691: 29.0.50; image-tests failures Eli Zaretskii
2022-09-09 9:03 ` Stefan Kangas
2022-09-09 11:51 ` Eli Zaretskii
2022-09-09 12:44 ` Stefan Kangas
2022-09-09 12:56 ` Eli Zaretskii
2022-09-09 22:37 ` Stefan Kangas
2022-09-10 6:07 ` Eli Zaretskii
2022-09-12 13:23 ` Stefan Kangas [this message]
2022-09-12 16:00 ` Eli Zaretskii
2022-09-13 9:40 ` Stefan Kangas
2022-09-13 12:05 ` Eli Zaretskii
2022-09-09 12:44 ` Stefan Kangas
2022-09-09 12:57 ` Eli Zaretskii
2022-09-09 22:37 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnBCXDMzpuYwDA7_PGe8fNuD3pVr3DyLgj9co-+EwvhKQ@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=57691@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.