From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#29665: 26.0.90; auth-source-pass decrypts entries 3 times on query Date: Tue, 11 Aug 2020 20:12:48 -0700 Message-ID: References: <87pnmcwkbr.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: John Wiegley , 29665@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 12 05:13:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5hCR-0003A1-VE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 05:13:11 +0200 Original-Received: from localhost ([::1]:53412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5hCQ-0000AI-KP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 23:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5hCI-00009v-Lg for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 23:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5hCI-0004tF-C5 for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 23:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5hCI-00078V-6O for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 23:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 03:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29665 X-GNU-PR-Package: emacs Original-Received: via spool by 29665-submit@debbugs.gnu.org id=B29665.159720197827422 (code B ref 29665); Wed, 12 Aug 2020 03:13:02 +0000 Original-Received: (at 29665) by debbugs.gnu.org; 12 Aug 2020 03:12:58 +0000 Original-Received: from localhost ([127.0.0.1]:42413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5hCE-00078C-65 for submit@debbugs.gnu.org; Tue, 11 Aug 2020 23:12:58 -0400 Original-Received: from mail-yb1-f173.google.com ([209.85.219.173]:42615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5hCA-00077u-N0 for 29665@debbugs.gnu.org; Tue, 11 Aug 2020 23:12:56 -0400 Original-Received: by mail-yb1-f173.google.com with SMTP id a34so580872ybj.9 for <29665@debbugs.gnu.org>; Tue, 11 Aug 2020 20:12:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=Lp2MZV1YwMyRw9P2GbHexId3MXKe4/Oa3mccjjBAKSc=; b=BJPgvYW0J4axvOHArfF30ii91AFmKS8cyDVfzbX0Grt1ZnF+FexrQSHrby2NbGSJDD hKjsYrmEe0ev7AsPVfCYxHO10G9JiIWtKiR49OrveeLI0rycRFxidbSolXzqol1tVqqv Dea11T6yVbDudoP1GgjSPjfiCQzWJqqDhJ2i2AENMnv27c7RjJ8YJHWi66yYRoBvwiUo TTonWCMee1P5lok5h4Wut5Zr0wPdJlBn+rAh9eaq+SL7gwEWZ+fiDijsB11MFnaDb/m2 WHhUtYacA4BX30qkw/KOtz5WASF6iCsEfTuBDhsw4dezwk3e4F3ymQRK35mytm42/5Fr YB2Q== X-Gm-Message-State: AOAM531H0nqphFaZCh06BmZ/kcVOvykA7cJ4RqZ9jdx1X2w5WH9UlLjT QJFFdVfwDkXzR726N3XQwBQEGf4NH6eTZ+gP0oo= X-Google-Smtp-Source: ABdhPJxaSh6Pt+BhMePlq0Ti7n5CZHCQMy3Wp6rd9cpsH8znq/wgzdfV5Ru5xuczcubPt7Y++kZf9qIsrXaxorvay7k= X-Received: by 2002:a25:b88b:: with SMTP id w11mr55123234ybj.129.1597201969328; Tue, 11 Aug 2020 20:12:49 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Aug 2020 20:12:48 -0700 In-Reply-To: <87pnmcwkbr.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sun, 14 Jul 2019 20:19:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184735 Archived-At: Lars Ingebrigtsen writes: > "John Wiegley" writes: > >> I've enabled auth-source-pass on my system as follows: >> >> (use-package auth-source-pass >> :config >> (auth-source-pass-enable) >> >> (defun auth-source-pass--read-entry (entry) >> "Return a string with the file content of ENTRY." >> (with-temp-buffer >> (insert-file-contents (expand-file-name >> (format "%s.gpg" entry) >> (getenv "PASSWORD_STORE_DIR"))) >> (buffer-substring-no-properties (point-min) (point-max)))) >> >> (defun auth-source-pass-entries () >> "Return a list of all password store entries." >> (let ((store-dir (getenv "PASSWORD_STORE_DIR"))) >> (mapcar >> (lambda (file) (file-name-sans-extension (file-relative-name file store-dir))) >> (directory-files-recursively store-dir "\.gpg$"))))) >> >> This works around the other bug I logged today. I have one file in my store: >> >> ~/doc/.passwords/reddit.com >> >> It has a "login: jwiegley" field. I then run: >> >> (auth-source-search :host "reddit.com" :user "jwiegley") >> >> After doing so, I can see it Decrypting the reddit.com.gpg file three times >> before it shows me the data, even with `auth-source-do-cache' set to t. > > The test case is a bit complicated, but I instrumented the normal > ~/.authinfo reading, and it seemed to me that it would only read the > file once when I do the auth-source-search. > > Does this work better for you too now? No reply here within 12 months. Yesterday, I accidentally replied individually to Lars only, asking if there is more to do here or if this should be closed. He replied saying that it should probably be closed. Does anyone else have an opinion here? Otherwise, I'll just go ahead and close this. Best regards, Stefan Kangas