From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#45550: [PATCH] Factor out new function for readability in chartab.c Date: Wed, 30 Dec 2020 15:16:05 -0600 Message-ID: References: <83k0szhwz1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18707"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45550@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 22:17:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuiqE-0004kw-Dm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 22:17:10 +0100 Original-Received: from localhost ([::1]:37876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuiqD-0005sr-H2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 16:17:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuiq6-0005sh-LD for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 16:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuiq6-0005xU-Dp for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 16:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuiq6-0007RG-8g for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 16:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45550 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45550-submit@debbugs.gnu.org id=B45550.160936297328529 (code B ref 45550); Wed, 30 Dec 2020 21:17:02 +0000 Original-Received: (at 45550) by debbugs.gnu.org; 30 Dec 2020 21:16:13 +0000 Original-Received: from localhost ([127.0.0.1]:51210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuipJ-0007Q5-J1 for submit@debbugs.gnu.org; Wed, 30 Dec 2020 16:16:13 -0500 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:34225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuipH-0007Ps-M9 for 45550@debbugs.gnu.org; Wed, 30 Dec 2020 16:16:11 -0500 Original-Received: by mail-pf1-f176.google.com with SMTP id w6so10299678pfu.1 for <45550@debbugs.gnu.org>; Wed, 30 Dec 2020 13:16:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=1wdqnPFqvb9cQ6n/r+dKBBN/4M2r23/Hn8MuJpclNDc=; b=Un5CKm06H7x9+4JR0RmmTnZSzEEiajHF4p1GLOusDahUttHbgxBlh91psfJNeSfpHf DtbzJNOvKDhLYcbwBfxkiT8XkgFFzxfsEf4jZ3M0iDgMUqaEavr0aXyBBUyoT1DgbFlD WvaVdlZPGJMJqnBH3B9B8pjbPmPPcCFrTD6vfApfjUyZewRWS70gFrJMJ7mq+C+MXx7a dqD5DVXryg8GWl+TBldisX1CZ+IJoP+G7jTNJp+NjOeacqPDZU77qpJVVxZzg58XzQXF GPcVU5fUrz4xNUIaBclT9i+5VtyQikVzHVHDTiSn+b0k1Tm31uNbz4oCbSViqJyPuvmS p1hQ== X-Gm-Message-State: AOAM531LJSRwghu6Q+Fj8/Yj+ww6Jm8CQeh2hque1uVOiAaHEvFh4biG /Vu7rxiW3zEsdlT6nCL5LCs9wp9SoZlDyikO18WSlkPWiKY= X-Google-Smtp-Source: ABdhPJyZ3DxSomU2LxyXt1Yi91BjRsoVfTJJh1ltlhllbWfN/pPcpql94efoCUefQZHOAUS4K4Khu3Tp7+10qtfWWMI= X-Received: by 2002:a63:e40e:: with SMTP id a14mr53843480pgi.345.1609362965909; Wed, 30 Dec 2020 13:16:05 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 30 Dec 2020 15:16:05 -0600 In-Reply-To: <83k0szhwz1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197051 Archived-At: Eli Zaretskii writes: > Please make this a macro, not a function. The code you are factoring > out is called in the innermost loops of the display engine, in bidi.c, > so it must be as fast as possible, even in an unoptimized build, where > static functions aren't inlined. Would it be acceptable to use our INLINE macro here instead? I see that it is used quite a lot in dispextern.c. Otherwise, I can of course rewrite it to use a macro instead.