all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 45550@debbugs.gnu.org
Subject: bug#45550: [PATCH] Factor out new function for readability in chartab.c
Date: Wed, 30 Dec 2020 15:16:05 -0600	[thread overview]
Message-ID: <CADwFkmn9KeOb=fZzcAoWDhPP8PZ5t7XUNwc_hdjLxcfna0k2_g@mail.gmail.com> (raw)
In-Reply-To: <83k0szhwz1.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> Please make this a macro, not a function.  The code you are factoring
> out is called in the innermost loops of the display engine, in bidi.c,
> so it must be as fast as possible, even in an unoptimized build, where
> static functions aren't inlined.

Would it be acceptable to use our INLINE macro here instead?  I see that
it is used quite a lot in dispextern.c.  Otherwise, I can of course
rewrite it to use a macro instead.





  reply	other threads:[~2020-12-30 21:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30  8:56 bug#45550: [PATCH] Factor out new function for readability in chartab.c Stefan Kangas
2020-12-30 20:15 ` Eli Zaretskii
2020-12-30 21:16   ` Stefan Kangas [this message]
2020-12-31  3:29     ` Eli Zaretskii
2021-07-21 12:03       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmn9KeOb=fZzcAoWDhPP8PZ5t7XUNwc_hdjLxcfna0k2_g@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=45550@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.