From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44172: bug#49347: image-save not working as expected for transformed image saving! Date: Sat, 6 Nov 2021 01:00:10 -0700 Message-ID: References: <87mu0dgpgv.fsf@gnus.org> <87lf29ns9v.fsf@gnus.org> <87cznlmc9k.fsf@gnus.org> <87ee7udsou.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29373"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49347@debbugs.gnu.org, 44172@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 06 09:01:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjGdT-0007O7-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 09:01:11 +0100 Original-Received: from localhost ([::1]:44264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjGdR-00082g-MC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Nov 2021 04:01:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjGdK-00082A-E3 for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 04:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjGdK-0000lA-5A for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 04:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjGdK-0006Hx-3m for bug-gnu-emacs@gnu.org; Sat, 06 Nov 2021 04:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Nov 2021 08:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44172 X-GNU-PR-Package: emacs Original-Received: via spool by 44172-submit@debbugs.gnu.org id=B44172.163618561924090 (code B ref 44172); Sat, 06 Nov 2021 08:01:02 +0000 Original-Received: (at 44172) by debbugs.gnu.org; 6 Nov 2021 08:00:19 +0000 Original-Received: from localhost ([127.0.0.1]:48251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjGcd-0006GO-3i for submit@debbugs.gnu.org; Sat, 06 Nov 2021 04:00:19 -0400 Original-Received: from mail-pj1-f42.google.com ([209.85.216.42]:34493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjGcb-0006G6-Ay; Sat, 06 Nov 2021 04:00:17 -0400 Original-Received: by mail-pj1-f42.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so3909460pjb.1; Sat, 06 Nov 2021 01:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=HGNkP4CkG5jWtWxhBQupuq4P5FnwqIaxdWzOjuqxBs8=; b=eijQEmS9Q586Xju2cDGev9h3z8b7MJbbfMeVjWcZOSRuv2MUNRf18JZU452vZNILq6 4TWVAlL+xonxcJlJCKyLYpmNag5KOA7M5IlktvM0HDhuP7tgogl4In5imYp+BdDbqsYg mdshC2PHv0eUsdXPwzIzx3ahzA/fN58H4zWKu/+mjw/8trvyxuVlQFF1e4mKsTPVUkqd v6SCCOqVaC1fT0Rl/RKcitJGq77/n813ztqnzSwA1CfQlomSdfHPbf1yfl9471NzGu00 lvL1YwU1KwOAxGCJ6mhcopqhjnCwNjzHEPFuf7ueKRegPiq9yWamteCoEZV7NLWDTUGw Ubrw== X-Gm-Message-State: AOAM531LHDJdCRgcmZAfazjoYYotsGJNE/k/SzSKhuoWtP9oP+SxXCIq exJpsqAP2LrdOVHQtWK5QP2kYdmB8Sng/s4E8aA= X-Google-Smtp-Source: ABdhPJyKYl7RAK8PA78TPL6Wf9O6H9jg7LAhRj9dPKhBobjo3n1Cv9E/BqFZkQH6xJAxKNdvIDlGfGcm4Sy2VT9XadE= X-Received: by 2002:a17:90a:4414:: with SMTP id s20mr32879110pjg.132.1636185611541; Sat, 06 Nov 2021 01:00:11 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 6 Nov 2021 01:00:10 -0700 In-Reply-To: <87ee7udsou.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219081 Archived-At: Lars Ingebrigtsen writes: > It's not very useful in `image-mode' buffers, but it's nice for > consistency, perhaps? I think whenever you see an image in Emacs, you > should be able to interact with it that way. I'm all for consistency, but in this case I think it confuses more than it helps. Actually, to explain what I think, "rotate" is an even better example than "save", so please bear with me: - eww: I'm hard-pressed to think of a case when I have ever wanted to rotate an image on a website. - image-dired-thumbnail-mode: the thumbnails are currently rotatable, but that just makes it go out of synch with the picture. - In the icons.el library I'm working on, we will use SVG images as icons. They should not rotate on "r". The same goes for the logo on the about/splash screen, etc. IOW, I think we should consider "what might the user want to do with an image here?" and then provide the bindings to do that. The consistency I would go for is more along the line of "every time you rotate an image, it is the 'r' key" rather than "you can always rotate an image, anywhere, even if it makes no sense". For `image-save' specifically, I think this command makes sense in eww as you will obviously want to be able to save images from websites. I also think it would make obvious sense in a new `image-edit-mode'. But I don't see that it makes sense in `image-mode' that is fundamentally about displaying an image in various ways, and where users might be lead to think that any activated display options (scaling, etc.) will be reflected in a saved file.