From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44673: [PATCH] Use lexical-binding in time-stamp.el Date: Mon, 16 Nov 2020 10:49:19 -0800 Message-ID: References: <59996.1605547995@quatro> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44673@debbugs.gnu.org To: Stephen Gildea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 16 20:12:50 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kejvl-000ANa-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 20:12:49 +0100 Original-Received: from localhost ([::1]:38996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejvk-0005qY-Kf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 14:12:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejZi-0004XX-Q0 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 13:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kejZi-0003hg-Ci for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 13:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kejZi-0000Jr-9N for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 13:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2020 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44673-submit@debbugs.gnu.org id=B44673.16055525711181 (code B ref 44673); Mon, 16 Nov 2020 18:50:02 +0000 Original-Received: (at 44673) by debbugs.gnu.org; 16 Nov 2020 18:49:31 +0000 Original-Received: from localhost ([127.0.0.1]:57216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejZD-0000Iz-EE for submit@debbugs.gnu.org; Mon, 16 Nov 2020 13:49:31 -0500 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:36749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejZA-0000Ie-6m for 44673@debbugs.gnu.org; Mon, 16 Nov 2020 13:49:30 -0500 Original-Received: by mail-ed1-f51.google.com with SMTP id m16so4932533edr.3 for <44673@debbugs.gnu.org>; Mon, 16 Nov 2020 10:49:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=uKffDijfL0zypT6RgkhoKe+aHixWRaPrTpV9Ims3rKI=; b=tDPocZz1jKzAQibKkaC0vAEYGDOD0T24axseIDBYYaYOtz6/8rfy4UB0Q9YBdzamVS 0eLVAZCcBeuL+6wKDfeMfW/SQuX5Kn8osXxDdlfY3rOUAbDpVVk/U1VSRWM5/r/V7Iic fl/ZhoW6QRc6C+UHBRuEpWVBmPHddA9KF0GDCvN/CbnyoRkjgTeF7hhOTzsvXPeXfqcx 11siKo4o7BF1bo+Yzos7H6g36/dK1qpMZI5jWTLoyOgQhbqxaP4d3rYwH4plAIqaXBn/ 0OrkZwK9gaR+tMhNgMhSmQEZO4cpG21W2IaUqm74kgF4St15wyy6LAq+8kmczOSAOuib vcrw== X-Gm-Message-State: AOAM533n8ZbUYH1aCVzwQHIcJslXqvM6IUotY1ZIVj0u6z6imRtPpE08 X6/bWuCcJoyxfM1qwEwVaKsYPLQ2V86mN3sDRK0= X-Google-Smtp-Source: ABdhPJz8OkXlGLnP7568+5k1g3k4E9c4qGk/HyqpHLuzqxrrITD5i+PVO/JIxoVSKRWsdh3GPLp8O/CLsN2tkW2PnlU= X-Received: by 2002:a50:e443:: with SMTP id e3mr17661220edm.160.1605552562348; Mon, 16 Nov 2020 10:49:22 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 16 Nov 2020 10:49:19 -0800 In-Reply-To: <59996.1605547995@quatro> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193460 Archived-At: close 44673 28.1 thanks Stephen Gildea writes: >> Do you think we could safely enable lexical-binding in time-stamp.el? >> I ran the test suite with the attached patch and all tests are still >> passing. > > I reviewed the code, and lexical binding looks good to me. > > Thank you. Thanks! Pushed to master as commit 7dd671f7f2.