From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51484: [PATCH] Move runtime check for recent giflib to compile time Date: Fri, 29 Oct 2021 11:15:04 -0700 Message-ID: References: <835ytfrevd.fsf@gnu.org> <83y26bpvc0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51484-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 29 20:16:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgWQQ-0007ZH-Vr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 20:16:22 +0200 Original-Received: from localhost ([::1]:60506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgWQO-0001ay-Aw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Oct 2021 14:16:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgWQ6-0001Wl-W8 for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44322) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgWQ6-000514-LA for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgWQ6-0006PA-8B for bug-gnu-emacs@gnu.org; Fri, 29 Oct 2021 14:16:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Oct 2021 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51484 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 51484@debbugs.gnu.org, stefan@marxist.se, stefan@marxist.se Original-Received: via spool by 51484-done@debbugs.gnu.org id=D51484.163553131224535 (code D ref 51484); Fri, 29 Oct 2021 18:16:02 +0000 Original-Received: (at 51484-done) by debbugs.gnu.org; 29 Oct 2021 18:15:12 +0000 Original-Received: from localhost ([127.0.0.1]:55868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgWPH-0006Ne-Nm for submit@debbugs.gnu.org; Fri, 29 Oct 2021 14:15:11 -0400 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:42619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgWPG-0006NK-Bg for 51484-done@debbugs.gnu.org; Fri, 29 Oct 2021 14:15:10 -0400 Original-Received: by mail-pj1-f54.google.com with SMTP id nn3-20020a17090b38c300b001a03bb6c4ebso7942478pjb.1 for <51484-done@debbugs.gnu.org>; Fri, 29 Oct 2021 11:15:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=6qhFjYk41/sGyZT2eAgF5fBSsEAUEQ3kzmOGwpi+EhE=; b=w4yImZ42iXtjnJDEaTe+JkCeCmyNbAtFWHJf7ZSsa6lX5GGgnFN7QW2y2PlA1pJ79+ XvO93t2g8nyO3X3EZyf4AeryiFObGbcUc1+vx0mSsQ6s5HLCNqANZNyWwWBwoebQyj3H yoc1trZ7dhCOdWN3c2Nj6e8FvXZ9gwIxrttvjAaxRc+g2XL+vUbuXYsjTjAJYzY0YoS9 HOQcf8d7B1GiCs1dx+gRaKq0AYQD77NBoMFDtkAf5gfqq91nbNUI/mOHkW7iofgaFjsZ IuG6aPXGuabMRWjGa6nUiKXOGOM7102gjsa/VI0TbhkGgcbG9MGRHj2M4aDZES0qNnfs Zg+w== X-Gm-Message-State: AOAM5331j/L6Uq7KaEEn48E1CHjb1cTJyOaBVsIVRx3n6nNY8j3zkdOy 5idD6JpNIwea1/DL5Fq+2e19cLmD4qIu01sa6iU= X-Google-Smtp-Source: ABdhPJyBCOaiI3OYQ4+smFXvveUf1mbuS2G+wE/LwKDiIootfXzs5MTr8KwYffqJ1QDxfc3jCuqyv8nJkV6ESxJx8Sc= X-Received: by 2002:a17:90b:17d2:: with SMTP id me18mr21414667pjb.132.1635531304580; Fri, 29 Oct 2021 11:15:04 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 29 Oct 2021 11:15:04 -0700 In-Reply-To: <83y26bpvc0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218585 Archived-At: Eli Zaretskii writes: > I generally prefer to avoid #ifdef's, so I think the change you > propose is not for the better. We have similar code elsewhere in > Emacs, and there's nothing wrong with it. OK, thanks for taking a look. I appreciate you taking the time to explain your thinking as well, it is most helpful. I'm closing this bug report.