From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master c12838c73e: * lisp/help-fns.el: Minor fixes Date: Fri, 2 Sep 2022 17:44:30 -0700 Message-ID: References: <166212688020.22107.2630550400639665135@vcs2.savannah.gnu.org> <20220902135440.B28DFC04F05@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34702"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 03 02:46:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUHIl-0008rn-I2 for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 02:46:23 +0200 Original-Received: from localhost ([::1]:48838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUHIj-0006Bk-GF for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Sep 2022 20:46:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUHH2-00050M-4r for emacs-devel@gnu.org; Fri, 02 Sep 2022 20:44:36 -0400 Original-Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:34712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUHH0-0002oa-DH for emacs-devel@gnu.org; Fri, 02 Sep 2022 20:44:35 -0400 Original-Received: by mail-ot1-x32c.google.com with SMTP id q39-20020a056830442700b0063889adc0ddso2565450otv.1 for ; Fri, 02 Sep 2022 17:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date; bh=qJ30bOmzWifnuwoKXhJ/bABlF7twEei8urAXr6vb5O8=; b=nmmripH2M8e9EhzpJoEoPrtOmD50wbDubSSnuWLjP7UECLYsLoy1fgyqSaSIxJMC6e VHPoqRAfxwz4eeeune8IKsM2ZdeGELv1px998HwTdmPfWQmGQL1G9YgVJxcFO+OtFqmj fkOU81kOybwWt0JY/ENvhjaEc3Zzy+N1jod9yvN+BIJF0PauyK91Zyv0mAY21aH+Vrod 3/PsyOdevtuxN4EpkSOFFJtdZi8Ji5YHtY3+FJDAEbZ2wC++YIEMk3pNw4bH/PtkSLBr 2kWiOa+stj6y3ipSajNLQdQjvgUNipPT4Oo+7p4oOCzvvg8LJaqB0WArU3aR37HAk6IC DgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date; bh=qJ30bOmzWifnuwoKXhJ/bABlF7twEei8urAXr6vb5O8=; b=QY58MxU61oD83BCE5X+khTsA8Vix2nhl0LYfURFeKE9PWCan4QLYlyVuc7+ktP0tAk 5jHz38QmgJsYseC4sg/X1rc2Ul0PCnVxr+n/r7qLL1VmkL6GSNsPnWmoCHB3m+nEw+7Z rGMMO6gSeTbxpgoldWI2w3x8QzTfIFsjdGIjQW7Z14E0BmsQgPOOdS5cHls0onl/TPC2 7ICyAqkFJO1b1rsK7xb2Rnd5XHqlrsgdDMyfj2P1o/GY842Q9VHOXKPUPOwL4A7EpgO+ 4hRG5rgRzM91g9EpMvuYHBKzQsmfGhDySP4uWd3gUqTrxq2jGoFRd6k/KfsOCDnzPdKI 8ELQ== X-Gm-Message-State: ACgBeo2UlAi+J9l3fQM0on8jOiDY5Jg6zY/VOogEfiCv13XpRAomwN2u lw9haAy+v4GZBMyl7s1z/5e1mjPHCMl8tNCdop8= X-Google-Smtp-Source: AA6agR4Qwa3oohn89n/tRIJouaoO70D6gtzbqJSmThHlWY95KUrN5HeYAqdKRgWdq0HIysVDwKR8XpmyTC/Ab9TtD1g= X-Received: by 2002:a9d:f05:0:b0:637:1068:1081 with SMTP id 5-20020a9d0f05000000b0063710681081mr14583111ott.224.1662165870725; Fri, 02 Sep 2022 17:44:30 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 2 Sep 2022 17:44:30 -0700 In-Reply-To: <20220902135440.B28DFC04F05@vcs2.savannah.gnu.org> X-Hashcash: 1:20:220903:monnier@iro.umontreal.ca::Vu/oNUof06kuh7ve:7niT Received-SPF: pass client-ip=2607:f8b0:4864:20::32c; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294590 Archived-At: > branch: master > commit c12838c73ef161850a081f9ccea6e375b7c2f93b > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/help-fns.el: Minor fixes > > (describe-mode--minor-modes): Don't burp on minor modes that lack a docstring. > (describe-mode--minor-modes): Simplify eta-redex. > (find-lisp-object-file-name): Use `autoload-file`. > (help-fns--describe-function-or-command-prompt): Allow the user to > insist on choosing a function even if it appears not to exist. This seems to lead to: Test help-fns-test-bug17410 backtrace: autoload-file((autoload "foo" nil nil t)) find-lisp-object-file-name(help-fns-test--macro (autoload "foo" nil help-fns-function-description-header(help-fns-test--macro) describe-function-1(help-fns-test--macro) (let ((standard-output standard-output)) (describe-function-1 func)) (progn (let ((standard-output standard-output)) (describe-function-1 (unwind-protect (progn (let ((standard-output standard-output)) (des (let ((standard-output (generate-new-buffer " *string-output*" t))) (let ((string (let ((standard-output (generate-new-buffer " *string- help-fns-tests--describe-function(help-fns-test--macro) (let ((regexp "autoloaded Lisp macro") (result (help-fns-tests--desc (closure (t) nil (let ((regexp "autoloaded Lisp macro") (result (hel ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name help-fns-test-bug17410 :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [... ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/help-fns-tests.el" " command-line() normal-top-level() Test help-fns-test-bug17410 condition: (void-function autoload-file) FAILED 3/20 help-fns-test-bug17410 (0.000129 sec) at lisp/help-fns-tests.el:44