From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59820: [PATCH] * nadvice/nadvice.el: support non-symbol (closure/lambda) advices (old Emacs) Date: Tue, 10 Oct 2023 10:44:18 +0000 Message-ID: References: <93f01864-6cdf-2d04-d08c-d0b52dc7773f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16213"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59820@debbugs.gnu.org, Daan Ro To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 10 12:45:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqAEd-0003tk-Nk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Oct 2023 12:45:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqAEE-0001j2-Kj; Tue, 10 Oct 2023 06:44:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqAEC-0001iN-Tz for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 06:44:40 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqAEC-0006dv-MB for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 06:44:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqAEX-0007Qw-Pt for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 06:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2023 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59820 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59820-submit@debbugs.gnu.org id=B59820.169693469228541 (code B ref 59820); Tue, 10 Oct 2023 10:45:01 +0000 Original-Received: (at 59820) by debbugs.gnu.org; 10 Oct 2023 10:44:52 +0000 Original-Received: from localhost ([127.0.0.1]:34079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqAEO-0007QH-42 for submit@debbugs.gnu.org; Tue, 10 Oct 2023 06:44:52 -0400 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:58570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqAEI-0007Pj-G3 for 59820@debbugs.gnu.org; Tue, 10 Oct 2023 06:44:49 -0400 Original-Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c1886777d9so65692031fa.0 for <59820@debbugs.gnu.org>; Tue, 10 Oct 2023 03:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696934659; x=1697539459; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=iJ+mH/Urfmo7hnbLq8edfKu87QEzKh9CfC5wVFRqGd0=; b=Mo3tUWtBLupiRQwmrBN/RoQBXRKmmzlSRipVVLHF0eqtsEeY/KzVLEiHFepG3N31jM dfns/X/a1dMsnyP5uVgsy/tpY+3e9TpGFGDbVOrKx99KvhNmZ4t18RPhuZhgOn1kxKro CKMe2GzLSH7UGcI8/czjDlk5GHDTAMN8IxxwCHj1ZCtKVauEQp6Zg98lNF3MjSvMK9uZ 7dbMtWAWEiqCUManXqZyJU0KUmrg0/u8CJXtXyapdy5O5xYNYYXeM3EMcvGBFbyoeTBB D9EhMuxJTZaX5K7g6n1wum1RyLwBZvqBt4S8xBewN2xeG/blKX37JGSJtE2WkxwCpg1C l/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696934659; x=1697539459; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iJ+mH/Urfmo7hnbLq8edfKu87QEzKh9CfC5wVFRqGd0=; b=q0emygIXMJX4p3vaVCF8tzVVN9aWgH9SbwXAawml/VBcEkQfHBsODik94aj+yfSu+g KjVg24lZ8Wnu/kuc/cIlk8TXzk6etO4vNrfsfGIA7e1MQLKdqvjxzroXi7hgzVdhDuEw 5DCRRPB68PqK3+ykvDbj3v7/5gTBTUoMDLgQWfdx5DCBuTkNR9p6WrLht9bxzG7zAvvu kWiELhPHxNRiKR23MXQUfFupejX+jrBIRycPeBIxcfXx+NwcEHAvYwZOuk/eNC33COzc cAkXvBNGtLW7TiQSvqwvN59643Jx0cY/TUhLYjEWd0GkJmZYz+lKQQanttekNEOvLfQA JnHg== X-Gm-Message-State: AOJu0Yzbi85xmlJ9f598eL2uKf9rLcPndkA/DVYMf0/M9PuUcX6ko8iU 4+rKJAm3qehjpsntB91VP8MFW4TvmfDYZ/w1Qz4= X-Google-Smtp-Source: AGHT+IGYGs7JY6eXC96FLCY2/9ehnZITZg6XYoaAJ+iIc0IJku0qvmiDfTcxHYGz/Xs5usVJKL8gfU5bClWHEfVYX/Q= X-Received: by 2002:a2e:7d08:0:b0:2bb:bfa5:b72c with SMTP id y8-20020a2e7d08000000b002bbbfa5b72cmr14001936ljc.15.1696934658896; Tue, 10 Oct 2023 03:44:18 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 10 Oct 2023 10:44:18 +0000 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272190 Archived-At: tags 59820 + moreinfo thanks Stefan Monnier writes: >>> Use `warn` instead of `message`. >> Stefan, what do you think? Should the below patch be installed? > > Still not a fan for the same reasons, plus: > > - The real `nadvice.el` was added to Emacs-24.4, released 9 years ago, > and this forward compatibility was first released 5 years ago, so the > need for the library is becoming rare and its functionality proved > adequate for 5 years already. > - (intern (format "%S" func)) can collide with another library > doing something similar, so better use something like > (intern (format "nadvice--%S" func)) just to be on the safe side. > > Daan, is there a specific use-case that motivates you to want to pass an > anonymous lambda to this compatibility library? > > Maybe I could be convinced by a good use-case. Makes sense. I've tagged the bug as moreinfo for now, but barring a compelling use case I'm also leaning towards closing this as wontfix.