From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#28385: ert "should" macros to not be globally visible Date: Mon, 10 Aug 2020 09:58:50 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20877"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 28385@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 19:01:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5BB3-0005Kp-Gs for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 19:01:37 +0200 Original-Received: from localhost ([::1]:48134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5BB2-00016W-Hn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 13:01:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5B9W-0008DS-Vq for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 13:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5B9W-0001OI-FM for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 13:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5B9W-0004bk-Bk for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28385 X-GNU-PR-Package: emacs Original-Received: via spool by 28385-submit@debbugs.gnu.org id=B28385.159707874417612 (code B ref 28385); Mon, 10 Aug 2020 17:00:02 +0000 Original-Received: (at 28385) by debbugs.gnu.org; 10 Aug 2020 16:59:04 +0000 Original-Received: from localhost ([127.0.0.1]:37393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5B8U-0004Za-5F for submit@debbugs.gnu.org; Mon, 10 Aug 2020 12:59:04 -0400 Original-Received: from mail-yb1-f178.google.com ([209.85.219.178]:35455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5B8S-0004ZD-Af for 28385@debbugs.gnu.org; Mon, 10 Aug 2020 12:58:57 -0400 Original-Received: by mail-yb1-f178.google.com with SMTP id y134so5520893yby.2 for <28385@debbugs.gnu.org>; Mon, 10 Aug 2020 09:58:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=XybGjlfROM/aN0hI6ckbswEtADNptPZ8E5WPJnSUFok=; b=O1ApTZf+4kYaq1sIQl8cjQDIUYRp2U38jhrM9mamIFQnnKGiwwWZstvApNjOtL8mch B8EogOXblOeybE2MEkZS1jfy/naYrGNDwUmNK6Sr4T1uzunSndYILyMbu2xvx9qe5S29 3wecB82JLo35hrw36m4LqqcopCXsVlAXTFb9mi2dO2YZEF7TOTHVmcGbXv0DmfzSO0KR LwVEa3A7PGauNptDa1SlwXzv/yKgQ6BWPPBXPjhyifLRoDIg/JkE6xyFSGLFTw/5s3sr EkvK0TULwh5s4jIQzSzi6MBn7W6433pmw634ffbC4PVH3m11mi4mtc3JxG9fZbiGq8tR RUcw== X-Gm-Message-State: AOAM531mDA/gq9QjmE4S8yPUCHjJFbh/dL5uztFCc4ViTp9ISy2LAr4o IsVt4+ldCviS6DCVjQLlrWJyBbm3xn2Ie2sHxAA= X-Google-Smtp-Source: ABdhPJy17//Ep/Q9SwMkDcbuheFgU77VQl+xJ8QzooO4iOgz+8CpHFvExaZgzBSbsvgw/yC8luIRe8P+IFpewRdDbIA= X-Received: by 2002:a25:b88b:: with SMTP id w11mr43373248ybj.129.1597078730735; Mon, 10 Aug 2020 09:58:50 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 10 Aug 2020 09:58:50 -0700 In-Reply-To: (Stefan Kangas's message of "Sun, 29 Sep 2019 03:26:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184562 Archived-At: tags 28385 + wontfix notabug close 28385 thanks Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> Glenn Morris writes: >> >>> Now "should", "should-not", and "should-error" are globally defined as >>> macros (with no "ert-" prefix). They are only useful inside ert-deftests. >>> Perhaps they should steal a trick from the similar "skip-unless", which >>> is not globally visible. The global definition is "ert--skip-unless", >>> and the ert-deftest macro basically makes "skip-unless" an alias for >>> this inside the body of a test. This seems cleaner. >> >> When writing tests, I find it convenient that I can `C-x C-e' >> >> (should ...) >> >> terms. I mean, I could just `C-x C-e' the insides of the form instead, >> but still... > > I agree; I do this all the time when developing tests. C-x C-e inside > the form doesn't help much e.g. when you have a let form doing some > setup that contains multiple should statements. (See > test/lisp/bookmark-tests.el for an example.) > > With all due respect to Glenn, I would suggest to close this as wontfix. No further comments within 45 weeks, so I'm closing this now. Feel free to reopen if you disagree and we can discuss it. Best regards, Stefan Kangas