From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#75065: Upon archive download failure print the original error Date: Thu, 26 Dec 2024 20:32:08 +0000 Message-ID: References: <4361fa59c17dc06b285fea25f025a9e86f81d1fe.camel@yandex.ru> <867c7mzuva.fsf@gnu.org> <87bjwytis3.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16729"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75065@debbugs.gnu.org, Eli Zaretskii To: Konstantin Kharlamov , Stefan Monnier , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 26 21:34:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQuYt-0004DS-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Dec 2024 21:34:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQuYY-0005Kf-4n; Thu, 26 Dec 2024 15:34:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQuYV-0005KP-N2 for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 15:34:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQuYV-0005wG-EU for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 15:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=HQAbkFArTREtNUGvcc2R62zPc/whgEFsO+tTa3gS7KQ=; b=qA8rSYRGHIOjoeKujtMr2Sq/Lz33nmRvGMZQoW+vp87BVk5SeROEgM+74A37g7LqtmclYDSao1i4nE7AyB4LZfYgihOB5gQjlPr21OZTo9oGSFg2EY8tDSNbzSo0F+tQLQ73NWWg/NosHVxzgGQFxH0GeaYYPy/zin6iOmjBf9n/JjmA8Tj1MxV32AB/gxq9YI8v2YE9u7FdPJMmHiPnPXIaxv9EFt/aIzPBAwNfFYjSF3nwEExNXg7iDD3AqPe+0sMIao5CyypT+wbz4MA895BMyrnLYBSGO9krAyX7reZRSd/BbXt+mAC0Qdy0pEv5UDsR3xzx6oVtFc7XocfqMA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQuYU-0000Gt-CQ for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2024 15:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2024 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75065 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75065-submit@debbugs.gnu.org id=B75065.1735245192961 (code B ref 75065); Thu, 26 Dec 2024 20:34:02 +0000 Original-Received: (at 75065) by debbugs.gnu.org; 26 Dec 2024 20:33:12 +0000 Original-Received: from localhost ([127.0.0.1]:42358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQuXg-0000FQ-6Y for submit@debbugs.gnu.org; Thu, 26 Dec 2024 15:33:12 -0500 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:46532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQuXd-0000FG-O1 for 75065@debbugs.gnu.org; Thu, 26 Dec 2024 15:33:10 -0500 Original-Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d0ac27b412so8774489a12.1 for <75065@debbugs.gnu.org>; Thu, 26 Dec 2024 12:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735245129; x=1735849929; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=HQAbkFArTREtNUGvcc2R62zPc/whgEFsO+tTa3gS7KQ=; b=SguJ1qWgNONnxkS8u/Cu5BfjdVQ2/PILSSIHzB5hTcUjI6ezs9AZeKxTag8uVnBJIV vh+ETGmE83G6ndjiFX7VkmESJFkeheNjf3u3ujYlrLgsc0l1RpTLL4YJELRi4kULjUzq NiwzhT5rMeoJVqH/Y5606mZ1CYcT5vrNaLg8ijj0bOoXRVFrPQMD7KaudaPPDGwa2Wpx ZeWHyjyZEZ0tPf4r9jAimprBVSi7g4mvsQSAZTsCrgFmu5IS2KMa6CmyDwjSk8Ov7h9o tZiJI+W9laFNVuCDKY2heVxK+oE9e1XrjKVEInqxk+XAjJZzbpfgS4sRMQOwPDlROCn5 WJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735245129; x=1735849929; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HQAbkFArTREtNUGvcc2R62zPc/whgEFsO+tTa3gS7KQ=; b=wsWfHSFMdUItqV9vmZNo4ol8YgKs6XCNEubPlLHVE734Qd2D+BPNlFvV82NvE0j+LH Z7Xen8fseU332ZQzWVvMLR/H3HNLnuRRFpEFe9Uj9SuibvcrF+edMK1gK6fAj8yBqG1I aKRMk5qpWwZSLy5fbG/G7ahDxeo4ZQrM2hxI6+qVOHS5r/bS9kak+Lb/MNnD2vD5o1Cf YM3XXrq0NxazrthrxKQNNTKg/aQAAufmgZxsW1SwUKXrzNYqvfgCvnXIMlu0ZdXAjxqE NTEckMexjvWJpl9v/Cu7zN5OTklN7j8Zl3nwsKKVwj2Maaem56LGm7E+lwdB4Z4YYtS1 4KZw== X-Gm-Message-State: AOJu0YwjoDaPHfcYwVvwxBEullAX5AaC1x0c/SyDJVYs/6IHdEcHQ0p/ VpQNYdmJOuHR2yE+uaXTviT0QGf32rkPA0VMbytI+Ihiu+F8Ytj4BV5qlEXJZzDPvqZ+beIbFKB +tgl+bWNTGk7B1XCwOy+1rTC7iZ0= X-Gm-Gg: ASbGnctf2W624t08vu9Odzjd2Mjy+LcmfYqKmwA8KJiG9W7lP7SgTuAJyOqvmUP4rP5 xqAKbPF5IKJGJ75vDnKnx7hXRXmcRQCiWbG5bnUM= X-Google-Smtp-Source: AGHT+IF7hnlhcd55frZZTNdfDq429Y5f3nkDU8sQZOEOJmDdsYw7zyX3tWpioy3/B9kXmEaPAng6ShECdZ/kAAXCtj0= X-Received: by 2002:a05:6402:3495:b0:5d0:f830:ef5b with SMTP id 4fb4d7f45d1cf-5d81de17f35mr18830598a12.29.1735245128732; Thu, 26 Dec 2024 12:32:08 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 26 Dec 2024 20:32:08 +0000 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297785 Archived-At: Konstantin Kharlamov writes: > On Thu, 2024-12-26 at 14:17 -0500, Stefan Monnier wrote: >> > > > =C2=A0=C2=A0 (dolist (archive package-archives) >> > > > -=C2=A0=C2=A0=C2=A0 (condition-case-unless-debug nil >> > > > +=C2=A0=C2=A0=C2=A0 (condition-case-unless-debug err >> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (package--downloa= d-one-archive archive "archive- >> > > > contents" async) >> > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (error (message "Failed to downloa= d `%s' archive." >> > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (car archive)))))) >> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (error (message "Failed to downloa= d `%s' archive. Error: >> > > > %S" >> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (car archive) (cdr err)))))) >> > > > >> > > Stefan and Philip, is this okay to install? >> >> I agree with the idea behind the patch, but printing just `(cdr err)` >> doesn't seem right, it should print the whole of `err`. > > The `car` seems to just contain word error. Here's how both compare: > > =E2=80=A2 current patch with `(cdr err)`: > Failed to download =E2=80=98melpa=E2=80=99 archive. Error: ("Location= melpa.org/packages/ is not a url nor an absolute file name") > > =E2=80=A2 suggested change with `err`: > Failed to download =E2=80=98melpa=E2=80=99 archive. Error: (error "Lo= cation melpa.org/packages/ is not a url nor an absolute file name") The "Error:" part is redundant, so I think it could be shortened to something like: Failed to download =E2=80=98melpa=E2=80=99 archive: Location melpa.org/= packages/ is not a url nor an absolute file name