all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Wilhelm Kirschbaum <wkirschbaum@gmail.com>, 75192@debbugs.gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>
Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Thu, 2 Jan 2025 01:45:22 -0600	[thread overview]
Message-ID: <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@mail.gmail.com> (raw)
In-Reply-To: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@mail.gmail.com>

Wilhelm Kirschbaum <wkirschbaum@gmail.com> writes:

> This updates heex-ts-mode to use font-lock-string-face to be consistent
> with html-ts-mode on attribute values.

Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?

> From 51dcd9cea634233439db59c977928f8d7a36edff Mon Sep 17 00:00:00 2001
> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Date: Mon, 30 Dec 2024 12:56:40 +0200
> Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
>
> Attribute values are strings as with html-ts-mode.
>
> * lisp/progmodes/heex-ts-mode.el (heex-ts--font-lock-settings):
> Change to attribute value to @font-lock-string-face.
> ---
>  lisp/progmodes/heex-ts-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/heex-ts-mode.el b/lisp/progmodes/heex-ts-mode.el
> index 797bfd6c8ff..4be987f9d81 100644
> --- a/lisp/progmodes/heex-ts-mode.el
> +++ b/lisp/progmodes/heex-ts-mode.el
> @@ -113,7 +113,7 @@ heex-ts--font-lock-settings
>       `((special_attribute_name) @font-lock-keyword-face)
>       :language 'heex
>       :feature 'heex-string
> -     `([(attribute_value) (quoted_attribute_value)] @font-lock-constant-face)
> +     `([(attribute_value) (quoted_attribute_value)] @font-lock-string-face)
>       :language 'heex
>       :feature 'heex-component
>       `([
> --
> 2.45.2





  reply	other threads:[~2025-01-02  7:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-30 10:59 bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Wilhelm Kirschbaum
2025-01-02  7:45 ` Stefan Kangas [this message]
2025-01-02  8:36   ` Eli Zaretskii
2025-01-02  8:41     ` Stefan Kangas
2025-01-02  8:56       ` Wilhelm Kirschbaum
2025-01-02  9:06       ` Eli Zaretskii
2025-01-02 10:13         ` Wilhelm Kirschbaum
2025-01-02 15:24           ` Eli Zaretskii
2025-01-03  5:49             ` Yuan Fu
2025-01-03 15:14               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=75192@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=wkirschbaum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.