From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41130: bug#41198: 27.0.60; [PATCH] heading cycling command for outline Date: Tue, 19 May 2020 15:36:01 -0700 Message-ID: References: <452A6049-893A-4E7E-8349-541D276FAD19@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41130@debbugs.gnu.org, 41198@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 00:37:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbArH-0009An-7r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 00:37:11 +0200 Original-Received: from localhost ([::1]:34856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbArG-00025s-7a for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 18:37:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbAr8-00024J-Lx for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbAr8-0003sR-Cv for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbAr8-0004AG-4B for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 May 2020 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41130-submit@debbugs.gnu.org id=B41130.158992777015945 (code B ref 41130); Tue, 19 May 2020 22:37:02 +0000 Original-Received: (at 41130) by debbugs.gnu.org; 19 May 2020 22:36:10 +0000 Original-Received: from localhost ([127.0.0.1]:51378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbAqH-000492-Rp for submit@debbugs.gnu.org; Tue, 19 May 2020 18:36:10 -0400 Original-Received: from mail-qk1-f177.google.com ([209.85.222.177]:38189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbAqF-00048k-V6; Tue, 19 May 2020 18:36:08 -0400 Original-Received: by mail-qk1-f177.google.com with SMTP id f189so1667879qkd.5; Tue, 19 May 2020 15:36:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=UpNnLmgn8vD7zUpU0fvb+3rpeFGNHmJoVsRF7gk4uZQ=; b=C1/Cx8TzFjoiPpcOcNVKkfCt41OvIyLt5vEIolw5WSfYtaSA/E9DbxZBqi04rgvgK1 J5zTqycC2hz1kBGrWYDYrm2rxDxCfuYhUFWuwCmxXZC4ewumTbczj9lLBQvd/VfeMavZ bqMOtgPMFWXOOUmwERXgIvsdvD+uawSDF3f6de6vZgUXGc/cFApBbUCNtnz9qKAB3FnX sqGegHMKVRO43kPsox2b/MGLnwEEE7JZBURkUR6q1bG8BoOJnanQZMy4BEuYgq9pbEbT bRyiMI8qK1jUC3CDaKJDac375ii80rcaBSs1RYQK+DuglWHW72KOc//G85XS6ZzbhN2V 6sow== X-Gm-Message-State: AOAM532Pev4aCo9nb7IlQBQkShY8Qw1YgT5kKM7YyerFFSRwPRyKI11l GbtWZ7VXJMHfgxbSpla/JJ8tdc4y6o2+Y2cqGDI= X-Google-Smtp-Source: ABdhPJxp+ymVu1l7rTF0w2AmHPOM3enjv+WWAnnv3mAlJ4J0cwu6MlVci5xNcv/dQgc+9vblM/X6xGvqqYn0inDWH1g= X-Received: by 2002:a25:9304:: with SMTP id f4mr2634766ybo.309.1589927762319; Tue, 19 May 2020 15:36:02 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 May 2020 15:36:01 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180625 Archived-At: Yuan Fu writes: >> In Bug#41130, I also suggest to add the same keybinding as in org-mode: >> TAB and S-TAB. Could you add such keybindings to outline-mode-map in >> your patch? > > It seems that the outline-mode bindings all live under C-c. Maybe C-c > TAB and C-c S-TAB? Should I ask on emacs-devel for for suggestions? I think it is better to use the same keys as org-mode, since one important motivation for this feature is precisely to align the outline-mode keybindings with org-mode. This aspect would be significantly diminished by using other keys, IMHO. My impression was that also there was consensus around (or at least no objections to) that idea the last time we discussed it. I would therefore propose to just add TAB and S-TAB to the patch, but allow a week or two before pushing to give others a chance to comment here. But, if you really want to, of course you could also ask on emacs-devel. Worst case, we get to have another round of bikeshedding. ;-) >> I think we also need ChangeLog in the commit message, an entry in NEWS, >> and updates to the manual. > > I updated NEWS and the manual. For ChangeLog, I thought that=E2=80=99s > automatically generated from commit messages? That is my understanding too. But I only saw a diff attached, not a patch with a commit message. That is what I tried to say, but I could've been more clear. (CONTRIBUTE suggests using `git format-patch -1' to email a patch, which includes the commit message.) > +@findex outline-cycle > +@findex outline-cycle-buffer > + Outline also provides two convenience commands to cycle the > +visibility of each heading and the whole buffer. @code{outline-cycle} > +cycles the current heading between "hide all", "subheadings", and > +"show all" state. @code{outline-cycle-buffer} cycles the whole buffer > +between "only top-level headings", "all headings and subheadings", and > +"show all" states. [...] > +*** New commands to cycle heading visibility. > +'outline-cycle' cycles the current heading between "hide all", > +"subheadings", and "show all" state. 'outline-cycle-buffer' cycles the > +whole buffer between "only top-level headings", "all headings and > +subheadings", and "show all" states. Looks good to me (but should refer to the above keybindings if they're added). Best regards, Stefan Kangas