bug#63531: [PATCH] View DICOM and Sixel images using image-convert

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

These patches add .dcm and .six to auto-mode-alist, so they can be
viewed with image-convert. The Six patch also adds SIX as an ImageMagick
type.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-viewing-.six-images-via-image-convert.patch --]
[-- Type: text/x-patch, Size: 1532 bytes --]

From d03709e75696c7d081012eade721d80f5b725b42 Mon Sep 17 00:00:00 2001
From: Antero Mejr <antero@mailbox.org>
Date: Mon, 15 May 2023 21:21:12 +0000
Subject: [PATCH 1/2] Allow viewing .six images via image-convert.

* lisp/files.el (auto-mode-alist): Support the Sixel .six image
format.
* lisp/image.el (imagemagick-enabled-types): Add SIX.
---
 lisp/files.el | 1 +
 lisp/image.el | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/files.el b/lisp/files.el
index 148f47cbc97..ba338e01c6b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3082,6 +3082,7 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|CBR\\|7Z\\|SQUASHFS\\)\\'" .
      ("\\.pict\\'" . image-mode)
      ("\\.rgb\\'" . image-mode)
      ("\\.rgba\\'" . image-mode)
+     ("\\.six\\'" . image-mode)
      ("\\.tga\\'" . image-mode)
      ("\\.wbmp\\'" . image-mode)
      ("\\.webp\\'" . image-mode)
diff --git a/lisp/image.el b/lisp/image.el
index 08190cf86bc..72811b2b197 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -1127,7 +1127,7 @@ has no effect."
     KDC MIFF MNG MRW MSL MSVG MTV NEF ORF OTB PBM PCD PCDS PCL
     PCT PCX PDB PEF PGM PICT PIX PJPEG PNG PNG24 PNG32 PNG8 PNM
     PPM PSD PTIF PWP RAF RAS RBG RGB RGBA RGBO RLA RLE SCR SCT
-    SFW SGI SR2 SRF SUN SVG SVGZ TGA TIFF TIFF64 TILE TIM TTF
+    SFW SGI SIX SR2 SRF SUN SVG SVGZ TGA TIFF TIFF64 TILE TIM TTF
     UYVY VDA VICAR VID VIFF VST WBMP WPG X3F XBM XC XCF XPM XV
     XWD YCbCr YCbCrA YUV)
   "List of ImageMagick types to treat as images.
-- 
2.39.2


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-Allow-viewing-.dcm-images-via-image-convert.patch --]
[-- Type: text/x-patch, Size: 815 bytes --]

From aaeac0b37bd35792dc55fbccc9d5c53e606ac3f1 Mon Sep 17 00:00:00 2001
From: Antero Mejr <antero@mailbox.org>
Date: Mon, 15 May 2023 23:15:33 +0000
Subject: [PATCH 2/2] Allow viewing .dcm images via image-convert.

* lisp/files.el (auto-mode-alist): Support the DICOM .dcm image
format.
---
 lisp/files.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/files.el b/lisp/files.el
index ba338e01c6b..2e42d0e74d1 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3053,6 +3053,7 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|CBR\\|7Z\\|SQUASHFS\\)\\'" .
      ("\\.cmyk\\'" . image-mode)
      ("\\.cmyka\\'" . image-mode)
      ("\\.crw\\'" . image-mode)
+     ("\\.dcm\\'" . image-mode)
      ("\\.dcr\\'" . image-mode)
      ("\\.dcx\\'" . image-mode)
      ("\\.dng\\'" . image-mode)
-- 
2.39.2

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Eli Zaretskii]

> Date: Mon, 15 May 2023 23:30:13 +0000
> From:  Antero Mejr via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> These patches add .dcm and .six to auto-mode-alist, so they can be
> viewed with image-convert. The Six patch also adds SIX as an ImageMagick
> type.

Do we want to include their support in Emacs?  AFAIU, these aren't
free formats.  And since supporting them boils down to customizing
auto-mode-alist, why cannot users do that themselves?

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Antero Mejr <antero@mailbox.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Date: Mon, 15 May 2023 23:30:13 +0000
>>> From:  Antero Mejr via "Bug reports for GNU Emacs,
>>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>> 
>>> These patches add .dcm and .six to auto-mode-alist, so they can be
>>> viewed with image-convert. The Six patch also adds SIX as an ImageMagick
>>> type.
>>
>> Do we want to include their support in Emacs?  AFAIU, these aren't
>> free formats.
>
> I'm not an lawyer but to the best of my knowledge neither format has any
> sort of licensing, trademark, or patent encumberances.
>
> DICOM is free to implement and view without licenses. The specification
> is available online but the spec itself is copyright of NEMA. It's a
> metadata wrapper over JPEG mainly.
>
> I think the Sixel "format" is more of a simple convention than a formal
> specification with licenses, patents, etc. Implementations use the DEC
> VT330 manual as a "spec" I guess.
>
>> And since supporting them boils down to customizing
>> auto-mode-alist, why cannot users do that themselves?
>
> For usability I think it's good for things to (mostly) work out of the
> box.

Forgot to CC the mailing list, sorry.

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Stefan Kangas]

Antero Mejr via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:

>>> These patches add .dcm and .six to auto-mode-alist, so they can be
>>> viewed with image-convert. The Six patch also adds SIX as an ImageMagick
>>> type.
>>
>> Do we want to include their support in Emacs?  AFAIU, these aren't
>> free formats.
>
> I'm not an lawyer but to the best of my knowledge neither format has any
> sort of licensing, trademark, or patent encumberances.
>
> DICOM is free to implement and view without licenses. The specification
> is available online but the spec itself is copyright of NEMA. It's a
> metadata wrapper over JPEG mainly.
>
> I think the Sixel "format" is more of a simple convention than a formal
> specification with licenses, patents, etc. Implementations use the DEC
> VT330 manual as a "spec" I guess.
>
>> And since supporting them boils down to customizing
>> auto-mode-alist, why cannot users do that themselves?
>
> For usability I think it's good for things to (mostly) work out of the
> box.

Since these formats are not encumbered by patents and so on, I don't see
any reason why we can't support them.  It's always nice if stuff like
that works OOTB.

So I think we should install these patches.

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> Since these formats are not encumbered by patents and so on, I don't see
> any reason why we can't support them.  It's always nice if stuff like
> that works OOTB.
>
> So I think we should install these patches.

I agree, both are popular formats so it would be good to support them.
I did another check regarding the licenses, hopefully it will address
the previous concerns.

The DICOM standard committee website explicitly states:
"No license is required to download or implement the DICOM Standard."
https://www.dicomstandard.org/patent

For Sixel, we already use the DEC VTxxx manuals for terminal emulation,
see the "References" comment on line 2975 of term.el. The Sixel file
format reference comes from the same sources.

Thanks,
Antero

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Antero Mejr <antero@mailbox.org> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Since these formats are not encumbered by patents and so on, I don't see
>> any reason why we can't support them.  It's always nice if stuff like
>> that works OOTB.
>>
>> So I think we should install these patches.
>
> I agree, both are popular formats so it would be good to support them.
> I did another check regarding the licenses, hopefully it will address
> the previous concerns.
>
> The DICOM standard committee website explicitly states:
> "No license is required to download or implement the DICOM Standard."
> https://www.dicomstandard.org/patent
>
> For Sixel, we already use the DEC VTxxx manuals for terminal emulation,
> see the "References" comment on line 2975 of term.el. The Sixel file
> format reference comes from the same sources.

I implemented the small dicom package which is available from GNU ELPA.
It can display DICOM images, leveraging the programs convert from
ImageMagick and dcm2xml from the dcmtk DICOM toolkit.

Daniel

bug#63531: [PATCH] View DICOM and Sixel images using image-convert

[Stefan Kangas]

Version: 31.1

Antero Mejr <antero@mailbox.org> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Since these formats are not encumbered by patents and so on, I don't see
>> any reason why we can't support them.  It's always nice if stuff like
>> that works OOTB.
>>
>> So I think we should install these patches.
>
> I agree, both are popular formats so it would be good to support them.
> I did another check regarding the licenses, hopefully it will address
> the previous concerns.
>
> The DICOM standard committee website explicitly states:
> "No license is required to download or implement the DICOM Standard."
> https://www.dicomstandard.org/patent
>
> For Sixel, we already use the DEC VTxxx manuals for terminal emulation,
> see the "References" comment on line 2975 of term.el. The Sixel file
> format reference comes from the same sources.

Now installed on master.  Thanks!