From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Don't override 'comint-prompt-read-only' by default Date: Sat, 14 Sep 2024 16:13:12 -0700 Message-ID: References: <87a5gb4fti.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38597"; mail-complaints-to="usenet@ciao.gmane.io" To: Philip Kaludercic , Emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 15 01:14:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spbxv-0009vo-7J for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Sep 2024 01:14:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spbx8-000291-3z; Sat, 14 Sep 2024 19:13:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spbx6-00028o-R4 for Emacs-devel@gnu.org; Sat, 14 Sep 2024 19:13:16 -0400 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spbx5-0001gD-1S for Emacs-devel@gnu.org; Sat, 14 Sep 2024 19:13:16 -0400 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5c255e3c327so4032076a12.1 for ; Sat, 14 Sep 2024 16:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726355593; x=1726960393; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=g0i58Ko/IIPAybyJBVsakkxSwTJueJBxOn4KNjd8NV4=; b=dZFJO/ZSZWYAn1qIz9+6bOc6YPVfSO+X96S5QHsuj3CCmts7tBfXbS2orvuoqM/uck +0ReRKBwPnBfmX2T25AhSTUQ010sEQ2543diuFHFEWEvkDClWPuY/nYLkVY4py9eYp2C OupB0aKDBH5HhUgLUkgXjwzbQlT8DBgCSE05NnOpmyQrVGDjIHC+dZzg2qEPPt2MoE0j KLGFpF8iPkzZBUXAnv/dRqiPryGpSWqiSkiXbY/fX0YZF7ru2iqW/W3UL21t3skrhGLE BfOdaa6SsR4iIPCZSerCCsAb8JZ7KprNBaRXKk7NsQd+B6gCE2Jm+j7gW3CKF8oCt1Cn tEpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726355593; x=1726960393; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g0i58Ko/IIPAybyJBVsakkxSwTJueJBxOn4KNjd8NV4=; b=S8c3O572d0Gfg1v0gu9QfmqLy3pGxEJw6qvn+ogVUD/cEH5TklHACrgWDP8uvFKZJK AMyt2BykoQIp9rbI4BtUOviANVj5CuobP6jLo43S2RzaKLlr0ZTZCXc97JqWzHsJREge pKv2FdvmP4U/JO49UeW7kVcUqrY3JAuW7hG+TKRLNtz/gtqY0YJw5Y16N0bn5JpFSyaR /QoKStDAollgSIJdmbYEuGzlBBwssGq3cJP90bw1bPN2zQvNjijlM3ok6yGgwHp4I4Uu MOfaxRPU9jvi9y40m6YOaObe1+GMvNPZJ4ZHdw6UcksD6VMANjSbJTG2RzHXgn30MF22 Mo0g== X-Forwarded-Encrypted: i=1; AJvYcCUHVcRBuBYWdivPcv6CUa9QVn2e+a8ruOUbG+NeuoshB+avoiTiHBf1bFR9sZAd7yntzf4O5G6w7cINQg==@gnu.org X-Gm-Message-State: AOJu0YzSyPiFWz3rF5jq8W7yKltaKAbEolgDLadhaCzkk2f3fYbjmpNS cMho6N7OuZO1QKpUPeO9pIOxtk52D/rh77FsHtqRQFLuqqrioX4M0J/mrCNCmhtbV6FlFbubUbb ZZfuSnCFIRLVKRyyv6AHTvYN9jMb3zi21 X-Google-Smtp-Source: AGHT+IHeLGaFFj5QnEv1P1cTL4HVrDlZE0MezBGIh/kV8jVFl+CPdiWJxwBCD/gJtyvmBhnBXDGUPaO8nJ+SGhZKeSY= X-Received: by 2002:a05:6402:3548:b0:5c2:5f1d:e1a2 with SMTP id 4fb4d7f45d1cf-5c413e07f9bmr9608172a12.4.1726355592804; Sat, 14 Sep 2024 16:13:12 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 14 Sep 2024 16:13:12 -0700 In-Reply-To: <87a5gb4fti.fsf@posteo.net> Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323624 Archived-At: Philip Kaludercic writes: > I am proposing this change here, because I am aware it might be > controversial. My motivation is to have more consistent inferior modes, > and not have to be surprised that (as in my case right now, > inferior-python-mode doesn't allow be to kill a prompt). I haven't > written a NEWS entry yet, but it should probably mention that anyone > interested in restoring the old behaviour should just set > 'comint-prompt-read-only' directly. > > WDYT? Making `comint-prompt-read-only` nil in more modes seems like a step backwards to me though; if anything I'd like to make it t in more places. I'm actually not sure why it does not already default to t. That's certainly the default in any REPL that I can think of, so our default breaks most user expectations. See, for example, users asking questions on StackOverflow like "How to prevent backspace from deleting my shell prompt": https://emacs.stackexchange.com/questions/21751/how-to-prevent-backspace-from-deleting-my-shell-prompt It makes sense to have the option to be able delete the prompt, though my preferred UI for that is closer to something like hitting `C-w` twice (the second time to confirm) rather than setting a variable. I just feel like this is highly situation dependent: most of the time I do not want backspace to delete the prompt, but maybe occasionally I do. That said, if we can agree to flip `comint-prompt-read-only` to t, I think your patch should definitely be installed. My $.02.