From: Stefan Kangas <stefan@marxist.se>
To: Stephen Gildea <stepheng+savannah@gildea.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 0e56883: Move undocumented time-stamp formats closer to format-time-string
Date: Wed, 9 Oct 2019 15:00:40 +0200 [thread overview]
Message-ID: <CADwFkmmzuT8uspM_Ho0pFUuTp48sHwP--R1HZSYxB7YRw98XgA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmwkQqD7J764dpkcT3EKdQFw-KkzPW4iotV5nfZP=JgYg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
> 1 unexpected results:
> FAILED time-stamp-test-time-zone
The attached patch seems to fix it, but I don't know enough about this
stuff to know if it's the right one. What do you think?
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Fix-one-time-stamp.el-test-on-macOS.patch --]
[-- Type: application/octet-stream, Size: 1341 bytes --]
From 7cfd3045814753c23d0fff512523ba5de43b18f9 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 9 Oct 2019 14:59:53 +0200
Subject: [PATCH] Fix one time-stamp.el test on macOS
* test/lisp/time-stamp-tests.el (time-stamp-test-time-zone): Fix test
on macOS.
---
test/lisp/time-stamp-tests.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/lisp/time-stamp-tests.el b/test/lisp/time-stamp-tests.el
index d710564c36..d1ebaf8cfb 100644
--- a/test/lisp/time-stamp-tests.el
+++ b/test/lisp/time-stamp-tests.el
@@ -283,11 +283,11 @@ time-stamp-test-time-zone
"Test time-stamp formats for time zone."
(with-time-stamp-test-env
;; implemented and documented since 1995
- (should (equal (time-stamp-string "%Z" ref-time) "GMT"))
+ (should (member (time-stamp-string "%Z" ref-time) '("GMT" "UTC")))
;; documented 1995-2019
- (should (equal (time-stamp-string "%z" ref-time) "gmt"))
+ (should (member (time-stamp-string "%z" ref-time) '("gmt" "utc")))
;; implemented since 1997, documented since 2019
- (should (equal (time-stamp-string "%#Z" ref-time) "gmt"))))
+ (should (member (time-stamp-string "%#Z" ref-time) '("gmt" "utc")))))
(ert-deftest time-stamp-test-non-date-conversions ()
"Test time-stamp formats for non-date items."
--
2.23.0
next prev parent reply other threads:[~2019-10-09 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191001032457.2675.32057@vcs0.savannah.gnu.org>
[not found] ` <20191001032458.E3A4D207F5@vcs0.savannah.gnu.org>
2019-10-09 12:51 ` [Emacs-diffs] master 0e56883: Move undocumented time-stamp formats closer to format-time-string Stefan Kangas
2019-10-09 13:00 ` Stefan Kangas [this message]
2019-10-09 18:52 ` Eli Zaretskii
2019-10-10 7:17 ` Paul Eggert
2019-10-10 10:56 ` Stefan Kangas
2019-10-09 21:31 ` Stephen Gildea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmzuT8uspM_Ho0pFUuTp48sHwP--R1HZSYxB7YRw98XgA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=emacs-devel@gnu.org \
--cc=stepheng+savannah@gildea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.