* bug#48060: "make check" leaves temporary files after native-comp merge
@ 2021-04-27 14:27 Stefan Kangas
2021-04-27 15:15 ` Glenn Morris
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Stefan Kangas @ 2021-04-27 14:27 UTC (permalink / raw)
To: 48060; +Cc: Andrea Corallo
After some iterations of running of "make -j8 bootstrap && make -j8
check", my ~/src/emacs is filled with a lot of temporary directories:
drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0B1nPY
drwx------ 2 skangas skangas 4.0K 2021-04-26 12:01 emacs-testsuite-0Ei8cf
drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0G40w3
drwx------ 2 skangas skangas 4.0K 2021-04-27 02:59 emacs-testsuite-0GcjNo
drwx------ 2 skangas skangas 4.0K 2021-04-27 02:43 emacs-testsuite-0Gwmf7
drwx------ 2 skangas skangas 4.0K 2021-04-26 20:24 emacs-testsuite-0HYLcF
drwx------ 2 skangas skangas 4.0K 2021-04-27 03:49 emacs-testsuite-0Iy0yX
drwx------ 2 skangas skangas 4.0K 2021-04-26 12:01 emacs-testsuite-0JpgU6
I actually have 2922 of these directories.
The content of one of these directories is:
emacs-testsuite-xdgMCK
└── 28.0.50-d25e21f7
└── subr--trampoline-63616c6c2d70726f63657373_call_process_0.eln
1 directory, 1 file
Others are empty:
emacs-testsuite-1HQfjD
0 directories, 0 files
Every time I run "make -j8 check", I get another 584 of these directories.
Could we do something to ensure these directories are always deleted?
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 14:27 bug#48060: "make check" leaves temporary files after native-comp merge Stefan Kangas
@ 2021-04-27 15:15 ` Glenn Morris
2021-04-27 16:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-24 12:21 ` Lars Ingebrigtsen
2 siblings, 0 replies; 12+ messages in thread
From: Glenn Morris @ 2021-04-27 15:15 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 48060, Andrea Corallo
Stefan Kangas wrote:
> After some iterations of running of "make -j8 bootstrap && make -j8
> check", my ~/src/emacs is filled with a lot of temporary directories:
>
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0B1nPY
As predicted in https://debbugs.gnu.org/47138#28 ?
(I see that report is still open, BTW. Not saying it should be merged.)
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 14:27 bug#48060: "make check" leaves temporary files after native-comp merge Stefan Kangas
2021-04-27 15:15 ` Glenn Morris
@ 2021-04-27 16:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 17:35 ` Eli Zaretskii
2021-04-27 19:25 ` Michael Albinus
2022-05-24 12:21 ` Lars Ingebrigtsen
2 siblings, 2 replies; 12+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-27 16:53 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 48060
Stefan Kangas <stefan@marxist.se> writes:
> After some iterations of running of "make -j8 bootstrap && make -j8
> check", my ~/src/emacs is filled with a lot of temporary directories:
>
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0B1nPY
> drwx------ 2 skangas skangas 4.0K 2021-04-26 12:01 emacs-testsuite-0Ei8cf
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0G40w3
> drwx------ 2 skangas skangas 4.0K 2021-04-27 02:59 emacs-testsuite-0GcjNo
> drwx------ 2 skangas skangas 4.0K 2021-04-27 02:43 emacs-testsuite-0Gwmf7
> drwx------ 2 skangas skangas 4.0K 2021-04-26 20:24 emacs-testsuite-0HYLcF
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:49 emacs-testsuite-0Iy0yX
> drwx------ 2 skangas skangas 4.0K 2021-04-26 12:01 emacs-testsuite-0JpgU6
>
> I actually have 2922 of these directories.
>
> The content of one of these directories is:
>
> emacs-testsuite-xdgMCK
> └── 28.0.50-d25e21f7
> └── subr--trampoline-63616c6c2d70726f63657373_call_process_0.eln
>
> 1 directory, 1 file
>
> Others are empty:
>
> emacs-testsuite-1HQfjD
>
> 0 directories, 0 files
>
> Every time I run "make -j8 check", I get another 584 of these directories.
>
> Could we do something to ensure these directories are always deleted?
I guess the correct way to do it would be in the Makefile when tests are
done, am I correct?
The other option would be to have Emacs to clean-up this directory
before exiting, but in case of a crash it wouldn't work.
The last option would be to convince `make-temp-file' we call at
startup.el:553 to create the directory in "/tmp/" or equivalent (not
sure that's possible).
Andrea
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 16:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-27 17:35 ` Eli Zaretskii
2021-04-27 21:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 19:25 ` Michael Albinus
1 sibling, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2021-04-27 17:35 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48060, stefan
> Cc: 48060@debbugs.gnu.org
> Date: Tue, 27 Apr 2021 16:53:33 +0000
> From: Andrea Corallo via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I guess the correct way to do it would be in the Makefile when tests are
> done, am I correct?
>
> The other option would be to have Emacs to clean-up this directory
> before exiting, but in case of a crash it wouldn't work.
We usually do the latter. Crashes in the test suite should be rare.
> The last option would be to convince `make-temp-file' we call at
> startup.el:553 to create the directory in "/tmp/" or equivalent (not
> sure that's possible).
That's only a good solution on platforms where /tmp is periodically
cleaned up, or even disappears when the user logs off.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 17:35 ` Eli Zaretskii
@ 2021-04-27 21:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 12+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-27 21:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 48060, stefan
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 48060@debbugs.gnu.org
>> Date: Tue, 27 Apr 2021 16:53:33 +0000
>> From: Andrea Corallo via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> I guess the correct way to do it would be in the Makefile when tests are
>> done, am I correct?
>>
>> The other option would be to have Emacs to clean-up this directory
>> before exiting, but in case of a crash it wouldn't work.
>
> We usually do the latter. Crashes in the test suite should be rare.
Right, c62262736c using `kill-emacs-hook' should do the clean-up for all
non crashing sessions.
Regards
Andrea
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 16:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 17:35 ` Eli Zaretskii
@ 2021-04-27 19:25 ` Michael Albinus
2021-04-27 20:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 12+ messages in thread
From: Michael Albinus @ 2021-04-27 19:25 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48060, Stefan Kangas
Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
Hi Andrea,
>> The content of one of these directories is:
>>
>> emacs-testsuite-xdgMCK
>> └── 28.0.50-d25e21f7
>> └── subr--trampoline-63616c6c2d70726f63657373_call_process_0.eln
>>
>> 1 directory, 1 file
>>
>> Others are empty:
>>
>> emacs-testsuite-1HQfjD
>>
>> 0 directories, 0 files
>>
>> Every time I run "make -j8 check", I get another 584 of these directories.
>>
>> Could we do something to ensure these directories are always deleted?
>
> I guess the correct way to do it would be in the Makefile when tests are
> done, am I correct?
>
> The other option would be to have Emacs to clean-up this directory
> before exiting, but in case of a crash it wouldn't work.
Not an Emacs cleanup. Usually, test functions are responsible for their
own cleanup. You could put the whole test body in an unwind-protect
bodyform, and perform the cleanup in one of the unwindforms.
> Andrea
Best regards, Michael.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 19:25 ` Michael Albinus
@ 2021-04-27 20:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-28 10:57 ` Michael Albinus
0 siblings, 1 reply; 12+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-27 20:34 UTC (permalink / raw)
To: Michael Albinus; +Cc: 48060, Stefan Kangas
Michael Albinus <michael.albinus@gmx.de> writes:
> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
> Hi Andrea,
>
>>> The content of one of these directories is:
>>>
>>> emacs-testsuite-xdgMCK
>>> └── 28.0.50-d25e21f7
>>> └── subr--trampoline-63616c6c2d70726f63657373_call_process_0.eln
>>>
>>> 1 directory, 1 file
>>>
>>> Others are empty:
>>>
>>> emacs-testsuite-1HQfjD
>>>
>>> 0 directories, 0 files
>>>
>>> Every time I run "make -j8 check", I get another 584 of these directories.
>>>
>>> Could we do something to ensure these directories are always deleted?
>>
>> I guess the correct way to do it would be in the Makefile when tests are
>> done, am I correct?
>>
>> The other option would be to have Emacs to clean-up this directory
>> before exiting, but in case of a crash it wouldn't work.
>
> Not an Emacs cleanup. Usually, test functions are responsible for their
> own cleanup. You could put the whole test body in an unwind-protect
> bodyform, and perform the cleanup in one of the unwindforms.
Hi Michael,
the issue is that here is not really the test function that is creating
this folder, but Emacs it-self that to operate needs a folder to store
and retrieve eln files.
For the test-suite we moved to a different folder than the one we use
for normal runs to have a clean environment to run the test-suite on.
Regards
Andrea
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 20:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-28 10:57 ` Michael Albinus
2021-04-28 19:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 12+ messages in thread
From: Michael Albinus @ 2021-04-28 10:57 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48060, Stefan Kangas
Andrea Corallo <akrl@sdf.org> writes:
> Hi Michael,
Hi Andrea,
> the issue is that here is not really the test function that is creating
> this folder, but Emacs it-self that to operate needs a folder to store
> and retrieve eln files.
I know.
> For the test-suite we moved to a different folder than the one we use
> for normal runs to have a clean environment to run the test-suite on.
Couldn't you create this different folder inside an ert-deftest, and
remove it at test-case end?
> Regards
>
> Andrea
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-28 10:57 ` Michael Albinus
@ 2021-04-28 19:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-02 8:30 ` Lars Ingebrigtsen
0 siblings, 1 reply; 12+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-28 19:31 UTC (permalink / raw)
To: Michael Albinus; +Cc: 48060, Stefan Kangas
Michael Albinus <michael.albinus@gmx.de> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>> Hi Michael,
>
> Hi Andrea,
>
>> the issue is that here is not really the test function that is creating
>> this folder, but Emacs it-self that to operate needs a folder to store
>> and retrieve eln files.
>
> I know.
>
>> For the test-suite we moved to a different folder than the one we use
>> for normal runs to have a clean environment to run the test-suite on.
>
> Couldn't you create this different folder inside an ert-deftest, and
> remove it at test-case end?
No, Emacs needs to be able if necessary to depose .eln files even before
a test is run (this is not specific to native-comp tests), and given we
set HOME to a non existent directory the conventional
"~/.emacs.d/eln-cache" can't be used.
Regards
Andrea
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-28 19:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-05-02 8:30 ` Lars Ingebrigtsen
2021-05-02 21:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 12+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-02 8:30 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48060, Stefan Kangas, Michael Albinus
Andrea Corallo <akrl@sdf.org> writes:
>> Couldn't you create this different folder inside an ert-deftest, and
>> remove it at test-case end?
>
> No, Emacs needs to be able if necessary to depose .eln files even before
> a test is run (this is not specific to native-comp tests), and given we
> set HOME to a non existent directory the conventional
> "~/.emacs.d/eln-cache" can't be used.
I don't quite understand how this precludes us from specifying a
directory under test/ for the .eln files? I.e.,
HOME=/nonexistent ELN_DIR=test/cache-dir emacs ...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-05-02 8:30 ` Lars Ingebrigtsen
@ 2021-05-02 21:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 12+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-05-02 21:28 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 48060, Stefan Kangas, Michael Albinus
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Andrea Corallo <akrl@sdf.org> writes:
>
>>> Couldn't you create this different folder inside an ert-deftest, and
>>> remove it at test-case end?
>>
>> No, Emacs needs to be able if necessary to depose .eln files even before
>> a test is run (this is not specific to native-comp tests), and given we
>> set HOME to a non existent directory the conventional
>> "~/.emacs.d/eln-cache" can't be used.
>
> I don't quite understand how this precludes us from specifying a
> directory under test/ for the .eln files? I.e.,
>
> HOME=/nonexistent ELN_DIR=test/cache-dir emacs ...
I agree, these are just to different cases, specifying one single
directory is certainly possible, doing it test by test inside
ert-deftest makes me a little more skeptical :)
Andrea
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#48060: "make check" leaves temporary files after native-comp merge
2021-04-27 14:27 bug#48060: "make check" leaves temporary files after native-comp merge Stefan Kangas
2021-04-27 15:15 ` Glenn Morris
2021-04-27 16:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-05-24 12:21 ` Lars Ingebrigtsen
2 siblings, 0 replies; 12+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-24 12:21 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 48060, Andrea Corallo
Stefan Kangas <stefan@marxist.se> writes:
> After some iterations of running of "make -j8 bootstrap && make -j8
> check", my ~/src/emacs is filled with a lot of temporary directories:
>
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0B1nPY
> drwx------ 2 skangas skangas 4.0K 2021-04-26 12:01 emacs-testsuite-0Ei8cf
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:50 emacs-testsuite-0G40w3
> drwx------ 2 skangas skangas 4.0K 2021-04-27 02:59 emacs-testsuite-0GcjNo
> drwx------ 2 skangas skangas 4.0K 2021-04-27 02:43 emacs-testsuite-0Gwmf7
> drwx------ 2 skangas skangas 4.0K 2021-04-26 20:24 emacs-testsuite-0HYLcF
> drwx------ 2 skangas skangas 4.0K 2021-04-27 03:49 emacs-testsuite-0Iy0yX
> drwx------ 2 skangas skangas 4.0K 2021-04-26 12:01 emacs-testsuite-0JpgU6
>
> I actually have 2922 of these directories.
Andrea's previous changes reduced the number of these directories, but
there were still some left over. I think I've now fixed that, at least
for "make check", and I'm going through the other ert interface
functions, too.
nativecomp still leaves other files over, but I'm opening a new report
for that, and closing this one.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-05-24 12:21 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-27 14:27 bug#48060: "make check" leaves temporary files after native-comp merge Stefan Kangas
2021-04-27 15:15 ` Glenn Morris
2021-04-27 16:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 17:35 ` Eli Zaretskii
2021-04-27 21:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 19:25 ` Michael Albinus
2021-04-27 20:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-28 10:57 ` Michael Albinus
2021-04-28 19:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-02 8:30 ` Lars Ingebrigtsen
2021-05-02 21:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-24 12:21 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.