From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58801: [PATCH] Autoload the `calc-eval-error' variable Date: Fri, 11 Nov 2022 05:16:42 -0800 Message-ID: References: <87fsfaa56t.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58801@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 14:17:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otTui-0002Ev-9P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 14:17:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otTuG-00021G-Tr; Fri, 11 Nov 2022 08:17:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otTu4-0001zO-9V for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 08:17:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otTu2-0004ll-SF for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 08:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otTu2-0002We-EE for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 08:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58801 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58801-submit@debbugs.gnu.org id=B58801.16681726119687 (code B ref 58801); Fri, 11 Nov 2022 13:17:02 +0000 Original-Received: (at 58801) by debbugs.gnu.org; 11 Nov 2022 13:16:51 +0000 Original-Received: from localhost ([127.0.0.1]:45302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otTtq-0002WB-Se for submit@debbugs.gnu.org; Fri, 11 Nov 2022 08:16:51 -0500 Original-Received: from mail-oa1-f45.google.com ([209.85.160.45]:41787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otTto-0002Vg-RW for 58801@debbugs.gnu.org; Fri, 11 Nov 2022 08:16:49 -0500 Original-Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-13b23e29e36so5369636fac.8 for <58801@debbugs.gnu.org>; Fri, 11 Nov 2022 05:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=qviCXnq+jMJeOPxhrcj7ftYOY+07NKZJ3sTa6ZqqMFY=; b=qetdZPGgGiMVxw9XW/9CSiwLZ+zELHoxEP7TWZ6JCbNmV9R7WyU/kG8KJz/TcNT+ii xRSp7aE1KeRg05dk7SylVnLWf0MyuzNZC7md2qwLLknNGEAWbM9oCfj3pfAel9SyZAfD Pe4HeiSknNNV485Ts3+gHhcsvjJP/aKHzbNoWWGTJ59+CmUzAxX9s055oPD5eWcJ+5vN VwbL7++fLoyXQy6Lk7udXvgPWILt2cvRJ17nnVjJNNmgJZA2cSuX6udWWvA9VPf2Zj7w MG/5GFshCVItEc++hJDsze1LM0UdYbGBDXKvZT4/OqBMUZrb+lDpJCa5khP21BGGH2lU vcww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qviCXnq+jMJeOPxhrcj7ftYOY+07NKZJ3sTa6ZqqMFY=; b=ontteArNiuIGesTaEnNOwMgUFwbQh6zB0SO8igLwxMHvfb4jSfQtP4ps4WZ1SghELV PUzya8meHpZmpfwoo402cygjYB/tMdS2nYMU6v92qImGvNMt0TPyAP5j2UvnF5E3os6D F9i2w/IgxgrQa8KsjcR53+2TEE7GJVMqDQrhh9X/s8op3tFWwoMovEb7NqCZ7CiJhUGy S4nzm0DF2QwKaVZdkNW3hlVkB2Pr1BeJTW4V5zaccGERSiKvom6jL77lGIGMUxkAh7ZM XpiXD0fVY59Vg2OXwlxbrIRx1cfktkehHM24i2Qxn24yOcxOHtCkiU/1F/gR/ydIgNuh cUhw== X-Gm-Message-State: ANoB5plKsnBUnxdW1kSE4/jbiBJ7VCfTakvoi1d7QyIEiUuJYIkhDhQX 0odJl70OszqqWCa1F5ExbcGj2Ay2h052VqVZslbqivnf X-Google-Smtp-Source: AA0mqf4KbrCy0jTnOfvjumApQlpHcAosxOq+JJLGpDmV6K/nr71C3RifTDuo/8ENXebeITNdZaLh5Tmz/bhqfinf64Y= X-Received: by 2002:a05:6871:480a:b0:12b:fbe7:b793 with SMTP id qc10-20020a056871480a00b0012bfbe7b793mr797385oab.92.1668172603258; Fri, 11 Nov 2022 05:16:43 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 11 Nov 2022 05:16:42 -0800 In-Reply-To: <87fsfaa56t.fsf@rfc20.org> (Matt Armstrong's message of "Wed, 26 Oct 2022 10:02:50 -0700") X-Hashcash: 1:20:221111:58801@debbugs.gnu.org::1g+giFQ+1SkwQ5T0:7Jew X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247587 Archived-At: Matt Armstrong writes: > From 526d0b31e0d836e7a3c21d831849b8c50da2420e Mon Sep 17 00:00:00 2001 > From: Matt Armstrong > Date: Wed, 26 Oct 2022 09:46:37 -0700 > Subject: [PATCH] Autoload the `calc-eval-error' variable > > * lisp/calc/calc-aent.el: Autoload the `calc-eval-error' variable, > because it is documented as a lisp level option of the `calc-eval' > function, which is also autoloaded. Otherwise, even (require 'calc) > is not enough to get the variable defined; `calc-eval' must actually > be evaluated. This squashes byte compiler warnings in code using the > variable. I don't necessarily object strongly or anything, but should we really autoload a variable just to squash byte compiler warnings? I think the usual way to do that is to say (defvar calc-eval-error) in the calling code. > --- > lisp/calc/calc-aent.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/calc/calc-aent.el b/lisp/calc/calc-aent.el > index ef3e0d4b67..59692beff7 100644 > --- a/lisp/calc/calc-aent.el > +++ b/lisp/calc/calc-aent.el > @@ -252,6 +252,7 @@ calc-do-calc-eval > res (cdr res))) > buf))))))))) > > +;;;###autoload > (defvar calc-eval-error nil > "Determines how calc handles errors. > If nil, return a list containing the character position of error.