all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: David Kastrup <dak@gnu.org>, 6861@debbugs.gnu.org
Subject: bug#6861: 24.0.50; Scroll lock not bound
Date: Sat, 28 Sep 2019 15:11:59 +0200	[thread overview]
Message-ID: <CADwFkmmzDFBQwBf4hv9EMrbH2+UErzCU-ggeM2=Gw3vCxKE8eg@mail.gmail.com> (raw)
In-Reply-To: <83sgoghb3b.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> > OK.  How about the attached patch?
>
> It's fine, but please say "MS-Windows" to be more precise.

Thanks; fixed in attached patch.  I'll push it in a couple of days if
there are no further comments.

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Bind-Scroll_Lock-to-scroll-lock-mode-globally.patch --]
[-- Type: text/x-patch, Size: 2251 bytes --]

From 4e45ae74bffd9c4f8ff8427eb4c41cfee167b3f1 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 20 Aug 2019 19:04:16 +0200
Subject: [PATCH] Bind Scroll_Lock to scroll-lock-mode globally

* lisp/bindings.el (global-map): Bind Scroll_Lock to
scroll-lock-mode.  (Bug#6861)
* lisp/scroll-lock.el (scroll-lock-mode): Note that the binding will
not work if 'w32-scroll-lock-modifier' is non-nil.
* etc/NEWS: Announce it.
---
 etc/NEWS            | 5 +++++
 lisp/bindings.el    | 1 +
 lisp/scroll-lock.el | 5 ++++-
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index 56e5fd2f83..60b583200a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -419,6 +419,11 @@ RGB triplets with a single hexadecimal digit per component.
 ---
 ** The toolbar now shows the equivalent key binding in its tooltips.
 
+---
+** 'scroll-lock-mode' is now bound to the 'Scroll_Lock' key globally.
+Note that this key binding will not work on MS-Windows systems if
+'w32-scroll-lock-modifier' is non-nil.
+
 \f
 * Editing Changes in Emacs 27.1
 
diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0be1458798..16da2bdf9a 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1054,6 +1054,7 @@ global-map
 ;(define-key global-map [delete] 'backward-delete-char)
 
 ;; natural bindings for terminal keycaps --- defined in X keysym order
+(define-key global-map [Scroll_Lock]    'scroll-lock-mode)
 (define-key global-map [C-S-backspace]  'kill-whole-line)
 (define-key global-map [home]		'move-beginning-of-line)
 (define-key global-map [C-home]		'beginning-of-buffer)
diff --git a/lisp/scroll-lock.el b/lisp/scroll-lock.el
index 3a74c11b7a..36e2264fe4 100644
--- a/lisp/scroll-lock.el
+++ b/lisp/scroll-lock.el
@@ -54,7 +54,10 @@ scroll-lock-mode
 When enabled, keys that normally move point by line or paragraph
 will scroll the buffer by the respective amount of lines instead
 and point will be kept vertically fixed relative to window
-boundaries during scrolling."
+boundaries during scrolling.
+
+Note that the default key binding to Scroll_Lock will not work on
+MS-Windows systems if `w32-scroll-lock-modifier' is non-nil."
   :lighter " ScrLck"
   :keymap scroll-lock-mode-map
   (if scroll-lock-mode
-- 
2.20.1


  reply	other threads:[~2019-09-28 13:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-15  9:13 bug#6861: 24.0.50; Scroll lock not bound David Kastrup
2019-08-10 19:37 ` Stefan Kangas
2019-08-20 17:15   ` Stefan Kangas
2019-08-20 17:54     ` Eli Zaretskii
2019-08-20 18:28       ` Stefan Kangas
2019-08-21 16:49         ` Eli Zaretskii
2019-08-27 12:28           ` Stefan Kangas
2019-08-27 12:40             ` Eli Zaretskii
2019-08-27 13:00               ` David Kastrup
2019-08-27 14:57                 ` Eli Zaretskii
2019-08-27 19:11                   ` David Kastrup
2019-08-27 19:21                     ` Eli Zaretskii
2019-09-26 17:47               ` Stefan Kangas
2019-09-26 18:00                 ` Eli Zaretskii
2019-09-28 11:26                   ` Stefan Kangas
2019-09-28 12:14                     ` Eli Zaretskii
2019-09-28 13:11                       ` Stefan Kangas [this message]
2019-10-04 16:05                         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmzDFBQwBf4hv9EMrbH2+UErzCU-ggeM2=Gw3vCxKE8eg@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=6861@debbugs.gnu.org \
    --cc=dak@gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.