From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41844: 26.3; Compilation mode keybindings inconsistent with Grep mode Date: Thu, 20 Aug 2020 07:54:05 -0700 Message-ID: References: <4179197.mvXUDI8C0e@laptop.coltonlewis.name> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000bb9f9105ad504a53" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41844@debbugs.gnu.org To: Colton Lewis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 16:55:49 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8lyk-0003EQ-0N for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 16:55:46 +0200 Original-Received: from localhost ([::1]:36534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8lyj-0006rf-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 10:55:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8ly2-0005p4-Nq for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 10:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8ly2-0004P5-DP for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 10:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8ly2-0003Pe-BM for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 10:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41844 X-GNU-PR-Package: emacs Original-Received: via spool by 41844-submit@debbugs.gnu.org id=B41844.159793525413036 (code B ref 41844); Thu, 20 Aug 2020 14:55:02 +0000 Original-Received: (at 41844) by debbugs.gnu.org; 20 Aug 2020 14:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:43384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8lxG-0003O7-3V for submit@debbugs.gnu.org; Thu, 20 Aug 2020 10:54:14 -0400 Original-Received: from mail-yb1-f196.google.com ([209.85.219.196]:40438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8lxE-0003Nm-61 for 41844@debbugs.gnu.org; Thu, 20 Aug 2020 10:54:13 -0400 Original-Received: by mail-yb1-f196.google.com with SMTP id q3so1259717ybp.7 for <41844@debbugs.gnu.org>; Thu, 20 Aug 2020 07:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=o/qlNxC57aArIEnv1PzJOxNfOxJ+xl9aywjSkUWANQM=; b=rco4Y1NrKKbSGpfTE4b8h1bTNojumhVBc2olEsdOpKdzWTs0WFZ9qS/oa8xFDoZQJg oX5y5Ajvg10U+mOwFIPx5yixZvdBa2R/C2ClUBA/twOroaRxvcH2kvZ5nI4ua4zVlzVi aDGPXuF7bMEN8nlhoFB23225MAs3LdPKEm4gvuhGPfC+XxYRL52sCrvK0B6+z8VyvM12 uWeAoNpUiLuqMt4OOnilp1O5nUOxJHp8zrKR0YC3UV09UQs6/kUgYKDFSuPUDGXeAiQI 4+W723hOx2W2gWyQ1WzGdPYY4ZxZmy23JCK1HxyExjJnUVsl4g+qE4+LSB9YG30kLW5h U5PA== X-Gm-Message-State: AOAM531Q0QzKwOjLT3wwngWnrXsj8sWpqb8omYQN6FJW/RDp2NsGm4a/ UOhVs9a3rYbuV6hn0GkBsKxw5mMuQm6G1DpqiwU= X-Google-Smtp-Source: ABdhPJzT9XLE1hMrl87WHDP0hMknRwrM3q3Dpq4iR6+wfm/Dblkxc9oWlFvjG3Mhvi+yC9SxiYdGCeaf2UeWFW7EonA= X-Received: by 2002:a25:4609:: with SMTP id t9mr4995291yba.231.1597935246174; Thu, 20 Aug 2020 07:54:06 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 20 Aug 2020 07:54:05 -0700 In-Reply-To: <4179197.mvXUDI8C0e@laptop.coltonlewis.name> (Colton Lewis's message of "Sun, 14 Jun 2020 03:57:25 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185702 Archived-At: --000000000000bb9f9105ad504a53 Content-Type: text/plain; charset="UTF-8" severity 41844 wishlist tags 41844 + patch thanks Colton Lewis writes: > When in Grep mode, 'n' and 'p' respectively go to the next and previous > match in the buffer. > > However, Compilation mode leaves 'n' and 'p' unbound. This inconsistency > is annoying. Sounds like a good idea to me. I've attached a patch which does this. Any other opinions? I admit that I don't use compilation-mode as much as I probably should (I'm silly enough to often run make manually from my shell). Best regards, Stefan Kangas --000000000000bb9f9105ad504a53 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Bind-n-and-p-in-compilation-mode-map.patch" Content-Disposition: attachment; filename="0001-Bind-n-and-p-in-compilation-mode-map.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: a522489aab984b96_0.1 RnJvbSA0MzczZGEwYjRlOGNlZTIzYzUzYjVlNDZmMjhkNjllOWI2ZTQ0NGVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDIwIEF1ZyAyMDIwIDE2OjQxOjUwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QmluZCAnbicgYW5kICdwJyBpbiBjb21waWxhdGlvbi1tb2RlLW1hcAoKKiBsaXNwL3Byb2dtb2Rl cy9jb21waWxlLmVsIChjb21waWxhdGlvbi1tb2RlLW1hcCk6IEJpbmQKJyhuZXh0fHByZXZpb3Vz KS1lcnJvci1uby1zZWxlY3QnIHRvICduJyBhbmQgJ3AnLiAgKEJ1ZyM0MTg0NCkKLS0tCiBsaXNw L3Byb2dtb2Rlcy9jb21waWxlLmVsIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwgYi9saXNwL3Byb2dt b2Rlcy9jb21waWxlLmVsCmluZGV4IDBiOWY0MTc4NDUuLjI4MDVmNjQ0ZTkgMTAwNjQ0Ci0tLSBh L2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5l bApAQCAtMjA2NCw2ICsyMDY0LDggQEAgY29tcGlsYXRpb24tbW9kZS1tYXAKICAgICAoZGVmaW5l LWtleSBtYXAgIlxNLXAiICdjb21waWxhdGlvbi1wcmV2aW91cy1lcnJvcikKICAgICAoZGVmaW5l LWtleSBtYXAgIlxNLXsiICdjb21waWxhdGlvbi1wcmV2aW91cy1maWxlKQogICAgIChkZWZpbmUt a2V5IG1hcCAiXE0tfSIgJ2NvbXBpbGF0aW9uLW5leHQtZmlsZSkKKyAgICAoZGVmaW5lLWtleSBt YXAgIm4iICduZXh0LWVycm9yLW5vLXNlbGVjdCkKKyAgICAoZGVmaW5lLWtleSBtYXAgInAiICdw cmV2aW91cy1lcnJvci1uby1zZWxlY3QpCiAgICAgKGRlZmluZS1rZXkgbWFwICJcdCIgJ2NvbXBp bGF0aW9uLW5leHQtZXJyb3IpCiAgICAgKGRlZmluZS1rZXkgbWFwIFtiYWNrdGFiXSAnY29tcGls YXRpb24tcHJldmlvdXMtZXJyb3IpCiAgICAgKGRlZmluZS1rZXkgbWFwICJnIiAncmVjb21waWxl KSA7IHJldmVydAotLSAKMi4yOC4wCgo= --000000000000bb9f9105ad504a53--