From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58472: [PATCH] Make `message-unique-id' less prone to collisions Date: Sun, 16 Oct 2022 17:05:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21056"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58472@debbugs.gnu.org, Matt Armstrong To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 16 19:06:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ok75e-0005JJ-0M for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 19:06:18 +0200 Original-Received: from localhost ([::1]:50410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ok75c-00081N-GD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 13:06:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok75O-00080U-Qs for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 13:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ok75O-0000Fh-Jr for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 13:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ok75O-00043C-BC for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2022 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58472-submit@debbugs.gnu.org id=B58472.166593994415540 (code B ref 58472); Sun, 16 Oct 2022 17:06:02 +0000 Original-Received: (at 58472) by debbugs.gnu.org; 16 Oct 2022 17:05:44 +0000 Original-Received: from localhost ([127.0.0.1]:46028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok755-00042a-Oz for submit@debbugs.gnu.org; Sun, 16 Oct 2022 13:05:43 -0400 Original-Received: from mail-oa1-f54.google.com ([209.85.160.54]:39454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ok754-00042O-DJ for 58472@debbugs.gnu.org; Sun, 16 Oct 2022 13:05:42 -0400 Original-Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1322fa1cf6fso11154360fac.6 for <58472@debbugs.gnu.org>; Sun, 16 Oct 2022 10:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=KMzl9A62qlodGAvZiFIsthrWq4cceQbam4EPYDkgirQ=; b=bmCTnt3tbaAmIdTSyW3I+yR2DRd6NwOiGZikmdwmEgULbu+1wY33yuXmGYnR8rWV2y LEiySgPbrpTwGcGqZflfUCsm1luOajIYv2Rq4dA8U/UkniTgUk1aTfFoo4rsjVuO3ui4 OzQwjjBGYDR1we9/sO3MFTaykr1p4+m6F2woaHMLAyUdY+cDCq1kz2csgWy9oT+NI1IA 66T6a/IwEIM7iOI3VVQdqtDrzlG9AF/pMVweRN1hN4Ott+RYx05fbeOI1qQ2WxCKo9ss x916iYqPtmxhRFWQfQSAT+ZuS96PaCLN45R65RcxSIMi55gTq+ylGJMfdKC/19Qxw6kv D4Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KMzl9A62qlodGAvZiFIsthrWq4cceQbam4EPYDkgirQ=; b=uAE7sWwrx94OV6HUlEaFDZOo4/AObTDJCzne0pmk2i9RtbQLgOeQI9YEbKGTiXmo5Q yKvPAa+33vFTp+zzgxJsbovqkljm6O8mgZjAgxNAjd8McjrQCh6PPXReGDN6m0SNAeTR PRDGj2IXOfSCTEBqmZfptHxdO0ueSTD+NBaZPEUJk6G7sY9EQyvXhnwVTnHxlamICtkw trHGobss/SW4tdglon09/XWd8mFjgbGHTV+GASKO7yw2+mDKn8lFnJJFXhFzSJv+N4CT 5x+2v/QCirsUk5UWfll2/TayS6HERce19N3Em3kHGPcBfrB0G83amVm37WT67ziBainl SF5Q== X-Gm-Message-State: ACrzQf15MvjE/BYWTSRGgGjmkr2HpuII0acGSI8pJvvXDCBAW2Jn7QDc YXVh68sf0xgXCavtwSv+CYP+aOdTQUpl42pnxfk= X-Google-Smtp-Source: AMsMyM6uARtGSGuNely8zfVRI4JV6avnH2XbONbaiVxD2yOXMUohruSlJqf1AELC1OmaniJ/8sZnfWeuNLJj6VKdSPg= X-Received: by 2002:a05:6870:9126:b0:132:b724:e96c with SMTP id o38-20020a056870912600b00132b724e96cmr13565090oae.199.1665939936771; Sun, 16 Oct 2022 10:05:36 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 16 Oct 2022 17:05:36 +0000 In-Reply-To: X-Hashcash: 1:20:221016:58472@debbugs.gnu.org::4PwZkB/ElGPpGa2f:Fr+x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245669 Archived-At: Stefan Kangas writes: > BTW, we currently call getrandom with flags 0 in > extract_data_from_object. Should we consider using GRND_RANDOM? linux.git/include/uapi/linux/random.h says that: /* * Flags for getrandom(2) * * GRND_NONBLOCK Don't block and return EAGAIN instead * GRND_RANDOM No effect * GRND_INSECURE Return non-cryptographic random bytes */ But the story is probably not the same on other systems, according to the glibc documentation, so we should probably not change this.