From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59229: [PATCH] Add tree-sitter-based major modes to eglot-server-programs Date: Thu, 24 Nov 2022 10:44:17 -0800 Message-ID: References: <87y1sfls1x.fsf@posteo.net> <83cz9rmkoc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="389"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59229@debbugs.gnu.org, Brian Leung To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 19:45:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyHDl-000AOn-JW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 19:45:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyHDd-0003CT-4h; Thu, 24 Nov 2022 13:45:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyHDa-0003C7-9y for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 13:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyHDa-0007lg-1Q for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 13:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyHDZ-0001Ee-TE for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 13:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59229-submit@debbugs.gnu.org id=B59229.16693154654686 (code B ref 59229); Thu, 24 Nov 2022 18:45:01 +0000 Original-Received: (at 59229) by debbugs.gnu.org; 24 Nov 2022 18:44:25 +0000 Original-Received: from localhost ([127.0.0.1]:60147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyHCz-0001DV-F9 for submit@debbugs.gnu.org; Thu, 24 Nov 2022 13:44:25 -0500 Original-Received: from mail-ot1-f47.google.com ([209.85.210.47]:35789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyHCx-0001DD-UK for 59229@debbugs.gnu.org; Thu, 24 Nov 2022 13:44:24 -0500 Original-Received: by mail-ot1-f47.google.com with SMTP id cn2-20020a056830658200b0066c74617e3dso1396509otb.2 for <59229@debbugs.gnu.org>; Thu, 24 Nov 2022 10:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=WlAgW0SN9NbHexQ5jtbqs81x58QWpUvUx/k1PAV6v9E=; b=YbRoC2x79+Lqs3aDP7vgwlGbxJi4RGzJPcCB15YtoYzPoLl6L88qoN+5Ef5XUUDRr0 /bsB6xmns9m0DBDKnp8UmI0SfH9Rj8ulOZL7nmbC3P3PXE6Sj7sdqzHvw75zngseotpU I4L5il6LGhrCRLFPx46nwmXrBi6Akh1fO8zWI8BifAqlFHzib8oLUPdd8UFwHXdCOC+5 O1SHe1zdstP+U3G9WX33Xe2quGqMjVUE8EppZVg7FFmc1SmEITGxOcynXxfJNu3/YEo7 qjOA2wqZSzErzHPO9UCwHEg/OnP3hpY2hmYf/c9GPfiBhC4+7rkRNwpTGndB8xEHds6O DARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WlAgW0SN9NbHexQ5jtbqs81x58QWpUvUx/k1PAV6v9E=; b=U6SEvIQ8jHDWOtOcLfYKHsoDXsuxz61bmXorZgzVWpvKO147HKdGWh6Q5zGwY7IRWD TAvohn3dm08leITvWbjAVOB5+ZMQyZ/6NHz/nkYvxYuw4hopBQYlRSlX23yKllyH96ot FNgG2VzOVdo5ae2Z65l+6ZkmnDGvkrQJbsiba9rWaFFNiYEUPpSAQv1+AW44Y7QY+wkc XkhDl/pCmFUvGC+GAucTVoxEXVcfAK5IgHjBb+eOATPzouo5A6c/GyXp1XdLDJQA8phm DoKMVZWL+j20NZJWcRYELPPP/Btvn8oklHBKhccY4djU2Sb0qSbE5xcaAhXqqC+M+LUK 5Ovw== X-Gm-Message-State: ANoB5plPDDJHZHUNn/HvwUz9gH/BByQ29Nzzr7q10D/bNnRV7ehp38Mq dt6OUxjrElP6sddc9ojOctA04kYsl8Os/bmwLBY= X-Google-Smtp-Source: AA0mqf64akt/dZ65L+QR9N8dfjXOmswcN+tq8nQLRnso4wDrrI/xXku66n+/FfJYsRGMEFeHYZZpzeETduh59rq8cSk= X-Received: by 2002:a9d:70cc:0:b0:66c:5232:b9d1 with SMTP id w12-20020a9d70cc000000b0066c5232b9d1mr7283087otj.224.1669315458386; Thu, 24 Nov 2022 10:44:18 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Nov 2022 10:44:17 -0800 In-Reply-To: <83cz9rmkoc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Nov 2022 08:29:39 +0200") X-Hashcash: 1:20:221124:eliz@gnu.org::Ss3NFgMWEFsH1BZV:1X12 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248896 Archived-At: close 59229 29.1 thanks Eli Zaretskii writes: >> Cc: Stefan Kangas >> From: Brian Leung >> Date: Sat, 12 Nov 2022 22:35:38 +0000 >> >> This adds several to-be-merged tree-sitter-based major modes to eglot. > > Thanks, but please hold your horses on the C/C++/Java modes, as we > didn't yet finalize their integration into Emacs. It is possible they > will not be major modes after all. > > Not sure about JSON and CSS modes, but they might share the same fate. > > Bottom line: this is too soon for such change, we should wait at least > until the tree-sitter branch lands on master. AFAICT, these modes have all landed on master, so I've pushed the patch and I'm closing the bug. Thanks.