bug#71759: 30.0.60; Reference to non-existent `php-html-ts-mode' in php-ts-mode.el

bug#71759: 30.0.60; Reference to non-existent `php-html-ts-mode' in php-ts-mode.el

[Stefan Kangas]

Severity: minor

In php-ts-mode.el, the `php-ts-mode--custom-html-font-lock-settings'
variable docstring refers to a `php-html-ts-mode', but I can't find any
other references to such a mode in our tree.

bug#71759: 30.0.60; Reference to non-existent `php-html-ts-mode' in php-ts-mode.el

[Vincenzo Pupillo]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi Stefan,
I think this doc fix should be fine.
Thanks.

Vincenzo

In data lunedì 24 giugno 2024 22:08:00 CEST, Stefan Kangas ha scritto:
> Severity: minor
> 
> In php-ts-mode.el, the `php-ts-mode--custom-html-font-lock-settings'
> variable docstring refers to a `php-html-ts-mode', but I can't find any
> other references to such a mode in our tree.
> 
> 
> 

[-- Attachment #2: 0001-Doc-fix-in-php-ts-mode.patch --]
[-- Type: text/x-patch, Size: 1023 bytes --]

From cd655d70c150e705e7811e70563074421aecffec Mon Sep 17 00:00:00 2001
From: Vincenzo Pupillo <v.pupillo@gmail.com>
Date: Tue, 25 Jun 2024 10:37:40 +0200
Subject: [PATCH] Doc fix in 'php-ts-mode'

* lisp/progmodes/php-ts-mode.el
(php-ts-mode--custom-html-font-lock-settings): Doc fix.
(bug#71759)
---
 lisp/progmodes/php-ts-mode.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/php-ts-mode.el b/lisp/progmodes/php-ts-mode.el
index bede26b7da5..826c131ca70 100644
--- a/lisp/progmodes/php-ts-mode.el
+++ b/lisp/progmodes/php-ts-mode.el
@@ -977,7 +977,8 @@ php-ts-mode--custom-html-font-lock-settings
    :override t
    :feature 'property
    `((attribute_name) @font-lock-variable-name-face))
-  "Tree-sitter font-lock settings for `php-html-ts-mode'.")
+  "Tree-sitter Font-lock settings for HTML when embedded in PHP.
+Like `html-ts-mode--font-lock-settings' but adapted for `php-ts-mode'.")
 
 (defvar php-ts-mode--phpdoc-font-lock-settings
   (treesit-font-lock-rules
-- 
2.45.2

bug#71759: 30.0.60; Reference to non-existent `php-html-ts-mode' in php-ts-mode.el

[Stefan Kangas]

Version: 30.1

Vincenzo Pupillo <v.pupillo@gmail.com> writes:

> From cd655d70c150e705e7811e70563074421aecffec Mon Sep 17 00:00:00 2001
> From: Vincenzo Pupillo <v.pupillo@gmail.com>
> Date: Tue, 25 Jun 2024 10:37:40 +0200
> Subject: [PATCH] Doc fix in 'php-ts-mode'
>
> * lisp/progmodes/php-ts-mode.el
> (php-ts-mode--custom-html-font-lock-settings): Doc fix.
> (bug#71759)
> ---
>  lisp/progmodes/php-ts-mode.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, pushed to emacs-30 as commit d5c6eb1f964.  Closing.