Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition.

Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition.

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>  *** New function 'split-string-shell-command'.
> -This splits a shell string into separate components, respecting single
> -and double quotes, as well as backslash quoting.
> +This splits a shell command string into separate components,
> +respecting quoting with single ('like this') and double ("like this")
> +quotes, as well as backslash quoting (like\ this).

Arguably nit-picking, but would it better to say "a string containing
a shell command"?  It could be unclear here what a "shell command
string" is; a reader might believe it's a special string type.

Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition.

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 15 Jul 2021 13:53:20 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >  *** New function 'split-string-shell-command'.
> > -This splits a shell string into separate components, respecting single
> > -and double quotes, as well as backslash quoting.
> > +This splits a shell command string into separate components,
> > +respecting quoting with single ('like this') and double ("like this")
> > +quotes, as well as backslash quoting (like\ this).
> 
> Arguably nit-picking, but would it better to say "a string containing
> a shell command"?  It could be unclear here what a "shell command
> string" is; a reader might believe it's a special string type.

"A string containing SOMETHING" sounds strange to me.  In particular,
it could be interpreted to mean the string contains something else, in
addition to the shell command.  "Shell command string" is a string
that is a shell command.

Re: master 0c28223 2/3: ; * etc/NEWS: Fix wording in a recent addition.

[Andreas Schwab]

On Jul 15 2021, Eli Zaretskii wrote:

>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Thu, 15 Jul 2021 13:53:20 +0200
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >  *** New function 'split-string-shell-command'.
>> > -This splits a shell string into separate components, respecting single
>> > -and double quotes, as well as backslash quoting.
>> > +This splits a shell command string into separate components,
>> > +respecting quoting with single ('like this') and double ("like this")
>> > +quotes, as well as backslash quoting (like\ this).
>> 
>> Arguably nit-picking, but would it better to say "a string containing
>> a shell command"?  It could be unclear here what a "shell command
>> string" is; a reader might believe it's a special string type.
>
> "A string containing SOMETHING" sounds strange to me.  In particular,
> it could be interpreted to mean the string contains something else, in
> addition to the shell command.  "Shell command string" is a string
> that is a shell command.

It is a string that is treated as a shell command.  What the string
actually contains isn't the point.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."