bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.

bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

Severity: wishlist

I think the "Author" header line in package.el does not accurately
reflect the contributions to that file.  In particular, I think Tom
Tromey should be listed as the sole author of package.el, in line with
our practices and to recognize his contribution.

Please see the attached patch and compare it the output of the following
command:

$ git shortlog -sn -- lisp/emacs-lisp/package.el | cat -n

     1	   132	Artur Malabarba
     2	    54	Glenn Morris
     3	    52	Stefan Monnier
     4	    46	Chong Yidong
     5	    40	Paul Eggert
     6	    23	Stefan Kangas
     7	    16	Dmitry Gutov
     8	    11	Lars Ingebrigtsen
     9	     8	Daiki Ueno
    10	     8	Juanma Barranquero
    11	     7	Eli Zaretskii
    12	     7	Sam Steingold
    13	     5	Noam Postavsky
    14	     5	Ted Zlatanov
    15	     4	John Wiegley
    16	     4	Pieter van Oostrum
    17	     3	Basil L. Contovounesios
    18	     3	Bastien Guerry
    19	     3	Nicolas Richard
    20	     3	Phil Hagelberg
    21	     3	Thien-Thi Nguyen
    22	     3	Thierry Volpiatto
    23	     3	Thomas Fitzsimmons
    24	     2	Chunyang Xu
    25	     2	Daniel Hackney

Any objections?

[-- Attachment #2: 0001-lisp-emacs-lisp-package.el-Fix-Author-line.patch --]
[-- Type: text/x-diff, Size: 758 bytes --]

From 41fb8f1957d10e6b7021ba4d179a180aefb5838c Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Tue, 17 Nov 2020 13:22:15 +0100
Subject: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.

---
 lisp/emacs-lisp/package.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index d78a1a2856..ba4ef973ff 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2,8 +2,7 @@
 
 ;; Copyright (C) 2007-2020 Free Software Foundation, Inc.
 
-;; Author: Tom Tromey <tromey@redhat.com>
-;;         Daniel Hackney <dan@haxney.org>
+;; Author: Tom Tromey <tom@tromey.com>
 ;; Created: 10 Mar 2007
 ;; Version: 1.1.0
 ;; Keywords: tools
-- 
2.29.2

bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.

[Glenn Morris]

I think for older changes you can't rely on analysis of git output.
Although the change to the author header in a49ff80c24 makes no sense in
isolation, it was probably making up for past changes such as

https://lists.gnu.org/r/emacs-diffs/2013-06/msg00134.html
https://lists.gnu.org/r/emacs-diffs/2013-06/msg00310.html

(I guess ChangeLog attributions weren't accurately mapped to git authors
when the repository was converted.)

See in particular
https://lists.gnu.org/r/emacs-devel/2013-06/msg01101.html

bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.

[Stefan Kangas]

tags 44702 + notabug wontfix
close 44702
thanks

Glenn Morris <rgm@gnu.org> writes:

> I think for older changes you can't rely on analysis of git output.
> Although the change to the author header in a49ff80c24 makes no sense in
> isolation, it was probably making up for past changes such as
>
> https://lists.gnu.org/r/emacs-diffs/2013-06/msg00134.html
> https://lists.gnu.org/r/emacs-diffs/2013-06/msg00310.html
>
> (I guess ChangeLog attributions weren't accurately mapped to git authors
> when the repository was converted.)
>
> See in particular
> https://lists.gnu.org/r/emacs-devel/2013-06/msg01101.html

OK, I was not aware of that.

Sorry about the noise, closing.

bug#44702: [PATCH] ; * lisp/emacs-lisp/package.el: Fix Author line.

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 17 Nov 2020 04:30:45 -0800
> Cc: tom@tromey.com
> 
> I think the "Author" header line in package.el does not accurately
> reflect the contributions to that file.  In particular, I think Tom
> Tromey should be listed as the sole author of package.el, in line with
> our practices and to recognize his contribution.
> 
> Please see the attached patch and compare it the output of the following
> command:
> 
> $ git shortlog -sn -- lisp/emacs-lisp/package.el | cat -n
> 
>      1	   132	Artur Malabarba
>      2	    54	Glenn Morris
>      3	    52	Stefan Monnier
>      4	    46	Chong Yidong
>      5	    40	Paul Eggert
>      6	    23	Stefan Kangas
>      7	    16	Dmitry Gutov
>      8	    11	Lars Ingebrigtsen
>      9	     8	Daiki Ueno
>     10	     8	Juanma Barranquero
>     11	     7	Eli Zaretskii
>     12	     7	Sam Steingold
>     13	     5	Noam Postavsky
>     14	     5	Ted Zlatanov
>     15	     4	John Wiegley
>     16	     4	Pieter van Oostrum
>     17	     3	Basil L. Contovounesios
>     18	     3	Bastien Guerry
>     19	     3	Nicolas Richard
>     20	     3	Phil Hagelberg
>     21	     3	Thien-Thi Nguyen
>     22	     3	Thierry Volpiatto
>     23	     3	Thomas Fitzsimmons
>     24	     2	Chunyang Xu
>     25	     2	Daniel Hackney
> 
> Any objections?

The number of commits doesn't necessarily tell how significant was the
contribution; you need to count the number of added/changed lines
instead.  As an extreme example, the original author who write a
package from scratch and installed it in a single commit will be at
the tail of your list, but that doesn't express correctly the
contribution of that person.