all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Kevin Brubeck Unhammer <unhammer@fsfe.org>
Cc: 44329@debbugs.gnu.org
Subject: bug#44329: 28.0.50; Crash in bidi_mirror_char on view-hello-file when no bidi-display-reordering (harfbuzz)
Date: Fri, 30 Oct 2020 23:29:58 +0000	[thread overview]
Message-ID: <CADwFkmmrJTY71YTq9nu2gX_8h8kgCgh+eZ7xfb=_FL38qW=RMw@mail.gmail.com> (raw)
In-Reply-To: <83361va0og.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> Is there something like make-obsolete-variable for this case that would
>> give a warning in init.el on this variable?
>
> The doc string already does warn.  The variable is not obsolete, it is
> useful for debugging the display code.

It sure would be helpful if the byte-compiler could warn about it
though.  Not sure if we have the facilities for that.

> You assume people who do this read the manual...

Some kind of warning does seem to be warranted, though.  The text now
seems to almost encourage users to set it:

       The buffer-local variable ‘bidi-display-reordering’ controls whether
    text in the buffer is reordered for display.  If its value is non-‘nil’,
    Emacs reorders characters that have right-to-left directionality when
    they are displayed.  The default value is ‘t’.

Should we just remove it from the manual, if it's only useful for
debugging?  Or add a warning similar to the one in the docstring?





  reply	other threads:[~2020-10-30 23:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 14:56 bug#44329: 28.0.50; Crash in bidi_mirror_char on view-hello-file when no bidi-display-reordering (harfbuzz) Kevin Brubeck Unhammer
2020-10-30 15:42 ` Eli Zaretskii
2020-10-30 16:04   ` Stefan Kangas
2020-10-30 20:42   ` Kevin Brubeck Unhammer
2020-10-30 21:01     ` Eli Zaretskii
2020-10-30 23:29       ` Stefan Kangas [this message]
2020-10-31  7:32         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmrJTY71YTq9nu2gX_8h8kgCgh+eZ7xfb=_FL38qW=RMw@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=44329@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=unhammer@fsfe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.