From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Wed, 13 Oct 2021 17:01:13 +0200 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <831r4pp0ms.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26216"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Eli Zaretskii , Stefan Monnier , Emacs developers To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 13 17:02:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mafmN-0006eG-Tb for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 17:02:51 +0200 Original-Received: from localhost ([::1]:33370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mafmL-0000mD-RB for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Oct 2021 11:02:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mafl2-0008K1-Mh for emacs-devel@gnu.org; Wed, 13 Oct 2021 11:01:28 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:36664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mafl0-0001ls-P2; Wed, 13 Oct 2021 11:01:28 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id m26so2726587pff.3; Wed, 13 Oct 2021 08:01:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fEU25ugv3RHue+LA+sKhAMnjT7IzVzo3ZP0ecT78HDI=; b=hJPVEL6PFAhOaNViU9WO92gWoJouvakC6bl6lwd9sqgbibBrwUR3Shxvs6mCpAKBEe JJ8bV3ZEElSQQ1Cocr9JI9PA5mm+96G477M7KHox44jy8xc+8eO+32Z3L7T+hTQbCQzF H5GdUWcQz7XgKL+58ZfFn7hokRJilOLQWVbwfa+e5pdRkFNXK8gDdFm+Ysh+i75lYyBu dh0LPGCOv9ar3NNVoL/lJe3B5Iz6eMIHPcUx0fKoD0In8nwbCQxtJWmfo+jAelIwHVDy +6FHMhcpaobkZlUomjpT4tKiElh80qIWxhjTpIxh4/sAIJA6Pa40yJZcmjO1+1ExPUCx LvuA== X-Gm-Message-State: AOAM533uRiLjws4Q4ZsH4MgLcFYgJeAMJyiPNwrlcwrxK3VNFmxerznG IabwQNMix9lKtjRs3Ylf6XW/YOS41iH1OYnMde8= X-Google-Smtp-Source: ABdhPJziZG0rj0reQW0Bg/76Ilg52iWWbIxeLsWEdJBSt2/2Z/zA1N1pSbXonmMt9u47eOMYK7zIHd+Y1MRcOrRdzFk= X-Received: by 2002:a63:9d06:: with SMTP id i6mr5300728pgd.42.1634137284973; Wed, 13 Oct 2021 08:01:24 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=209.85.210.176; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f176.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276914 Archived-At: T.V Raman writes: > Related: see > https://emacspeak.blogspot.com/2020/10/extracted-light-weight-key-reader-by.html > and some follow-up discussion probably on this list. Thanks, that's useful. I will most likely "borrow" some ideas from your tests for the test suite. There seems to be some opportunities for simplifying the code as well, something that I avoided in my version. Is your 'new-kbd' intended to be bug-for-bug compatible with 'kbd', or have there been any functional changes along the way? Are you suggesting that we could perhaps just replace 'kbd' with your new version? (One observation is that your version still uses the cl- functions, so it would need adjusting for subr.el.)