bug#59138: Eglot support for java-language-server

bug#59138: Eglot support for java-language-server

[Robert Brown]

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]

The attached patch adds Eglot support for Java LSP server
https://github.com/georgewfraser/java-language-server

[-- Attachment #2: 0001-Support-for-java-language-server.patch --]
[-- Type: text/x-patch, Size: 1273 bytes --]

From 8c874c0f277e2e1b85126120da9dcc54e4a938f8 Mon Sep 17 00:00:00 2001
From: Robert Brown <robert.brown@gmail.com>
Date: Tue, 8 Nov 2022 19:23:10 -0500
Subject: [PATCH] Support for java-language-server

 * lisp/progmodes/eglot.el (eglot-server-programs): Add support for
   Java server https://github.com/georgewfraser/java-language-server
---
 lisp/progmodes/eglot.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index ce989b5611..199c832f6b 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -209,7 +209,8 @@ eglot-server-programs
                                 (go-mode . ("gopls"))
                                 ((R-mode ess-r-mode) . ("R" "--slave" "-e"
                                                         "languageserver::run()"))
-                                (java-mode . ("jdtls"))
+                                (java-mode
+                                 . ,(eglot-alternatives '("jdtls" "java-language-server")))
                                 (dart-mode . ("dart" "language-server"
                                               "--client-id" "emacs.eglot-dart"))
                                 (elixir-mode . ("language_server.sh"))
-- 
2.25.1

bug#59138: Eglot support for java-language-server

[Stefan Kangas]

Robert Brown <robert.brown@gmail.com> writes:

> The attached patch adds Eglot support for Java LSP server
> https://github.com/georgewfraser/java-language-server
> From 8c874c0f277e2e1b85126120da9dcc54e4a938f8 Mon Sep 17 00:00:00 2001
> From: Robert Brown <robert.brown@gmail.com>
> Date: Tue, 8 Nov 2022 19:23:10 -0500
> Subject: [PATCH] Support for java-language-server
>
>  * lisp/progmodes/eglot.el (eglot-server-programs): Add support for
>    Java server https://github.com/georgewfraser/java-language-server
> ---
>  lisp/progmodes/eglot.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index ce989b5611..199c832f6b 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -209,7 +209,8 @@ eglot-server-programs
>                                  (go-mode . ("gopls"))
>                                  ((R-mode ess-r-mode) . ("R" "--slave" "-e"
>                                                          "languageserver::run()"))
> -                                (java-mode . ("jdtls"))
> +                                (java-mode
> +                                 . ,(eglot-alternatives '("jdtls" "java-language-server")))

Thanks for the patch.

Is there any particular reason why we should prefer jdtls to
java-language-server?

>                                  (dart-mode . ("dart" "language-server"
>                                                "--client-id" "emacs.eglot-dart"))
>                                  (elixir-mode . ("language_server.sh"))
> --
> 2.25.1

bug#59138: Eglot support for java-language-server

[Stefan Kangas]

[Please use "Reply to all" so that the discussion is recorded in the bug
tracker.]

Robert Brown <robert.brown@gmail.com> writes:

> I don't know what the relative popularity is.  I found j-l-s to be
> easier to compile and configure for environments that are not Maven or
> Gradle.  I think jdtls may have more features.

Thanks, that's good enough for me.

Have you signed the copyright assignment?  I see one previous change
from you, so I'm not sure if this latest patch would take us over the
limit for what we could accept without one.  Eli, any comments?

commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
Author: Robert Brown (tiny change) <robert.brown@gmail.com>
Date:   Thu Jun 19 10:03:45 2014 -0400

    * etc/NEWS: New Tramp method "nc".

    * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New fun.
    (lisp-string-in-doc-position-p): New function, extracted from
    lisp-font-lock-syntactic-face-function.
    (lisp-font-lock-syntactic-face-function): Use them.

    Fixes: debbugs:9130

 etc/NEWS                     |  3 +++
 lisp/ChangeLog               |  7 +++++++
 lisp/emacs-lisp/lisp-mode.el | 64
++++++++++++++++++++++++++++++++++++++--------------------------
 3 files changed, 48 insertions(+), 26 deletions(-)

bug#59138: Eglot support for java-language-server

[Robert Brown]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

Not sure if I have signed a copyright assignment.  Would have been a long
time ago.  My email address would have been @bibliotech.com.


On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas <stefankangas@gmail.com> wrote:

> [Please use "Reply to all" so that the discussion is recorded in the bug
> tracker.]
>
> Robert Brown <robert.brown@gmail.com> writes:
>
> > I don't know what the relative popularity is.  I found j-l-s to be
> > easier to compile and configure for environments that are not Maven or
> > Gradle.  I think jdtls may have more features.
>
> Thanks, that's good enough for me.
>
> Have you signed the copyright assignment?  I see one previous change
> from you, so I'm not sure if this latest patch would take us over the
> limit for what we could accept without one.  Eli, any comments?
>
> commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
> Author: Robert Brown (tiny change) <robert.brown@gmail.com>
> Date:   Thu Jun 19 10:03:45 2014 -0400
>
>     * etc/NEWS: New Tramp method "nc".
>
>     * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New
> fun.
>     (lisp-string-in-doc-position-p): New function, extracted from
>     lisp-font-lock-syntactic-face-function.
>     (lisp-font-lock-syntactic-face-function): Use them.
>
>     Fixes: debbugs:9130
>
>  etc/NEWS                     |  3 +++
>  lisp/ChangeLog               |  7 +++++++
>  lisp/emacs-lisp/lisp-mode.el | 64
> ++++++++++++++++++++++++++++++++++++++--------------------------
>  3 files changed, 48 insertions(+), 26 deletions(-)
>

[-- Attachment #2: Type: text/html, Size: 2212 bytes --]

bug#59138: Eglot support for java-language-server

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]

I can search for that address later in the copyright file. Your very simple
patch can go in regardless, marked as "Copyright-paperwork-exempt: Yes".

João

On Wed, Nov 9, 2022, 16:25 Robert Brown <robert.brown@gmail.com> wrote:

> Not sure if I have signed a copyright assignment.  Would have been a long
> time ago.  My email address would have been @bibliotech.com.
>
>
> On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas <stefankangas@gmail.com>
> wrote:
>
>> [Please use "Reply to all" so that the discussion is recorded in the bug
>> tracker.]
>>
>> Robert Brown <robert.brown@gmail.com> writes:
>>
>> > I don't know what the relative popularity is.  I found j-l-s to be
>> > easier to compile and configure for environments that are not Maven or
>> > Gradle.  I think jdtls may have more features.
>>
>> Thanks, that's good enough for me.
>>
>> Have you signed the copyright assignment?  I see one previous change
>> from you, so I'm not sure if this latest patch would take us over the
>> limit for what we could accept without one.  Eli, any comments?
>>
>> commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
>> Author: Robert Brown (tiny change) <robert.brown@gmail.com>
>> Date:   Thu Jun 19 10:03:45 2014 -0400
>>
>>     * etc/NEWS: New Tramp method "nc".
>>
>>     * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New
>> fun.
>>     (lisp-string-in-doc-position-p): New function, extracted from
>>     lisp-font-lock-syntactic-face-function.
>>     (lisp-font-lock-syntactic-face-function): Use them.
>>
>>     Fixes: debbugs:9130
>>
>>  etc/NEWS                     |  3 +++
>>  lisp/ChangeLog               |  7 +++++++
>>  lisp/emacs-lisp/lisp-mode.el | 64
>> ++++++++++++++++++++++++++++++++++++++--------------------------
>>  3 files changed, 48 insertions(+), 26 deletions(-)
>>
>

[-- Attachment #2: Type: text/html, Size: 2850 bytes --]

bug#59138: Eglot support for java-language-server

[Eli Zaretskii]

> Cc: 59138@debbugs.gnu.org,
>  João Távora <joaotavora@gmail.com>
> From: Robert Brown <robert.brown@gmail.com>
> Date: Wed, 9 Nov 2022 11:25:40 -0500
> 
> Not sure if I have signed a copyright assignment.  Would have been a long time ago.  My email address
> would have been @bibliotech.com.

I see an old disclaimer for you, but without any email address, and
only for a single source file.

I think it is best to start the assignment process now, if it's okay
with you.  If instead you'd like first to find out what is the status
of that old disclaimer, please write to Craig Topham
<copyright-clerk@fsf.org> and ask him.

Thanks.

bug#59138: Eglot support for java-language-server

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 59138@debbugs.gnu.org,
>>  João Távora <joaotavora@gmail.com>
>> From: Robert Brown <robert.brown@gmail.com>
>> Date: Wed, 9 Nov 2022 11:25:40 -0500
>>
>> Not sure if I have signed a copyright assignment.  Would have been a long time ago.  My email address
>> would have been @bibliotech.com.
>
> I see an old disclaimer for you, but without any email address, and
> only for a single source file.
>
> I think it is best to start the assignment process now, if it's okay
> with you.  If instead you'd like first to find out what is the status
> of that old disclaimer, please write to Craig Topham
> <copyright-clerk@fsf.org> and ask him.

That was two weeks ago.  Robert, what do you think?

bug#59138: Eglot support for java-language-server

[Robert Brown]

Please forward copyright assignment forms to me or send me a pointer
to the specific agreement you'd like me to sign.
Thanks!

On Fri, Nov 25, 2022 at 3:15 AM Stefan Kangas <stefankangas@gmail.com> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Cc: 59138@debbugs.gnu.org,
> >>  João Távora <joaotavora@gmail.com>
> >> From: Robert Brown <robert.brown@gmail.com>
> >> Date: Wed, 9 Nov 2022 11:25:40 -0500
> >>
> >> Not sure if I have signed a copyright assignment.  Would have been a long time ago.  My email address
> >> would have been @bibliotech.com.
> >
> > I see an old disclaimer for you, but without any email address, and
> > only for a single source file.
> >
> > I think it is best to start the assignment process now, if it's okay
> > with you.  If instead you'd like first to find out what is the status
> > of that old disclaimer, please write to Craig Topham
> > <copyright-clerk@fsf.org> and ask him.
>
> That was two weeks ago.  Robert, what do you think?

bug#59138: Eglot support for java-language-server

[Stefan Kangas]

Robert Brown <robert.brown@gmail.com> writes:

> Please forward copyright assignment forms to me or send me a pointer
> to the specific agreement you'd like me to sign.
> Thanks!

Great!  See below.


Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]