From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65039: 30.0.50; [PATCH] Add bookmark handler for M-x shell Date: Sun, 3 Sep 2023 04:15:57 -0700 Message-ID: References: <877cqcw5m0.fsf@protesilaos.com> <83zg38w25c.fsf@gnu.org> <87y1ir2mko.fsf@protesilaos.com> <834jlfw116.fsf@gnu.org> <871qgisxz0.fsf@protesilaos.com> <83bkflu9ti.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17853"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , 65039@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 13:17:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcl6I-0004QV-0y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 13:17:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcl64-0005Rk-V2; Sun, 03 Sep 2023 07:16:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcl64-0005RJ-7A for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:16:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcl63-0000Ek-VB for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:16:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcl6D-0001BG-W9 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 11:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65039-submit@debbugs.gnu.org id=B65039.16937397804459 (code B ref 65039); Sun, 03 Sep 2023 11:17:01 +0000 Original-Received: (at 65039) by debbugs.gnu.org; 3 Sep 2023 11:16:20 +0000 Original-Received: from localhost ([127.0.0.1]:39806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcl5X-00019r-Tq for submit@debbugs.gnu.org; Sun, 03 Sep 2023 07:16:20 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:49369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcl5S-00019F-ON for 65039@debbugs.gnu.org; Sun, 03 Sep 2023 07:16:18 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-500b6456c7eso1014979e87.2 for <65039@debbugs.gnu.org>; Sun, 03 Sep 2023 04:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693739758; x=1694344558; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=1+TDyWq6kgWxWtKoDSWSqhFh/KFkREDHZVW+x8kI/GM=; b=PesRvyb5aU2TRaj8rxnYKTtll8h6PT3sLJQsDJpWDAcXUgY2ssLrDaUo7nhA6n3khj znoOtKJLWY34kUYjPol7kesogOaO94FFHev4/0nolSXva1ZMli3LsR1KmqNFBPbEyYIe iZS9bIfIhw1UZJTIBq6YWE7kwE7xvubEBHg24H+p9i+sbDhmhrTHWHxJji2nAmDFpLNP 4zXHpLqr1wJsyJ6AQ65lj0Yrx3HB9LqcG169DNCwnOzj+AHGkS0OfbD7kVl3zQAh6Ja8 JPtXKUWuQ2whwadzPGZ7w6D4jXlohJLJJUQ6XYPY5B3pO9zVKOs+uz/o1pyWEXebzAsD KDyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693739758; x=1694344558; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1+TDyWq6kgWxWtKoDSWSqhFh/KFkREDHZVW+x8kI/GM=; b=QSM9KJ/xVrPUFCCOlk21U5nslh4igfgbn8InZPh0GNY3cEsNqIuu3e9yPve0KRbwNb vUllufGvaClAN1x0QUZFl26d8dLqWGZbBZ/3g9b0oi4t3Ck9fU4no0w36Y7QKoAjMSN5 350ohQJ4EUhYdFyr6L8pJKrN+Dh6xbb1AiMdqJcsDNIvnm5W1zYCDA29OvNRVBxc5bdX U1Lzpy8pOWNwK4hftcLBN30C5/CUV43zNTMpr15yOEgE1Wnxr55UWBEM7o84XNevhZZd OHNUcLQlo2NSSJbScDCp4H91imy/2OaUF+NgfZQspfD4JQ1OYZWZnx9HWskrZ4pzCbDu 8r1w== X-Gm-Message-State: AOJu0YzBLQqWOGwFNA9kD2mXvCSdZ4t3q6/9nnTREGBk0q1wS7uWgkr8 SguplUjzoDys4Lw3hTUSLSwP33DCtz6XGfPlj6cG6//eZp0= X-Google-Smtp-Source: AGHT+IHSFhlA5DNrzkyBYzvMHDoPuhS1vP1SDNFcVlix46cqULQLVAQilDkcgFVCnizzww1em8dSQGH/hU/OZgOB4zw= X-Received: by 2002:a05:6512:39d3:b0:4fb:893e:8ffc with SMTP id k19-20020a05651239d300b004fb893e8ffcmr5577385lfu.17.1693739758293; Sun, 03 Sep 2023 04:15:58 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 04:15:57 -0700 In-Reply-To: <83bkflu9ti.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 12:18:01 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269146 Archived-At: Eli Zaretskii writes: >> From: Protesilaos Stavrou >> Cc: 65039@debbugs.gnu.org >> Date: Fri, 04 Aug 2023 17:06:59 +0300 >> >> > From: Eli Zaretskii >> > Date: Fri, 4 Aug 2023 13:32:37 +0300 >> > >> >> From: Protesilaos Stavrou >> >> Cc: 65039@debbugs.gnu.org >> >> Date: Fri, 04 Aug 2023 12:17:43 +0300 >> >> >> >> > I'll let users of bookmarks comment, but in any case, please also >> >> > check that the section "Bookmarks" in the Emacs user manual doesn't >> >> > need some update due to this feature. (You marked the NEWS entry w= ith >> >> > "---", which might mean you already checked that, but I'm not sure.= ) >> >> >> >> I thought a change was not necessary. Though I am happy to do it, if >> >> needed. >> > >> > It sounds like the notion of "jumping" to a bookmark has evolved, and >> > nowadays jumping to a bookmark might do much more than just jump to a >> > buffer position. Perhaps that node in the manual should say something >> > about that, and show a couple of examples? >> >> The revised patch includes a possible update to the manual. Are those >> examples sufficient? > > I guess so, thanks. Just to let you know, I had an issue with applying the patch, and had to manually edit it: 1 git =E2=80=A6 am --3way -- ~/wip/emacs/0001-Add-bookmark-handler-for-M-= x-shell.patch Line longer than 78 characters in commit message Commit aborted; please see the file CONTRIBUTE Also, when the bug number is known, it is good if you can include it somewhere in the commit message. I was going to review and install this patch, but I noticed that there was some further discussion in a subthread regarding some Tramp stuff? Should that be resolved first, or is this ready as-is?