From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list Date: Fri, 28 Oct 2022 12:45:58 -0700 Message-ID: References: <166668943749.31970.9379739764487638921@vcs2.savannah.gnu.org> <20221025091717.DD9A3C0E4BF@vcs2.savannah.gnu.org> <834jvold15.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9849"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org To: Eli Zaretskii , rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 21:46:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooVJU-0002MS-G2 for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 21:46:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooVIs-0006im-Db; Fri, 28 Oct 2022 15:46:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooVIp-0006iQ-TU for emacs-devel@gnu.org; Fri, 28 Oct 2022 15:46:04 -0400 Original-Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooVIn-0007bw-Fe; Fri, 28 Oct 2022 15:46:02 -0400 Original-Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-13c569e5ff5so7048154fac.6; Fri, 28 Oct 2022 12:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=FKeypMEw4i1jo3feWL4LEhab7Z3TpZ+NJRjeRv0F82s=; b=MBWbU78Lx7yXFxpIIYsXGmXknSvTkMBlT3zKX5O+U2yF0q2uBxea4lq6FDdzxnZTgZ nYlO1iPBteEvHHHzW8+Y9IYaaFqNXGPAzyTp4ecUoaBLUG6yXHbjoMYlg+kUKfBFMqIf HD/dg8V/PPdH6/SZX2EpFPsLIXi6PH8Ln9+IWumDPsN1ZsJEiw96n84qSU0UXIsW2QnO MlZwAik8iV001fhmZ7Iq5FK71/8uNc+9XuI8rEwmpAJ4Qmm+g7Ur82QhEzQHT5KXV+np qaHW96QvMyEN8uzSKt7tRVIFLK+rSxdvcwsvT8cJzhZf21FbKZywlmEb/3qNdp5kH5XW qUnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FKeypMEw4i1jo3feWL4LEhab7Z3TpZ+NJRjeRv0F82s=; b=MGDUJGPudFL4rBTxY9V4KMtgefcVI2ippyBhE6iOWsh7PjjPcMkgtwS/bwhOXPrBNq y2aDOSPov+3qwLV7d62ltM9FuiMjd584rSgybpRdZ2e/288tSLnSK4+/qr76zOIduRsP B+3U6eYG4RMRBP8TgM04qjqrQB+B9gOFYiuw6SxxL9drdl27NB1DWk3JKtRUg9kZiQ+b NFqgJWYadNy3RunRRzUE+JGm/82ANm/CXZfR5BRvcHzYYam2B9n9MIHckdz1Hgx81WhQ YqT2aRO5AHDtpf88LJxEXTk5Sa3w6AxcIutCyorg4Wj6NDEAmlk7NQqCIpqBz2yDXglW GM3g== X-Gm-Message-State: ACrzQf1kLhXpeUZYHOJ81vZzatGlWqBS53zH2ESamPxeVMxzLz9W0sqQ MNEOU0yWJITpwa0T8JThJh+RbFPpO0SOrUdfOy7UjKR6 X-Google-Smtp-Source: AMsMyM61DhSsSnMoy+zVn/a7+B1TXs+NNKluD1aKcD7deTbQbmdBVG4HhQIvR3fZev9yXIxuXyeAWotTzMGsokkalQI= X-Received: by 2002:a05:6870:c0d5:b0:13a:fb98:713d with SMTP id e21-20020a056870c0d500b0013afb98713dmr10065030oad.199.1666986359500; Fri, 28 Oct 2022 12:45:59 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Oct 2022 12:45:58 -0700 In-Reply-To: <834jvold15.fsf@gnu.org> X-Hashcash: 1:20:221028:joaotavora@gmail.com::5a93285naMC6I9BK:6HnF Received-SPF: pass client-ip=2001:4860:4864:20::2e; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298695 Archived-At: Eli Zaretskii writes: > Our project-wide preference is the other way around: we ask > contributors not to make any whitespace changes except where they > actually change code, or nearby. AFAIK, the reasons not to do cosmetic whitespace changes is that they make history harder to read, and merging harder. However, any reasonably modern VCS will have an option to ignore whitespace changes (Git does). And a lot of code in Emacs change very infrequently. At the same time, whitespace changes can in some cases make the structure of code clearer, and thereby easier to understand. I therefore think we could relax our project-wide policy along the lines of what Richard and Jo=C3=A3o suggest.