From: Stefan Kangas <stefankangas@gmail.com>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>, 73552@debbugs.gnu.org
Cc: "Gerd Möllmann" <gerd.moellmann@gmail.com>,
"Eli Zaretskii" <eliz@gnu.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>
Subject: bug#73552: obsolete (and broken) face attribute :reverse-video
Date: Sun, 29 Sep 2024 06:55:19 -0700 [thread overview]
Message-ID: <CADwFkmmmCbnTqYZbDypGS+rHsK8RayvydJH=NN4Lphqx2Jp2kg@mail.gmail.com> (raw)
In-Reply-To: <A9CA266B-0029-4B69-B3D4-1E5ECE0D6DEB@gmail.com>
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> I first blamed a simple 14 years old mistake in `custom-fix-face-spec`
> but fixing that doesn't help, not sure why. But it means that we
> probably don't need to fix it, and indeed there are precious few
> packages using :reverse-video. One is make-mode.el; outside Emacs, I
> only found one (yaml-mode).
I suggest fixing this in make-mode.el to avoid the warning.
> While :bold and :italic are obsolete as well, they are used a lot more
> (and actually seem to work) so I'm not warning about them now.
We could start by doing s/:bold t/:weight bold/ and
s/:italic t/:slant italic/ in our tree.
> To summarise:
> - Should we fix `custom-fix-face-spec`? Maybe, or just stop pretending that it handles :reverse-video.
> - Should we bother to fix what other mechanism preventing :reverse-video from working? Probably no.
> - Should we remove :reverse-video from the display machinery? Yes, but maybe not now?
It doesn't seem worth fixing :reverse-video at this point, indeed.
I suggest removing it, given that it's been broken for so long and that
we now have a warning instead.
> - Should we remove :bold and :italic? Yes, but definitely not now.
I'd propose adding obsoletion warnings for :bold and :italic. I note
that they are not documented in the elisp manual.
next prev parent reply other threads:[~2024-09-29 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 10:49 bug#73552: obsolete (and broken) face attribute :reverse-video Mattias Engdegård
2024-09-29 11:31 ` Gerd Möllmann
2024-09-29 12:35 ` Mattias Engdegård
2024-09-29 12:55 ` Eli Zaretskii
2024-09-29 13:41 ` Mattias Engdegård
2024-09-29 13:49 ` Eli Zaretskii
2024-09-29 13:55 ` Stefan Kangas [this message]
2024-09-29 16:22 ` Mattias Engdegård
2024-09-29 16:42 ` Eli Zaretskii
2024-09-29 17:25 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmmCbnTqYZbDypGS+rHsK8RayvydJH=NN4Lphqx2Jp2kg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=73552@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.