From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59214: [PATCH] Alternate rust-analyzer command added Date: Wed, 16 Nov 2022 16:12:41 -0800 Message-ID: References: <87o7tc2xu8.fsf@codeisgreat.org> <83leoag78l.fsf@gnu.org> <83fseig0h0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59214@debbugs.gnu.org, pankaj@codeisgreat.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 17 01:13:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovSX9-0004wr-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Nov 2022 01:13:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovSWe-0004OE-LS; Wed, 16 Nov 2022 19:13:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovSWc-0004K2-LK for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 19:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovSWc-0003BZ-DJ for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 19:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovSWc-0000Mt-96 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 19:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 00:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59214 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59214-submit@debbugs.gnu.org id=B59214.16686439731401 (code B ref 59214); Thu, 17 Nov 2022 00:13:02 +0000 Original-Received: (at 59214) by debbugs.gnu.org; 17 Nov 2022 00:12:53 +0000 Original-Received: from localhost ([127.0.0.1]:58502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovSWT-0000MX-6l for submit@debbugs.gnu.org; Wed, 16 Nov 2022 19:12:53 -0500 Original-Received: from mail-ot1-f52.google.com ([209.85.210.52]:39692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovSWN-0000M4-ME for 59214@debbugs.gnu.org; Wed, 16 Nov 2022 19:12:51 -0500 Original-Received: by mail-ot1-f52.google.com with SMTP id g51-20020a9d12b6000000b0066dbea0d203so105984otg.6 for <59214@debbugs.gnu.org>; Wed, 16 Nov 2022 16:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=aGLIbSkL70nlcrrXFjxHc8hqFWozaiK3cr4Pvn6BSGM=; b=fD60CPL+OMPWsgO64mAGF40rRuahllrGHyQcgYBxlRlNqjpAP2O1X/v48539j3TS6B QedSfn42rksw5VVcdyzFygJlFQRWGvDGxo4SP6UC6h3981dFg6PFR9eRlPKlXXRp2qUk ecS+3c41MfrzlQIkAUFYJK7fx/YlCbXHzHA5THKc6iGWUSvWdlHt/yzfvyezLt5e7zur Y2qKfNA0cf+e9uQRjyv2rgw6/UO/Oq3TIiH5BcQ2PCbGDRA4igeWg9P0am3md1/Xzldx XdsPtAvRN5SyK9PzLAVECJLQjkDRjaaUax8WvlZkbkYJpokxWezAWFlJNhTwagq9FAHE cL6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aGLIbSkL70nlcrrXFjxHc8hqFWozaiK3cr4Pvn6BSGM=; b=ycDkWwrl3szTqTZI8poiarr0OCEn6zRpv9esnKdgVz8DCAVdNK2S1V6ul+kr28iHWS knC+0TlJGFCmq+de2WBbcDPV15mo/qISZwu2ehE/vA1n0hfSF4X8eceJjeKiieklRSmq OQo8uHfmjXu5QVjzWoiYrHLeJoAfROoXP2Wq0/RDCU2PN3Xl0lVLzOmvOqacaLwOK4Om MNaAK59low3Qxmnu1fx+nWRSFIXhpLyt7u9L9l2TinF+bdJjm4A9+y6JpzSNSwmB9xLe J6s+027QmEXLPgerCT+Hz2jZRewIB6NWrIIZaa6kT9NU3IyypOBFyL+HTxxyC0+KF4FC px/g== X-Gm-Message-State: ANoB5pm5JDGA2HDaz1cFHKw9bJGErOVm67UR6H0oIO9J9LCMJwjr/GAF gAQvbAZmKcZxbUQQ4jrKxYnrDCJ+3O0Hf4sSRfE= X-Google-Smtp-Source: AA0mqf4bu4w0rmOZjL3HvthA5vK0YYnxSfNPXl7LFTk7AXZSUg/2mH7lntMhvrxT1sGCiGDdNPEKhmAyB9apxFYtwQ4= X-Received: by 2002:a9d:70cc:0:b0:66c:5232:b9d1 with SMTP id w12-20020a9d70cc000000b0066c5232b9d1mr272113otj.224.1668643962165; Wed, 16 Nov 2022 16:12:42 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 16 Nov 2022 16:12:41 -0800 In-Reply-To: X-Hashcash: 1:20:221116:pankaj@codeisgreat.org::PGgU9Rfy7vbhf3A+:4gC9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248058 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > After thinking about it some more, I think this case is comparable to > ensuring 'serverx' is available in PATH/exec-path, which is something > that we already ask users to do (not only for LSP servers). So I'd say > don't change the value. The difference is that rust-analyzer itself recommends using the rustup invocation as an alternative to adding the language server to PATH.[1] I also don't see any downside to adding it. The variable will get a tiny bit uglier perhaps, but the benefit is that a real hurdle will be eliminated for users. That's a win in my book. Footnotes: [1] https://rust-analyzer.github.io/manual.html#rustup