From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#52518: Log only vc-command-messages Date: Wed, 15 Dec 2021 14:02:32 -0800 Message-ID: References: <86zgp1zsf8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11772"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52518@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 15 23:03:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxcMq-0002uO-QL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 23:03:20 +0100 Original-Received: from localhost ([::1]:41602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxcMo-0001bx-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 17:03:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxcMY-0001bF-8w for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 17:03:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxcMY-0006dr-07 for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 17:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxcMX-00078a-PY for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 17:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 22:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52518-submit@debbugs.gnu.org id=B52518.163960576127407 (code B ref 52518); Wed, 15 Dec 2021 22:03:01 +0000 Original-Received: (at 52518) by debbugs.gnu.org; 15 Dec 2021 22:02:41 +0000 Original-Received: from localhost ([127.0.0.1]:33887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxcMC-00077y-Kw for submit@debbugs.gnu.org; Wed, 15 Dec 2021 17:02:40 -0500 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:47073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxcMB-00077Y-5a for 52518@debbugs.gnu.org; Wed, 15 Dec 2021 17:02:39 -0500 Original-Received: by mail-pf1-f176.google.com with SMTP id o4so21836929pfp.13 for <52518@debbugs.gnu.org>; Wed, 15 Dec 2021 14:02:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=9KTMDkr4ptT4A/Lgbj435U2573THcRW2E6aJBw1kQtM=; b=VZPWPRfuSN84g3as9G9mhYz99KYNdngyBCaUicw0E2wvZQ5PBoafBV0LxN3rewfTFf S9MZewTNbzunWgC6qLQQpzeYkIFvg6aUf9ob8P5q0eFcjuEy8UoEWT8oJkkkw07qimjM F1Yd+nqj/iRCUPvj2z5xPNgz4hMdFevQNjDQeo/FEtMZ7reGjP9W0A/rCbUrHn0wf3Wb 8aDPO+kCtQvLoNVEx7bG+QgreatRI2vwghb3K7I9qjnNKQvAZ83enAFMmMB3Aa2IJqYp 3v0UwTtlpzCtOVMOb54FvWGDmFrQrfKu4K85bpk36ijVgi8Kzk8EJDF4+YkghmO+x3xa 2RwA== X-Gm-Message-State: AOAM532O446K06MXKubX7P8jK1D2hdo8lt/NxFFWq6K7pIFuNPaagYE7 Wnnpm4XeHaZXCBvf5pR44jMzt/LIgVjczltIFivx7ZL+ X-Google-Smtp-Source: ABdhPJwJOE0e7IckbIeOpnywx+UdzKgfcjYHVL7PcFCmYwUg4xsYPPMy0cMXVzpMbjgNyPnmqIhlyRY6DrhQw4In0QQ= X-Received: by 2002:a62:1a03:0:b0:494:64b5:3e01 with SMTP id a3-20020a621a03000000b0049464b53e01mr10918514pfa.35.1639605753265; Wed, 15 Dec 2021 14:02:33 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 15 Dec 2021 14:02:32 -0800 In-Reply-To: <86zgp1zsf8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 15 Dec 2021 19:31:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222454 Archived-At: Juri Linkov writes: > It's useful to customize vc-command-messages to t > to be able to inspect the performed vc commands > in the *Messages* buffer. When something goes wrong, > it's clearly visible what command caused the problem. > > But displaying such all vc commands in the echo area > causes too much noise. Here is an option to not > display such messages, only log in the *Messages* buffer: Good idea. > (when vc-command-messages > - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (let ((inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) > (message "Running in background: %s" full-command))) > ;; Get rid of the default message insertion, in case we don't > ;; set a sentinel explicitly. > @@ -345,11 +351,15 @@ vc-do-command > (when vc-command-messages > (vc-run-delayed > (let ((message-truncate-lines t) > - (inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) > (message "Done in background: %s" full-command))))) > ;; Run synchronously > (when vc-command-messages > - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (let ((inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) > (message "Running in foreground: %s" full-command))) > (let ((buffer-undo-list t)) > (setq status (apply #'process-file command nil t nil squeezed))) > @@ -364,7 +374,9 @@ vc-do-command > (if (integerp status) (format "status %d" status) status) > full-command)) > (when vc-command-messages > - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) > + (let ((inhibit-message > + (or (eq vc-command-messages 'log) > + (eq (selected-window) (active-minibuffer-window))))) Should these be refactored into a function of their own? It seems a tad repetitive as is.