From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#16374: password not hidden in shell when mounting cifs partition Date: Sun, 6 Oct 2019 03:40:21 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71537"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 16374@debbugs.gnu.org To: Tyler Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 06 03:41:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGvXr-000ITE-0J for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Oct 2019 03:41:11 +0200 Original-Received: from localhost ([::1]:59714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGvXp-0004WA-B6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Oct 2019 21:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39982) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGvXj-0004Vs-O5 for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 21:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGvXi-0005hY-PX for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 21:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGvXi-0005hR-Mg for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 21:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iGvXi-0003GY-Gm for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2019 21:41:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Oct 2019 01:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16374 X-GNU-PR-Package: emacs Original-Received: via spool by 16374-submit@debbugs.gnu.org id=B16374.157032604112515 (code B ref 16374); Sun, 06 Oct 2019 01:41:02 +0000 Original-Received: (at 16374) by debbugs.gnu.org; 6 Oct 2019 01:40:41 +0000 Original-Received: from localhost ([127.0.0.1]:45400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGvXM-0003Fm-7C for submit@debbugs.gnu.org; Sat, 05 Oct 2019 21:40:40 -0400 Original-Received: from mail-pg1-f180.google.com ([209.85.215.180]:38562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGvXK-0003FZ-72 for 16374@debbugs.gnu.org; Sat, 05 Oct 2019 21:40:38 -0400 Original-Received: by mail-pg1-f180.google.com with SMTP id x10so5983815pgi.5 for <16374@debbugs.gnu.org>; Sat, 05 Oct 2019 18:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=IAXc62XWcWt9rhwupb+jU8i0G1tXATodf9imuxWzzDA=; b=eStwHHYPnBDAJODEhY1y7b8ikeqhdFFzaHTnkgP5w2gz9ECuA3+rN/JvYiXJa68g77 bSdSQS42+ub+JVT6cV0UMau/KJJ58J3Q8YW+AEdHbzK36Kbnz+vbZh5y4hcABVe4LC4q BFwvUWaFLpn7j4rNBOmzkggnUAPuxthQc1L76q9oL9Ompui98MXdm1cIJ2z4wAUrLi/z XOqlMWSr4FhJrMYK5m6zV9nmZSaQzq516ecVk5KG07+6sq2/m+lRMo87+Tkl8eW3lkQb pWWodbcmgwRiXSzRP51VAQXdPD6Sd2qermlkzyKXkXEON+q/J1XAIucliSy0kyUWdzxI j2fg== X-Gm-Message-State: APjAAAXFWj/bxJzoTbTtF6/QsYc7WzbLhOqxDJQHOws4N7IvV1JtwRA/ fJ93FYaYPxrF1pqAifR6ituQcjghQ+88fn0XhXIRTQ5m X-Google-Smtp-Source: APXvYqwsx1DTihzg9mrG5MFGmXpi+VvScvPbv1/POs3XnjV7BhEhF36a2fkebUPfosMduvNpaUihwaU9/GXGRZrjkPY= X-Received: by 2002:a65:5802:: with SMTP id g2mr24517551pgr.333.1570326032406; Sat, 05 Oct 2019 18:40:32 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168407 Archived-At: Tyler Smith writes: > I'm not sure if this is really an Emacs bug, or just a limitation of *shell* > > Starting from emacs -Q: > M-x shell > mount ./network-drive > ;; (fstab for this drive is: > ///$/ /home/user/network-drive cifs > noauto,users,user=,uid= username>,rw 0 0 > ;; ) > > ;; I am now prompted for my network password. When I enter it and press > ;; return I see this: > Password for @///$/: plain text> > ******** > > The point is, the asterisks should be appearing in place of my actual > password. Instead, they appear in addition to my password. > > Thanks for your time, > > Tyler > > In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.8.6) > of 2013-12-31 on ONOTTAR654746 Hi Tyler, Thanks for the bug report. Sorry that it went unanswered for so long. When I try the following on Emacs 26.1, I get no error: (progn (require 'comint) (string-match comint-password-prompt-regexp "Password for foo@//example.org/foo/bar$/: ")) This suggests to me that a prompt such as the above should work under M-x shell, since that is built on top of comint. Could you verify that this works for you on Emacs 26.1? Could you also please tell me if: "Password for foo@//example.org/foo/bar$/: " is a good example of the kind of prompt you get when mounting a cifs partition? (I'm trying to find a good example to add to the test suite for comint-password-prompt-regexp.) Best regards, Stefan Kangas