From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master d0a66f3e0e: Display a warning for some uses of nil in face attributes. Date: Sun, 27 Nov 2022 10:20:05 -0800 Message-ID: References: <166215065969.27647.10737851450469499017@vcs2.savannah.gnu.org> <20220902203100.0C8D8C0088A@vcs2.savannah.gnu.org> <3d2972a5f544f212c6c6@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 27 19:20:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozMGr-000AAB-7R for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Nov 2022 19:20:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozMGH-0008LW-IV; Sun, 27 Nov 2022 13:20:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozMG9-0008Ku-RU for emacs-devel@gnu.org; Sun, 27 Nov 2022 13:20:10 -0500 Original-Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozMG7-0000h7-IQ for emacs-devel@gnu.org; Sun, 27 Nov 2022 13:20:08 -0500 Original-Received: by mail-ot1-x331.google.com with SMTP id p10-20020a9d76ca000000b0066d6c6bce58so5643710otl.7 for ; Sun, 27 Nov 2022 10:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=g7X1x33ErcLmguQ4WINnIdumn2dIAkpl2f8zC3p24Sw=; b=fxNSh87WXraD/EJOL81RjQ/qSaknnAcy4CXSJZGg1k/2/idJyqTeoYdrijNlv4G/DW CQ1556ivgL1PB+0qvo6yqTciFas997b3S2aN5vWQ9+0TXkuHwJYfe02INoRdJdJTQam2 UTithxHbCgILABk24I3uKJiIrVJJv7zW6GPbZdM72hrpeTHlPcIPMjwaU5RMub0rCSTv 0GiEkGF58df0dhDT51fzvyc9sgQg9+ujKe76xiDqb/qPVOtnCX3l2pH7DouNnOkJzNug JhFj+A0hnLZUFNKROS0yVU7WP0ZWMCFFXKmQeZfz7XGPHp4YCfKwD9Gx7oZp+pefnYnM sQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g7X1x33ErcLmguQ4WINnIdumn2dIAkpl2f8zC3p24Sw=; b=sAk74bRG61jtpPXMAbIZX2yrfR4CreUzt5rZAoiX/LgcorLTH0h0XUrgW3kpvCnspO bdyNEUZWPtMxyr+saa8gC1xAPzZ+zWKsDCKBjYd4vEQSpQ8k7eBi638gB9ROFRrgdmuZ Ugdq6iXWJ7hE1D72kHT3DwI0Ff9h4L4ptpdgO919mlUF+3KWz92+YXnHDsk+glMOaG5j SRYKw4hu6+Ywq4bXMcQwmtbVayTT0fCRpb6nifm1na6RETpwFoq3WIkMdT5pjKcFllj+ ihTtsNkV6/0S4ItacNr17z4melg4vXn+BuIUCroIkJLbIWka3wd8LP4oUJT7i66FfC0b UcjA== X-Gm-Message-State: ANoB5pkacJvAc669LdrZs0FLQKTXzUWGRxx1FTN50x1ZUkFIbAAbqNQf 0FKg4/aqC2mh4PkrjMxoYPkHYB+CwP40eR3A5hZZ2DW74Z0= X-Google-Smtp-Source: AA0mqf6b/fU39pgqZFjafa50hgXV8ZgKBDFws4BGm9Ay0ttgeE5E1AgzSzarOZ1M8jyd1w6HU0cTGTouOvBIs8JjsoQ= X-Received: by 2002:a9d:70cc:0:b0:66c:5232:b9d1 with SMTP id w12-20020a9d70cc000000b0066c5232b9d1mr13550728otj.224.1669573206281; Sun, 27 Nov 2022 10:20:06 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 27 Nov 2022 10:20:05 -0800 In-Reply-To: <3d2972a5f544f212c6c6@heytings.org> X-Hashcash: 1:20:221127:emacs-devel@gnu.org::6MYp95YhvWNO14j6:0VAX Received-SPF: pass client-ip=2607:f8b0:4864:20::331; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300637 Archived-At: Gregory Heytings writes: > It's not a macro for performance reasons, it's a macro because it didn't > seem worth to me to make it a function. I don't follow your reasoning here. I would make it into a function unless there is some specific reason to make it into a macro.