From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 2e090da: Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. Date: Mon, 26 Oct 2020 17:58:12 -0700 Message-ID: References: <20201025101403.1168.4440@vcs0.savannah.gnu.org> <20201025101404.7EBE2204DA@vcs0.savannah.gnu.org> <87d015jp2t.fsf@hajtower> <87mu08wyjo.fsf@hajtower> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10283"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Stefan Monnier , Emacs developers To: =?UTF-8?B?SGFyYWxkIErDtnJn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 27 01:59:21 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXDKb-0002a7-2O for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Oct 2020 01:59:21 +0100 Original-Received: from localhost ([::1]:35428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXDKY-00029a-Vu for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Oct 2020 20:59:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXDJY-0001fp-QH for emacs-devel@gnu.org; Mon, 26 Oct 2020 20:58:16 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:38954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXDJX-000237-3K for emacs-devel@gnu.org; Mon, 26 Oct 2020 20:58:16 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id bn26so613189ejb.6 for ; Mon, 26 Oct 2020 17:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=fM1bDio9XqbnF+90xoF7WfCHNmUz53FsjV14MFlXdVU=; b=QdBBEGPQwXGHRHbBP0tZ3KW1ZEPcCTMY5S/unIjDqo42FibxNSZziljQEaExeEHdCk 8DUPjoSY0FnAedgNiRiWYIVNBHg/JASEID1dkNwK2YpIK2FHsx9Fw9ALFgo5LNMCSwuJ Lr+fhJR/9Op03YPPo+o8jRnvWBcQJH2lh1cjLZCg9TpMF1C1bzkOYJLFDOp4iX43XE/o xj0CpeeNtABSDtnj6JXDgCyC0LhaM14fmj7RRD0c22jAY6V5WNNk8621dtqTTyqyckRj 2tIOs92wxCJVw41j6UJdo+QQhZ1BSUsJUjKFlWAyRnvJjefGluBUxjjAn79BRwuOwOVj gHYw== X-Gm-Message-State: AOAM532F0chnPu10kpZzZ/51j1vutZTtzzQtyYQ6KWgeOkX64PjTk/Cw FY1X8HzxFXRlTLTrdMj/qakedI0AlvMWteAA6kM= X-Google-Smtp-Source: ABdhPJzyecd70YvHPNJSymX8HwFpRIFnQc48i1tzpi8R8eiwKEvzf7eSAQjB5x4j0I/aXSZxgq1aImNQKlrug0ukims= X-Received: by 2002:a17:906:1246:: with SMTP id u6mr18385372eja.432.1603760292805; Mon, 26 Oct 2020 17:58:12 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 26 Oct 2020 17:58:12 -0700 In-Reply-To: <87mu08wyjo.fsf@hajtower> Received-SPF: pass client-ip=209.85.218.54; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f54.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 20:58:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258486 Archived-At: haj@posteo.de (Harald J=C3=B6rg) writes: >>> Could such an ert-backport.el be a candidate for ELPA? It should be >>> useful for all dual-life (Emacs + ELPA) packages. >> >> How about just making ert itself into a GNU ELPA core package? > > I'd be happy with that. > > ert.el would then need to implement some compatibility features itself: > It uses the new format-prompt, for example, which can be easily covered. > It also uses backtrace.el, which doesn't exist in Emacs 26. > backtrace.el, in turn, needs lisp-el-font-lock-keywords-for-backtraces, > which has been added to lisp-mode.el (in the same commit e09120d6 where > backtrace.el was created). I didn't dig any further, but I guess > there's some effort to unravel all of this. > > Maybe it would make sense to _start_ this as a long-term goal right now, > working for versions 28 and beyond? That would make ert-backport.el a > temporary workaround, to be eliminated as soon as versions below 28 go > out of scope. Given the amount of work involved (full disclosure: more than I expected), it sounds like your compatibility package is probably the better choice for now. We can think about making ert into a package in its own right in the future, if we need or want to. Making ert-backport.el into a GNU ELPA package sounds good to me. But let's see if anyone else has any comments. Thanks for working on this.