From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#56552: [PATCH] Make gnus display webp images inline Date: Thu, 14 Jul 2022 06:42:44 -0700 Message-ID: References: <87mtdbswl2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36534"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56552@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 14 15:47:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBzBg-0009Ia-KY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 15:47:28 +0200 Original-Received: from localhost ([::1]:48458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBzBf-0007Mo-8F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Jul 2022 09:47:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBz7O-0003wk-Nb for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 09:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBz7O-0004e1-1L for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 09:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oBz7N-0001ui-T2 for bug-gnu-emacs@gnu.org; Thu, 14 Jul 2022 09:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2022 13:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56552-submit@debbugs.gnu.org id=B56552.16578061727336 (code B ref 56552); Thu, 14 Jul 2022 13:43:01 +0000 Original-Received: (at 56552) by debbugs.gnu.org; 14 Jul 2022 13:42:52 +0000 Original-Received: from localhost ([127.0.0.1]:37017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBz7D-0001uG-NV for submit@debbugs.gnu.org; Thu, 14 Jul 2022 09:42:52 -0400 Original-Received: from mail-pj1-f53.google.com ([209.85.216.53]:37855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBz7C-0001u4-MQ for 56552@debbugs.gnu.org; Thu, 14 Jul 2022 09:42:51 -0400 Original-Received: by mail-pj1-f53.google.com with SMTP id y14-20020a17090a644e00b001ef775f7118so8713106pjm.2 for <56552@debbugs.gnu.org>; Thu, 14 Jul 2022 06:42:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=cFgoooyugwuZBooKEjby5gSPumaXwLyEoDXjlnlu754=; b=GiipFFVWjdeU/zpjLSFR8vF54GNTrVd4hB55r/ltmFZ/tyIGMmJJYCcjYtEMV3Pgwm A0qrBc72n3WaeT1WeoqI5cEqXPQnG3ZQrqyzXudv9rt57hE3R1Td3lP+jWwqoflQ+IxJ itDePBRuFPCJB8DDmNyXOlLe3O9pZAe55un95ug1WjIw72Q9XZSFK6QTgVUvZTQvQezD SvWBzmcI1c/sexJGQstg9HIzB9Tqw0n+XFpyIZSnA4vOd/JsNa64cFWRUQvbeokYxLto bj9vpy20iVBdjRuXfB9FXY+Cpq9IdmzdIko0IOTH2RFpQBBGEYgCXOdPLWiZnbD6NeV+ PWVQ== X-Gm-Message-State: AJIora9TqFX+Tx46OmiVlpLLan+31lj0Rx7xVwnHE/a5vWRiiEJcmvPp PCQIRuZO98jt9b2IrfsLgA9FzEsXfGTdzI8g7Vs= X-Google-Smtp-Source: AGRyM1sIzcubSvBdX4V6HG6Y6YpzUZ+IyN6oXnAFgYKx/ENUO4Zv0uXfyRBIfSdu/OEiy3OHExxbSp1FmLX1GV4SEW4= X-Received: by 2002:a17:903:244c:b0:16c:594b:3f4a with SMTP id l12-20020a170903244c00b0016c594b3f4amr8369305pls.145.1657806164738; Thu, 14 Jul 2022 06:42:44 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 14 Jul 2022 06:42:44 -0700 In-Reply-To: <87mtdbswl2.fsf@gmail.com> (Visuwesh's message of "Thu, 14 Jul 2022 18:03:13 +0530") X-Hashcash: 1:20:220714:56552@debbugs.gnu.org::geNtU33yvhwQeCyp:00000000000000000000000000000000000000002trf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236991 Archived-At: Visuwesh writes: > diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el > index 7256e5a2f7..79217d3400 100644 > --- a/lisp/gnus/mm-decode.el > +++ b/lisp/gnus/mm-decode.el > @@ -193,7 +193,11 @@ mm-inline-media-tests > `(("image/p?jpeg" > mm-inline-image > ,(lambda (handle) > - (mm-valid-and-fit-image-p 'jpeg handle))) > + (mm-valid-and-fit-image-p 'jpeg handle))) > + ("image/webp" > + mm-inline-image > + ,(lambda (handle) > + (mm-valid-and-fit-image-p 'webp handle))) > ("image/png" > mm-inline-image > ,(lambda (handle) Maybe this comment belongs in a separate wishlist item, but why isn't this all using the `image-file-name-regexp' function? I'm looking at `org-display-inline-images', and it seems to me that org-mode didn't need any additional changes at all to get support for inline webp images once Emacs had it? So would it be better if Gnus did things more like org-mode? > diff --git a/lisp/net/mailcap.el b/lisp/net/mailcap.el > index 8ba7f1bec3..ee72eba35d 100644 > --- a/lisp/net/mailcap.el > +++ b/lisp/net/mailcap.el > @@ -974,6 +974,7 @@ mailcap-mime-extensions > (".ai" . "application/postscript") > (".jpe" . "image/jpeg") > (".jpeg" . "image/jpeg") > + (".webp" . "image/webp") > (".org" . "text/x-org")) > "An alist of file extensions and corresponding MIME content-types. > This exists for you to customize the information in Lisp. It is This part LGTM.