Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Philip Kaludercic]

Why was the package added to NonGNU ELPA?  We were coordinating to add
the package to GNU ELPA:

https://github.com/joostkremers/visual-fill-column/issues/52

Stefan Kangas <stefankangas@gmail.com> writes:

> branch: main
> commit 791bf67d0a5adc4e7b0ea14849e73a399c0a616d
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
>
>     * elpa-packages (visual-fill-column): New package
> ---
>  elpa-packages | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index dd464ea28f..126195dd0c 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -336,6 +336,11 @@
>  
>   ("vc-fossil"		:url "https://github.com/venks1/emacs-fossil")
>  
> + ("visual-fill-column"  :url "https://codeberg.org/joostkremers/visual-fill-column.git"
> +  :readme "README.md"
> +  :ignored-files ("Cask" "LICENSE" "adaptive-wrap.png" "after.png" "before.png"
> +                  "centered.png" "no-adaptive-wrap.png" "test" ))
> +
>   ("web-mode"		:url "https://github.com/fxbois/web-mode"
>    :ignored-files ("issues" "tests" "run.sh"))
>  
>
>

-- 
	Philip Kaludercic

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Eli Zaretskii]

> From: Philip Kaludercic <philipk@posteo.net>
> Date: Mon, 03 Jan 2022 10:51:03 +0000
> Cc: Stefan Kangas <stefan@marxist.se>
> 
> 
> Why was the package added to NonGNU ELPA?  We were coordinating to add
> the package to GNU ELPA:
> 
> https://github.com/joostkremers/visual-fill-column/issues/52

Why do we need this on any ELPA, when we have a built-in feature for
the same functionality?

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Kévin Le Gouguec]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Date: Mon, 03 Jan 2022 10:51:03 +0000
>> Cc: Stefan Kangas <stefan@marxist.se>
>> 
>> 
>> Why was the package added to NonGNU ELPA?  We were coordinating to add
>> the package to GNU ELPA:
>> 
>> https://github.com/joostkremers/visual-fill-column/issues/52
>
> Why do we need this on any ELPA, when we have a built-in feature for
> the same functionality?

IIUC from <m1bl3baof0.fsf@yahoo.es>, Emacs does not have this feature
yet?  In which case, until it is implemented in the display engine,
having it in ELPA would make sense?

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Eli Zaretskii]

> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
> Cc: Philip Kaludercic <philipk@posteo.net>,  stefan@marxist.se,
>   emacs-devel@gnu.org
> Date: Mon, 03 Jan 2022 14:53:12 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Date: Mon, 03 Jan 2022 10:51:03 +0000
> >> Cc: Stefan Kangas <stefan@marxist.se>
> >> 
> >> 
> >> Why was the package added to NonGNU ELPA?  We were coordinating to add
> >> the package to GNU ELPA:
> >> 
> >> https://github.com/joostkremers/visual-fill-column/issues/52
> >
> > Why do we need this on any ELPA, when we have a built-in feature for
> > the same functionality?
> 
> IIUC from <m1bl3baof0.fsf@yahoo.es>, Emacs does not have this feature
> yet?  In which case, until it is implemented in the display engine,
> having it in ELPA would make sense?

Sorry, I confused this with visual-column-indicator.

But I do think we should implement this in the display engine rather
than in Lisp.

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> But I do think we should implement this in the display engine rather
> than in Lisp.

I agree.

Do we have a bug report for something like that, or should I open one?

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 3 Jan 2022 11:33:03 -0500
> Cc: philipk@posteo.net, emacs-devel@gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > But I do think we should implement this in the display engine rather
> > than in Lisp.
> 
> I agree.
> 
> Do we have a bug report for something like that, or should I open one?

I don't think we have such a bug report, so opening one would be
appreciated, thanks.

I also invite people to work on this, if someone wants to cut their
teeth on the display code.  The job should be relatively simple, and I
can help with orientation.  My initial idea would be to make this
related to display-fill-column-indicator-mode, in the sense that the
text will wrap where the indicator shows it should.

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Stefan Monnier]

Philip Kaludercic [2022-01-03 10:51:03] wrote:
> Why was the package added to NonGNU ELPA?  We were coordinating to add
> the package to GNU ELPA:

I'll let you guys figure out what to do, but in case we move it to GNU
ELPA, let me know since I it'll require some manual work on
elpa.gnu.org.


        Stefan

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

> Why was the package added to NonGNU ELPA?  We were coordinating to add
> the package to GNU ELPA:
>
> https://github.com/joostkremers/visual-fill-column/issues/52

Oops, that's my bad.  I didn't think to check the open issues, as they
are rarely useful.  I'll make it a habit to do that.

What do we prefer to do now?  I'm more than happy to remove the package,
of course.  The alternative is to just keep it there until it is ready
for GNU ELPA, and users will seamlessly upgrade to the new archive.

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Philip Kaludercic]

Stefan Kangas <stefan@marxist.se> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Why was the package added to NonGNU ELPA?  We were coordinating to add
>> the package to GNU ELPA:
>>
>> https://github.com/joostkremers/visual-fill-column/issues/52
>
> Oops, that's my bad.  I didn't think to check the open issues, as they
> are rarely useful.  I'll make it a habit to do that.
>
> What do we prefer to do now?  I'm more than happy to remove the package,
> of course.  The alternative is to just keep it there until it is ready
> for GNU ELPA, and users will seamlessly upgrade to the new archive.

From my understanding GNU ELPA is preferred, and especially with
packages like there where there are just a few significant contributors,
I think checking if the copyright assignments can be collected (or have
already been signed) is worth the effort.

-- 
	Philip Kaludercic

Re: [nongnu] main 791bf67d0a: * elpa-packages (visual-fill-column): New package

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

> From my understanding GNU ELPA is preferred, and especially with
> packages like there where there are just a few significant contributors,
> I think checking if the copyright assignments can be collected (or have
> already been signed) is worth the effort.

I agree, but the question is what to do now about the NonGNU ELPA
package that was added.  Should it be deleted from that archive, or are
we fine with keeping it there until we are ready to add it to GNU ELPA?