From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#73584: 29.3; read-key Date: Wed, 2 Oct 2024 10:02:44 +0000 Message-ID: References: <56f7ea1fff72be793a8026baf34e1548@jovi.net> <86v7yb11wc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28231"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73584@debbugs.gnu.org To: Eli Zaretskii , Devon Sean McCullough Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 02 12:04:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svwDR-00076k-MR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Oct 2024 12:04:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svwDE-0005Aa-71; Wed, 02 Oct 2024 06:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svwDC-0005AJ-96 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 06:04:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svwDB-0006ZG-Vf for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 06:04:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=OM1FB5SHUGbSSHiHrq04auzQFUq6Eb/j4zZ3Ll3MXPM=; b=dRh2ZAeEar1VcXlg+wDpMqWqKDFk4I4+cMipsnCoEOKK1P8hFqdI289KrNrCUJf3DLFZ0MqDhGuQbfVBmMuyUvGehd9TYOEqD+YebPcybCTGuncrxrrWgc9MMUbaADPSp9rjIVI0dPEg7SwyQQ/QrXkJJRvq5E/Ut2TY3mqd3h2Ijg3WduMCFfCzPpbpWDZcWNVM50RwGCdYrc1zVfvc4hA2PVqLulWuqUCHKqa3BMQhKHenT1a3kskmujPQCFUV2kpaHFiECCZJ5LmcM9AuVmq9BW5Ga9JimXKQAdtDX+cB3fVSgEVuBwEAS9x+R/D90k2RyOAtAD4BDlGB2R35FA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svwDC-0005fo-5Q for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2024 06:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2024 10:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73584 X-GNU-PR-Package: emacs Original-Received: via spool by 73584-submit@debbugs.gnu.org id=B73584.172786343521792 (code B ref 73584); Wed, 02 Oct 2024 10:04:02 +0000 Original-Received: (at 73584) by debbugs.gnu.org; 2 Oct 2024 10:03:55 +0000 Original-Received: from localhost ([127.0.0.1]:56655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svwD4-0005fQ-LZ for submit@debbugs.gnu.org; Wed, 02 Oct 2024 06:03:54 -0400 Original-Received: from mail-lj1-f170.google.com ([209.85.208.170]:50340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svwD2-0005f6-HI for 73584@debbugs.gnu.org; Wed, 02 Oct 2024 06:03:53 -0400 Original-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2facf48166bso33611141fa.0 for <73584@debbugs.gnu.org>; Wed, 02 Oct 2024 03:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727863366; x=1728468166; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=OM1FB5SHUGbSSHiHrq04auzQFUq6Eb/j4zZ3Ll3MXPM=; b=h19d5s3d6ox5i9NeidedUruVlGFnE3Jtg2+XCcd0gOz35SFiBk4ruaK/+/qPZke0F/ k5J07FPSHAbUZ5EQGR4ytqZP0hKC7u6lyTcInv2s58qfePI9W3jxrcLt7fgO+nOw2Ob/ 1zeiqpTTeIcVBbC9xb05xdKqyqvBRndpalLEe9WB/KJRFQLDxUQnWAnOoqmrQTMezF87 G9x1aH9OK1T+K4u0NALxVuJWOhLkBe6o2aEcN/8hBpvKHZDl6VrpqRUqawO6EsmilEOX 1RR8rRw95BsUg7HEH/eXfH4ix/8PUt4sxNhEBQK1TmrZi6dqc4OOeuOkUZUZviVcuCgy RJ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727863366; x=1728468166; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OM1FB5SHUGbSSHiHrq04auzQFUq6Eb/j4zZ3Ll3MXPM=; b=FcEvpM3bNtVSR+Mb2DWnPNBsF3Zi9F1jWyH0iPrRX5YF0nLW+/OZWdDXt33ACkXrOb 5bsq1i5k+BeBIUPTrfF/D71MmvZRlQ996SNEazbl/RAkB19lgi9bGP0HRwF9WAcL3pN7 FZSP97EASFBRf2+30laqHc/inOwyFv7HQ/hoGIMkvN7uPLk56kWY/6J+zRrnBzo+v/xG feUvA7S3VlqjqTWvjHK0MYNH95/blH9IL7PvAZ8iZpVL2IsSVSY/vLqhke7AGmIcQyxn Vi3UTyh1Cu4+8Vgs0+Zc+UTdaTcmh2j6pdoRUYkNOgi42ZubXhqCYGeHi4v8ZTzg9dUq yz1Q== X-Gm-Message-State: AOJu0YyUv8Cby4zas5KuFmctuN/zA7CTttflzGGkZEusL4U2A+fisYNZ WRoj+wRKn1XnGDLtsugrZA5J04UuitIytYeBN6g6lyEIMCozChOV6HQRC17dEvoIn3RKYqEhXPC jcRHnxQ0dkoBGr6absnDUsTp0y8w= X-Google-Smtp-Source: AGHT+IFBPuq9xfLNBzgYRQiVI05Qy7tRetV5hrFVmS1Rt0p5c7jpWw6C/gNDce5b996ASd9pA7VCQwFfXGJn5TB1qr4= X-Received: by 2002:a2e:b889:0:b0:2fa:d239:18af with SMTP id 38308e7fff4ca-2fae1015fc3mr15733131fa.13.1727863365598; Wed, 02 Oct 2024 03:02:45 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 2 Oct 2024 10:02:44 +0000 In-Reply-To: <86v7yb11wc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292832 Archived-At: Eli Zaretskii writes: >> Date: Tue, 01 Oct 2024 13:21:11 -0500 >> From: Devon Sean McCullough >> >> (read-key 0) jails Emacs in a null keymap. > > You should be able to escape the jail with ESC or C-[. > > I don't see a bug here. It would arguably be a bit nicer to signal the error early to avoid having to mash C-[: diff --git a/lisp/subr.el b/lisp/subr.el index 2eaed682406..b3872513005 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3307,6 +3307,8 @@ read-key what you want as `read-key' temporarily removes all bindings while calling `read-key-sequence'. If nil or unspecified, the only unbound fallback disabled is downcasing of the last event." + (or (stringp prompt) + (signal 'wrong-type-argument (list 'stringp prompt))) ;; This overriding-terminal-local-map binding also happens to ;; disable quail's input methods, so although read-key-sequence ;; always inherits the input method, in practice read-key does not BTW, do we have something like `cl-check-type' outside of cl-lib?