From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 432c1aa: Use `pop-to-buffer-same-window' in `project-eshell' Date: Fri, 19 Mar 2021 21:06:07 -0500 Message-ID: References: <20210308115905.6593.76443@vcs0.savannah.gnu.org> <20210308115907.30AD520A10@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30964"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov To: =?UTF-8?Q?Simen_Heggest=C3=B8yl?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 20 03:07:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNR18-0007wp-65 for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Mar 2021 03:07:06 +0100 Original-Received: from localhost ([::1]:59924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNR17-0006CA-5e for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 22:07:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNR0F-0005lM-Lt for emacs-devel@gnu.org; Fri, 19 Mar 2021 22:06:11 -0400 Original-Received: from mail-pl1-f180.google.com ([209.85.214.180]:41765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNR0D-0005G0-9s for emacs-devel@gnu.org; Fri, 19 Mar 2021 22:06:10 -0400 Original-Received: by mail-pl1-f180.google.com with SMTP id g10so3758834plt.8 for ; Fri, 19 Mar 2021 19:06:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=PKUooMxCredirrvdEUD0vdD2Mjn6Nvwb3Rk4jJu7oJQ=; b=CvA2yh+IJbc1MIymrvZD8spKQSw+FhwyXQIC9MIw/q6ZAONqG7VqBkpZ79fOLpIS1E jRVBjxHUOtF0l0pM25Et9/VWn9dUw/uGUMxbxMCQ3eDN7/xHrJqVSdyDDdXr53XJxMiG SBMnaD4dpKa+cM77XRV1X1RkyGxP8X3/15wp1DlVVN4j80o7mRY5EN4BUQvGl5sljA4A hG+ipycaFErn+AILB+1bH+imbEMG3/E9Xnzpc5RtQSIVR6cGEmVHWgEABDqF4Q8Ysr+V DPUFki8vL6HNiDmVN+vuW5nuvhjQTvzUme1Yw/dlYhJ+JYkcFQh9I5KwEOSyoq2iaLPK ySpg== X-Gm-Message-State: AOAM531NazieE+zaUrx0SCA4HVfXSonN9H0LhfwrFmEZ1ivL4/Pg6E/z rnlgncSHwogleIUnc9kDUaQ5GgD8YOMzJRrNJxY= X-Google-Smtp-Source: ABdhPJzkwRK92pfSx1l4JV2N1bcATb7pyPeF1af3/Za2lEDod8fwpxJ8M+IBv8h5klnroyMkXhD1bWWm6sWVjXd2uC4= X-Received: by 2002:a17:902:fe07:b029:e6:6cba:d95a with SMTP id g7-20020a170902fe07b02900e66cbad95amr16918277plj.70.1616205967756; Fri, 19 Mar 2021 19:06:07 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 19 Mar 2021 21:06:07 -0500 In-Reply-To: <20210308115907.30AD520A10@vcs0.savannah.gnu.org> Received-SPF: pass client-ip=209.85.214.180; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f180.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266622 Archived-At: simenheg@gmail.com (Simen Heggest=C3=B8yl) writes: > branch: master > commit 432c1aaa80ce109250a93f50858a03ce3d01ca34 > Author: Simen Heggest=C3=B8yl > Commit: Simen Heggest=C3=B8yl > > Use `pop-to-buffer-same-window' in `project-eshell' > > * lisp/progmodes/project.el (project-eshell): Use > `pop-to-buffer-same-window' instead of `pop-to-buffer' to match the > behavior of `M-x eshell'. I'm fine with this change. (I've personally started using `other-window-prefix' to open eshell in another window, which is what I almost always want here.) But now `project-eshell' and `project-shell' behave differently, which seems unfortunate. So if this is the behavior we want, shouldn't we change the latter as well for consistency? (OTOH, I checked the `projectile' package, and it seems to be exhibiting the same difference in behavior between shell and eshell...)