From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59601: 29.0.50; csharp-mode variables missing prefix Date: Sun, 10 Sep 2023 14:30:26 -0700 Message-ID: References: <87lenx4jbo.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5337"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 59601-done@debbugs.gnu.org, Theodor Thornhill To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 23:31:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfS1r-0001El-Ad for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 23:31:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfS1L-0005hL-R2; Sun, 10 Sep 2023 17:31:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfS1D-0005gu-5Q for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 17:30:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfS1C-0003nG-Tj for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 17:30:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfS1G-0004LC-BC for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 17:31:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59601 X-GNU-PR-Package: emacs Mail-Followup-To: 59601@debbugs.gnu.org, stefankangas@gmail.com, stefankangas@gmail.com Original-Received: via spool by 59601-done@debbugs.gnu.org id=D59601.169438144016651 (code D ref 59601); Sun, 10 Sep 2023 21:31:02 +0000 Original-Received: (at 59601-done) by debbugs.gnu.org; 10 Sep 2023 21:30:40 +0000 Original-Received: from localhost ([127.0.0.1]:51501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfS0t-0004KV-T6 for submit@debbugs.gnu.org; Sun, 10 Sep 2023 17:30:40 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:50487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfS0r-0004KF-Ex for 59601-done@debbugs.gnu.org; Sun, 10 Sep 2023 17:30:39 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bcbfb3705dso61575631fa.1 for <59601-done@debbugs.gnu.org>; Sun, 10 Sep 2023 14:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694381427; x=1694986227; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yzLCQF0lrKzrYqHDKXxpOhQbJ+VWbpqJJjxS4+UKqrY=; b=PEQ+HcqmfM+ZXngSDi/GupD4DV1zEjvZJjuC8AjaJPnXfZjgx3f2a5HZzZrmGnid+K L3bhn0/6EII+ayioON9nK2mj74tyaLsB7vVjm6tj2cZHNOpNM+EUfF2CU28HMQucbODq oKMcyjRpmTDrbTw7j2HTFIyswfLCYDW3CtzFRS4TweeLibcH9DLONIuGaoE61wbRTMsp 89erZDZrYDjUz9OsxqpYNtr4q/sz5Xf30kPvuxq2Xj4ykiDlnZdY6uE+7g0xq+eXwxyq 3e0SCNNUlp0ckIZzSMARLTtViIr8z/6AnrJbk1I5I2fOvLY05uCfuw1JGtiDwplUIsxf Urpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694381427; x=1694986227; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yzLCQF0lrKzrYqHDKXxpOhQbJ+VWbpqJJjxS4+UKqrY=; b=HanNOFYfOXEFHDM6jLlwtgETznNKRn06g8RQ2l8qzEKZ0cf0t+dsH1olxBkQEaJ4U2 8dykvaeogtc28pqj5IM+TO937BLEir6KF/QyHhiN24l1hzPBy05Y8/GyBHz+ifpVDKhp OtcqInEyJG3Ey/rwdaO/eOKOpSRvKySqFgJeerlQ4pmTI2IGkpClJJ8xP+c1OXr71Zyx vfTVE+vdMzgwz05mfcKxADwfdbW1T/wwfknDXjvCa4cxVx3Siiex0pULxYii8RY7TYEB OwYK0Uj1/ijHOJ8zg4cNJo4mJWLeiXVgnUjniUSrEXdvEFR51ulxFI4n8He7mNwAcD14 Ypow== X-Gm-Message-State: AOJu0YxQOf6F5NXSUyJBaxUDBqnrT/B+8M72y8J0pJfaYye7u40+f5tO 06znqynljtsmkPFfaxASXKXpVIUGoYfM0AANNm0= X-Google-Smtp-Source: AGHT+IE/hRWFfZZ899IiYVVSzVxE9T/bbqR8i+2aurkVJ3KexG2WQwCsSBsi2hmzRP/hjGeMERR6eaOVZONeEnuzChc= X-Received: by 2002:a2e:8752:0:b0:2bd:1246:cdce with SMTP id q18-20020a2e8752000000b002bd1246cdcemr6705811ljj.10.1694381426821; Sun, 10 Sep 2023 14:30:26 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 14:30:26 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270008 Archived-At: Alan Mackenzie writes: > The codedoc variables should _not_ have a csharp- prefix. Conceptually, > codedoc is not part of csharp-mode, and could start being used by any CC > Mode mode, just as gtkdoc is used by both C and C++ modes. > > Also, "codedoc" (like "gtkdoc", etc.) is prefixed to > "-font-lock-doc-comments" and the result interned to get the function to > fontify the doc comments. Thus codedoc-font-lock-doc-comments _will_ be > getting used. > > So, yes, the naming convention is essential to the working of CC Mode's > doc comments. > > Whether it would be the Right Thing to add codedoc to CC Mode itself, > I'm not sure. doxygen was added quite recently, but that is genuinely a > language independent format. I'm a little worried about getting some > coupling between, say, csharp-mode and CC Mode where there wasn't any > before. Thank you, that clears things up. I agree that we should not do any changes here, and we certainly want to avoid any coupling if we don't need it. Thank you for taking the time to explain. I opened this bug, so I hope that it will be fine if I close it. I'm therefore doing that with this email.