From: Stefan Kangas <stefankangas@gmail.com>
To: "J.P." <jp@neverwas.me>
Cc: 60730-done@debbugs.gnu.org
Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file
Date: Thu, 12 Jan 2023 17:56:33 -0800 [thread overview]
Message-ID: <CADwFkmmVH9D1H9qu2bhOytO-_U-ttqwOWxgYr6VGONKGMorPrg@mail.gmail.com> (raw)
In-Reply-To: <87o7r5ji3q.fsf@neverwas.me> (J. P.'s message of "Wed, 11 Jan 2023 05:50:17 -0800")
"J.P." <jp@neverwas.me> writes:
> Pretty sure this is just a (functional) typo.
[...]
> diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el
> index 83705ca5b8..7cf60bfeae 100644
> --- a/lisp/emacs-lisp/ert-x.el
> +++ b/lisp/emacs-lisp/ert-x.el
> @@ -496,7 +496,7 @@ ert-with-temp-file
> (progn ,@body)
> (ignore-errors
> ,@(when buffer
> - (list `(with-current-buffer buf
> + (list `(with-current-buffer ,buffer
> (set-buffer-modified-p nil))
> `(kill-buffer ,buffer))))
> (ignore-errors
>
> seems to make it go away.
Thanks, fixed on emacs-29 (commit f27a330b99e).
next prev parent reply other threads:[~2023-01-13 1:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:50 bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file J.P.
2023-01-13 1:56 ` Stefan Kangas [this message]
2023-01-28 14:13 ` J.P.
2023-01-28 15:03 ` Eli Zaretskii
2023-01-28 15:56 ` J.P.
2023-01-28 16:13 ` Eli Zaretskii
2023-01-29 2:00 ` J.P.
2023-01-29 4:35 ` J.P.
2023-01-29 6:38 ` Eli Zaretskii
2023-01-29 14:08 ` J.P.
2023-01-29 15:10 ` Eli Zaretskii
2023-01-29 16:18 ` J.P.
2023-01-29 6:28 ` Eli Zaretskii
2023-01-29 9:56 ` Andreas Schwab
2023-01-29 10:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmVH9D1H9qu2bhOytO-_U-ttqwOWxgYr6VGONKGMorPrg@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=60730-done@debbugs.gnu.org \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.