From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>
Cc: luangruo@yahoo.com, emacs-devel@gnu.org,
"Mattias Engdegård" <mattias.engdegard@gmail.com>
Subject: Re: master d995429e7bc: Use SBYTES instead of strlen in treesit.c
Date: Tue, 23 Jul 2024 13:42:55 -0700 [thread overview]
Message-ID: <CADwFkmmUqSHeEEwEhYu5v7JifC1dt-RxueVxK_s_iOmTHCsonA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=LcCKnV0_QWJLtADavEEPeKMst2vgemCKmaTn7xLrBgA@mail.gmail.com>
Stefan Kangas <stefankangas@gmail.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> > Have you verified that these functions accept strings holding '\0'?
>>>
>>> AFAIK, SBYTES returns the string length excluding '\0', same as strlen.
>>
>> That's not the issue here. The issue is that Emacs Lisp strings can
>> include embedded null bytes, which strlen will exclude, but SBYTES
>> will not.
>
> We avoid that when they are converted from a sexp (see
> treesit_query_string_string).
>
> Perhaps we should do the same when we get a string?
Mattias, I see you introduced treesit_query_string_string.
Do you have any thoughts about this?
next prev parent reply other threads:[~2024-07-23 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172164369582.30827.14373383262408294645@vcs2.savannah.gnu.org>
[not found] ` <20240722102136.6C9D6C3534A@vcs2.savannah.gnu.org>
2024-07-22 10:27 ` master d995429e7bc: Use SBYTES instead of strlen in treesit.c Po Lu
2024-07-22 11:06 ` Stefan Kangas
2024-07-22 11:30 ` Eli Zaretskii
2024-07-22 11:55 ` Stefan Kangas
2024-07-22 12:22 ` Eli Zaretskii
2024-07-23 20:42 ` Stefan Kangas [this message]
2024-07-24 9:09 ` Mattias Engdegård
2024-07-24 11:33 ` Stefan Kangas
2024-07-24 12:02 ` Mattias Engdegård
2024-07-23 17:09 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmUqSHeEEwEhYu5v7JifC1dt-RxueVxK_s_iOmTHCsonA@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=mattias.engdegard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.